Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-3745] Clean up abandoned user dirs #1897

Merged
merged 1 commit into from Jan 30, 2020

Conversation

lkishalmi
Copy link
Contributor

This one is pretty trivial.

@lkishalmi
Copy link
Contributor Author

Janitor1

@ebarboni
Copy link
Contributor

@lkishalmi I put in beta 2.

@ebarboni ebarboni added this to the 11.3 milestone Jan 29, 2020
@ebarboni ebarboni merged commit 7106cd4 into apache:master Jan 30, 2020
@neilcsmith-net
Copy link
Member

@lkishalmi any way to only run this on first launch, or offer the option to mute rather than remove? This is rapidly becoming my least favourite feature of beta2. cc/ @geertjanw

@GeertjanWielenga
Copy link

Would indeed be an idea to have it disabled by default and require a setting in netbeans.conf and/or Options window to enable it. The feature itself is very useful but also potentially very noisy in its current default state.

@neilcsmith-net
Copy link
Member

@geertjanw I agree with the idea of having it enabled by default, because for many users that's right (at least once), but there really needs to be a way to tell it to shut up - I get what you were complaining about at FOSDEM now! 😄

@lkishalmi or maybe we use similar logic as https://github.com/apache/netbeans/blob/master/platform/uihandler/src/org/netbeans/modules/uihandler/Installer.java#L331 to only run this on second run of IDE? I assume there's no chance of overlap with import upgrade task with this - ie. removing a userdir in process of being imported?

@ebarboni
Copy link
Contributor

ebarboni commented Feb 5, 2020

I did not notice the annoyance but any PR to solve welcome.

@lkishalmi
Copy link
Contributor Author

I'm going to work something out for that.

@lkishalmi lkishalmi deleted the janitor branch February 5, 2020 17:14
@lkishalmi
Copy link
Contributor Author

See #1925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants