Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-4465] - update RAT license exceptions #2200

Merged
merged 1 commit into from Jul 8, 2020

Conversation

BradWalker
Copy link
Member

@BradWalker BradWalker commented Jun 17, 2020

When running the RAT report after a build has taken place, the report
picks up hundreds of build generated files. These files do not have a license
header and it's really not necessary as they are generated by the build process..

When running the RAT report after a build has taken place, the report
picks up hundreds of generated files. These files do not have a license
header and it's really not necessary as they are generated by the build process..
@lkishalmi lkishalmi added this to the 12.1 milestone Jul 6, 2020
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, though RAT should be run on a clean checkout, not after a build.

@BradWalker
Copy link
Member Author

Hey @matthiasblaesing, thanks for approving the changes.. I agree with your comments about running the RAT report after running the "ant clean" task..

I have 1000s of files that need to have the license updated in the C/C++ contribution.. This is why I've been running the RAT report after doing a build to test to make sure I'm not missing something. So it does help me in that regard..

FYI.

Copy link
Contributor

@jlahoda jlahoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An even better way would be to stop generating source into the source directories. But that can be done separately.

@matthiasblaesing
Copy link
Contributor

Ok - lets get this in.

@matthiasblaesing matthiasblaesing merged commit a4d306b into apache:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants