Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-830][NETBEANS-831] Fix license info for jaxb implementation #582

Merged

Conversation

@matthiasblaesing
Copy link
Contributor

commented Jun 6, 2018

The license infos were extracted/retrieved from the sources of the
originating projects. JAXB1 and XJC are both missing the license
references.

The license infos were extracted/retrieved from the sources of the
originating projects. JAXB1 and XJC are both missing the license
references.
@matthiasblaesing

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2018

@emilianbold could you please have a look at this? If agreed upon, I would push the same changeset to release90 without another review.

License: CDDL-1.1-BSD-MIT-jaxb1-xjc
Files: jaxb1-impl-2.2.5-2.jar

=========== Parts of the work are: ===========

This comment has been minimized.

Copy link
@emilianbold

emilianbold Jun 7, 2018

Contributor

This is odd. Which parts is under which license? I don't believe we have another dependency under a mix of licenses (or do we?).

I assume it's a fat JAR which bundles multiple package names each with different licenses?

License: CDDL-1.1-MIT-jaxb-xjc
Files: jaxb-xjc-2.2.5-2.jar

Parts of the work are:

This comment has been minimized.

Copy link
@emilianbold

emilianbold Jun 7, 2018

Contributor

Same here. I assume it's a fat JAR, with the org/kohsuke package under one license, com/sun under another, etc?

@matthiasblaesing

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2018

With regard to the multiple licenses: yes the JARs contain source-code from other projects and from my POV this is the problem Justin made us aware of. The Source jars from maven central are also very thin on info about the license. One of the best sources in the end was:

https://github.com/javaee/glassfish/issues/22474

There for jaxb1 the base projects are mentioned and I deduced from the contents of the JARs (packages) and the sources, which licenses need to be applied.

@emilianbold

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2018

Makes sense. Shouldn't we also create a file under nbbuild/licenses/ ?

@emilianbold

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2018

Sorry, I must have scrolled over them.

+1 from me.

@matthiasblaesing

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2018

Thank you for going through this!

@matthiasblaesing matthiasblaesing merged commit 9d39c80 into apache:master Jun 7, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matthiasblaesing matthiasblaesing deleted the matthiasblaesing:netbeans-830_netbeans-831 branch Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.