Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-1526 Add ConsumeJournald to consume systemd journal messages #1044

Closed
wants to merge 28 commits into from

Conversation

szaszm
Copy link
Member

@szaszm szaszm commented Apr 6, 2021

  • libsystemd might be problematic license-wise. I might have to work around it with dlopen.
  • Still figuring out what would be the best way to test this.
  • Tests are failing, work in progress, but submitting the PR anyway to see the reaction and gather opinions.

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@szaszm szaszm marked this pull request as ready for review April 22, 2021 13:45
@szaszm szaszm changed the title [WIP] MINIFICPP-1526 Add ConsumeJournald to consume systemd journal messages MINIFICPP-1526 Add ConsumeJournald to consume systemd journal messages Apr 22, 2021
@szaszm szaszm force-pushed the consume_journald branch 2 times, most recently from e25af64 to 20800ef Compare April 22, 2021 20:08
Copy link
Contributor

@fgerlits fgerlits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor comments

CMakeLists.txt Outdated Show resolved Hide resolved
bstrp_functions.sh Outdated Show resolved Hide resolved
extensions/systemd/ConsumeJournald.cpp Show resolved Hide resolved
extensions/systemd/ConsumeJournald.cpp Show resolved Hide resolved
extensions/systemd/ConsumeJournald.cpp Outdated Show resolved Hide resolved
extensions/systemd/WorkerThread.h Outdated Show resolved Hide resolved
@lordgamez
Copy link
Contributor

When I try testing the processor manually on my local machine it fails with the following error:

[2021-05-13 14:00:02.434] [org::apache::nifi::minifi::core::ProcessGroup] [error] Failed to start processor d9606075-a35a-4509-b705-13e793e1b82b (ConsumeJournald): sd_journal_get_cursor: Cannot assign requested address

I could only find a similar issue but I did not find a solution for it, so it still needs to be investigated.

szaszm and others added 17 commits May 19, 2021 14:34
Now it's only dlopen()'ed when used, which should be fine both with LGPL
and Apache License.
Co-authored-by: Martin Zink <martin.zink@protonmail.com>
- linter enable and fix (disabled whitespace before range for colon)
- invalid properties now throw
- removed headers from CMakeLists.txt
- enum properties are now case sensitive
- simplified FlowFile::setAttribute
- reuse remove_cvref_t from our own gsl.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants