-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFICPP-1526 Add ConsumeJournald to consume systemd journal messages #1044
Conversation
e25af64
to
20800ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor comments
When I try testing the processor manually on my local machine it fails with the following error:
I could only find a similar issue but I did not find a solution for it, so it still needs to be investigated. |
Now it's only dlopen()'ed when used, which should be fine both with LGPL and Apache License.
Co-authored-by: Martin Zink <martin.zink@protonmail.com>
- linter enable and fix (disabled whitespace before range for colon) - invalid properties now throw - removed headers from CMakeLists.txt - enum properties are now case sensitive - simplified FlowFile::setAttribute - reuse remove_cvref_t from our own gsl.h
dlopen
.Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.