From 09b35f3ab12b8ceccc2ca37484eeb2c758995eab Mon Sep 17 00:00:00 2001 From: Aldrin Piri Date: Tue, 18 Oct 2016 16:19:54 -0400 Subject: [PATCH] Add the PR template to the repository. --- .github/PULL_REQUEST_TEMPLATE.md | 27 +++++++++++++++++++++++++++ pom.xml | 1 + 2 files changed, 28 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 000000000..e76fd4362 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,27 @@ +Thank you for submitting a contribution to Apache NiFi - MiNiFi. + +In order to streamline the review of the contribution we ask you +to ensure the following steps have been taken: + +### For all changes: +- [ ] Is there a JIRA ticket associated with this PR? Is it referenced + in the commit message? + +- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. + +- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? + +- [ ] Is your initial contribution a single, squashed commit? + +### For code changes: +- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder? +- [ ] Have you written or updated unit tests to verify your changes? +- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? +- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly? +- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly? + +### For documentation related changes: +- [ ] Have you ensured that format looks appropriate for the output in which it is rendered? + +### Note: +Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. diff --git a/pom.xml b/pom.xml index aebe315c3..f5cdae0d0 100644 --- a/pom.xml +++ b/pom.xml @@ -777,6 +777,7 @@ limitations under the License. nbactions.xml DEPENDENCIES .travis.yml + .github/PULL_REQUEST_TEMPLATE.md