New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-3431: Support batch update in Notify processor #1466

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@ijokarumawak
Contributor

ijokarumawak commented Feb 2, 2017

  • Added Signal Counter Delta property
  • Added Signal Buffer Count property
  • Changed IOException handling from routing it to failure to throw
    RuntimeException, so that NiFi framework can yield the processor for a while and try again

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@ijokarumawak

This comment has been minimized.

Show comment
Hide comment
@ijokarumawak

ijokarumawak Feb 2, 2017

Contributor

Dear reviewer, I wrote a blog post on how to use Wait/Notify processors which can take benefit from this PR. I hope this helps:
http://ijokarumawak.github.io/nifi/2017/02/02/nifi-notify-batch/

Contributor

ijokarumawak commented Feb 2, 2017

Dear reviewer, I wrote a blog post on how to use Wait/Notify processors which can take benefit from this PR. I hope this helps:
http://ijokarumawak.github.io/nifi/2017/02/02/nifi-notify-batch/

NIFI-3431: Support batch update in Notify processor
- Added Signal Counter Delta property
- Added Signal Buffer Count property
- Added processor property name and display name
- Changed IOException handling from routing it to failure to throw
  RuntimeException, so that NiFi framework can yield the processor for a while and try again

@ijokarumawak ijokarumawak referenced this pull request Feb 13, 2017

Closed

NIFI-3452: Add Wait processor Wait Mode property #1490

7 of 11 tasks complete

@asfgit asfgit closed this in a90fa9c Feb 15, 2017

@pvillard31

This comment has been minimized.

Show comment
Hide comment
@pvillard31

pvillard31 Feb 15, 2017

Contributor

👍 full build with contrib-check, tested a workflow based on the example you provided in your excellent post. Thanks @ijokarumawak, merged to master.

Contributor

pvillard31 commented Feb 15, 2017

👍 full build with contrib-check, tested a workflow based on the example you provided in your excellent post. Thanks @ijokarumawak, merged to master.

aperepel added a commit to aperepel/nifi that referenced this pull request Mar 29, 2017

NIFI-3431: Support batch update in Notify processor
- Added Signal Counter Delta property
- Added Signal Buffer Count property
- Added processor property name and display name
- Changed IOException handling from routing it to failure to throw
  RuntimeException, so that NiFi framework can yield the processor for a while and try again

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#1466.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment