New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-3809 - Added HTTP mode and HTTP proxy for S2S Reporting Tasks #1754

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@pvillard31
Contributor

pvillard31 commented May 4, 2017

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@ijokarumawak

This comment has been minimized.

Show comment
Hide comment
@ijokarumawak

ijokarumawak May 24, 2017

Contributor

Reviewing...

Contributor

ijokarumawak commented May 24, 2017

Reviewing...

@ijokarumawak

@pvillard31 I checkout out and build the PR but didn't see proxy options from reporting tasks. Please check. Thanks!

.description("Specifies how many records to send in a single batch, at most.")
.required(true)
.defaultValue("1000")
.addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
.build();
static final PropertyDescriptor TRANSPORT_PROTOCOL = new PropertyDescriptor.Builder()

This comment has been minimized.

@ijokarumawak

ijokarumawak May 24, 2017

Contributor

If I am not missing anything, these newly added PropertyDescriptors should be used by sub classes such as SiteToSiteBulletinReportingTask?

@ijokarumawak

ijokarumawak May 24, 2017

Contributor

If I am not missing anything, these newly added PropertyDescriptors should be used by sub classes such as SiteToSiteBulletinReportingTask?

@pvillard31

This comment has been minimized.

Show comment
Hide comment
@pvillard31

pvillard31 May 24, 2017

Contributor

Hey @ijokarumawak, thanks for the review! Good catch! This reporting task is not calling super.getSupportedPropertyDescriptors()... I pushed another commit to address it, let me know if you want me to rebase the PR or if you have additional comments.

Contributor

pvillard31 commented May 24, 2017

Hey @ijokarumawak, thanks for the review! Good catch! This reporting task is not calling super.getSupportedPropertyDescriptors()... I pushed another commit to address it, let me know if you want me to rebase the PR or if you have additional comments.

@ijokarumawak

This comment has been minimized.

Show comment
Hide comment
@ijokarumawak

ijokarumawak May 25, 2017

Contributor

Thanks for the update @pvillard31 . I confirmed Proxy can be specified with all three reporting tasks. LGTM +1. I'm going to squash commits and merge into master. Thank you!

Contributor

ijokarumawak commented May 25, 2017

Thanks for the update @pvillard31 . I confirmed Proxy can be specified with all three reporting tasks. LGTM +1. I'm going to squash commits and merge into master. Thank you!

@asfgit asfgit closed this in e050055 May 25, 2017

peter-gergely-horvath added a commit to peter-gergely-horvath/nifi that referenced this pull request Jun 28, 2017

NIFI-3809 - Added HTTP mode and HTTP proxy for S2S Reporting Tasks
This closes apache#1754.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>

peter-gergely-horvath added a commit to peter-gergely-horvath/nifi that referenced this pull request Jun 28, 2017

NIFI-3809 - Added HTTP mode and HTTP proxy for S2S Reporting Tasks
This closes apache#1754.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>

peter-gergely-horvath added a commit to peter-gergely-horvath/nifi that referenced this pull request Jul 3, 2017

NIFI-3809 - Added HTTP mode and HTTP proxy for S2S Reporting Tasks
This closes apache#1754.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>

mattyb149 pushed a commit to mattyb149/nifi that referenced this pull request Nov 30, 2017

NIFI-3809 - Added HTTP mode and HTTP proxy for S2S Reporting Tasks
This closes apache#1754.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment