New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-4127: Composite User Group Providers #1978

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@mcgilman
Contributor

mcgilman commented Jul 5, 2017

NIFI-4127:

  • Introducing composite ConfigurableUserGroupProvider and UserGroupProvider.
  • Adding appropriate unit tests.
  • Updating object model to support per resource (user/group/policy) configuration.
  • Updating UI to support per resource (user/group/policy) configuration.
  • Adding necessary documentation.
NIFI-4127:
- Introducing composite ConfigurableUserGroupProvider and UserGroupProvider.
- Adding appropriate unit tests.
- Updating object model to support per resource (user/group/policy) configuration.
- Updating UI to support per resource (user/group/policy) configuration.
- Adding necessary documentation.
@pvillard31

This comment has been minimized.

Show comment
Hide comment
@pvillard31

pvillard31 Jul 6, 2017

Contributor

Reviewing...

Contributor

pvillard31 commented Jul 6, 2017

Reviewing...

@pvillard31

Hey @mcgilman! I played a bit with this PR and everything is working as expected. I tried the CompositeUserGroupProvider with two LDAP servers and the CompositeConfigurableUserGroupProvider with two LDAP servers + the file provider. All good! I just left few comments regarding the documentation update, it's really minor. Otherwise I'm a +1.

NIFI-4127:
- Updating documentation to clarify integrity checks.
- Providing an example of configuring a composite implementation.
@mcgilman

This comment has been minimized.

Show comment
Hide comment
@mcgilman

mcgilman Jul 7, 2017

Contributor

@pvillard31 A second commit has been pushed updating the documentation and providing an example of the composite configurable user group provider. Thanks again for the review!

Contributor

mcgilman commented Jul 7, 2017

@pvillard31 A second commit has been pushed updating the documentation and providing an example of the composite configurable user group provider. Thanks again for the review!

@pvillard31

This comment has been minimized.

Show comment
Hide comment
@pvillard31

pvillard31 Jul 11, 2017

Contributor

+1, thanks @mcgilman, I'll squash and merge to master.

Contributor

pvillard31 commented Jul 11, 2017

+1, thanks @mcgilman, I'll squash and merge to master.

@asfgit asfgit closed this in eefad29 Jul 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment