NIFI-3335: Add initial.maxvalue support to GenerateTableFetch #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvillard31
reviewed
Jul 26, 2017
| @@ -198,6 +201,25 @@ public void onTrigger(final ProcessContext context, final ProcessSessionFactory | |||
| // set as the current state map (after the session has been committed) | |||
| final Map<String, String> statePropertyMap = new HashMap<>(stateMap.toMap()); | |||
|
|
|||
| // If an initial max value for column(s) has been specified using properties, and this column is not in the state manager, sync them to the state property map | |||
| final Map<String,String> maxValueProperties = getDefaultMaxValueProperties(context.getProperties()); | |||
There was a problem hiding this comment.
Would it make sense to do it in the @OnScheduled method of the Abstract class? You could have the same code in common for QueryDatabaseTable and GenerateTableFetch. Besides not sure it needs to be done each time the processor is triggered? Thoughts?
There was a problem hiding this comment.
Yeah that's a better idea, should've been done in the original PR but I missed it during my review and just cut-pasted it back to the abstract class to share.
I won't be able to move all that common code block as it needs the table name which can come from a flow file. But I can call getDefaultMaxValueProperties() at schedule-time vs trigger time.
pvillard31
approved these changes
Jul 27, 2017
pvillard31
pushed a commit
to pvillard31/nifi
that referenced
this pull request
Jan 3, 2019
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#2039.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the common code back to the abstract base class
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.