New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-4450 Update Kite SDK version #2187

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@gglanzani
Contributor

gglanzani commented Oct 1, 2017

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?

I have restricted myself to the kite-nar tests, are nifi-processing tests are failing for, to me, some extraneous reason.

  • Have you written or updated unit tests to verify your changes?

Not relevant.

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Yes, jackson is released under the same Apache license

  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

<findbugs-annotations.version>1.3.9-1</findbugs-annotations.version>
<jackson.version>2.3.1</jackson.version>

This comment has been minimized.

@bbende

bbende Oct 4, 2017

Contributor

Any specific reason for adding the jackson dependencies?

Looking at the Kite NAR from master, it appears to already include a newer version of Jackson:

ls -l work/nar/extensions/nifi-kite-nar-1.5.0-SNAPSHOT.nar-unpacked/META-INF/bundled-dependencies/ | grep jackson
-rw-r--r--  1 bbende  staff    46968 Oct  4 13:57 jackson-annotations-2.6.0.jar
-rw-r--r--  1 bbende  staff   258833 Oct  4 13:57 jackson-core-2.6.1.jar
-rw-r--r--  1 bbende  staff  1166488 Oct  4 13:57 jackson-databind-2.6.1.jar
-rw-r--r--  1 bbende  staff  1029033 Oct  4 13:57 parquet-jackson-1.4.1.jar
@bbende

bbende Oct 4, 2017

Contributor

Any specific reason for adding the jackson dependencies?

Looking at the Kite NAR from master, it appears to already include a newer version of Jackson:

ls -l work/nar/extensions/nifi-kite-nar-1.5.0-SNAPSHOT.nar-unpacked/META-INF/bundled-dependencies/ | grep jackson
-rw-r--r--  1 bbende  staff    46968 Oct  4 13:57 jackson-annotations-2.6.0.jar
-rw-r--r--  1 bbende  staff   258833 Oct  4 13:57 jackson-core-2.6.1.jar
-rw-r--r--  1 bbende  staff  1166488 Oct  4 13:57 jackson-databind-2.6.1.jar
-rw-r--r--  1 bbende  staff  1029033 Oct  4 13:57 parquet-jackson-1.4.1.jar

This comment has been minimized.

@gglanzani

gglanzani Oct 4, 2017

Contributor

Well, the thing is... the tests would fail without jackson. So I've looked at the pom.xml provided by Kite, and just plugged that into nifi-kite.

Are your tests successful without that addition and kite 1.1.0?

@gglanzani

gglanzani Oct 4, 2017

Contributor

Well, the thing is... the tests would fail without jackson. So I've looked at the pom.xml provided by Kite, and just plugged that into nifi-kite.

Are your tests successful without that addition and kite 1.1.0?

This comment has been minimized.

@bbende

bbende Oct 4, 2017

Contributor

Good question :) l didn't get to building it, let me play around with it and get back to you.

@bbende

bbende Oct 4, 2017

Contributor

Good question :) l didn't get to building it, let me play around with it and get back to you.

This comment has been minimized.

@bbende

bbende Oct 4, 2017

Contributor

Ok you were right, here is what is happening...

Kite SDK 1.0.0 has a dependency only on jackson-databind 2.3.1, which transitively depends on jackson-core 2.3.1 and jackson-annotations 2.3.1, but NiFi is overriding all uses of jackson-databind to 2.6.1 so previously you got all three of those jars at 2.6.1.

Kite SDK 1.1.0 directly declares all three jars, so then NiFi overrides jackson-databind to 2.6.1, but jackson-annotations and jackson-core are still at 2.3.1 because that is what Kite declared.

There is another effort going on to clean up some of the dependencies (https://issues.apache.org/jira/browse/NIFI-4297) and I believe part of that is going to remove the part of NiFi that is forcing everything to databind 2.6.1.

I'd prefer to wait for that to happen first, then we can simplify things here and remove all of the jackson stuff from this PR and everything should work. Let me know if there is any issue with that.

@bbende

bbende Oct 4, 2017

Contributor

Ok you were right, here is what is happening...

Kite SDK 1.0.0 has a dependency only on jackson-databind 2.3.1, which transitively depends on jackson-core 2.3.1 and jackson-annotations 2.3.1, but NiFi is overriding all uses of jackson-databind to 2.6.1 so previously you got all three of those jars at 2.6.1.

Kite SDK 1.1.0 directly declares all three jars, so then NiFi overrides jackson-databind to 2.6.1, but jackson-annotations and jackson-core are still at 2.3.1 because that is what Kite declared.

There is another effort going on to clean up some of the dependencies (https://issues.apache.org/jira/browse/NIFI-4297) and I believe part of that is going to remove the part of NiFi that is forcing everything to databind 2.6.1.

I'd prefer to wait for that to happen first, then we can simplify things here and remove all of the jackson stuff from this PR and everything should work. Let me know if there is any issue with that.

This comment has been minimized.

@gglanzani

gglanzani Oct 5, 2017

Contributor

Sure, I got no problem with that!

@gglanzani

gglanzani Oct 5, 2017

Contributor

Sure, I got no problem with that!

@asfgit asfgit closed this in 59b60e6 Oct 6, 2017

@bbende

This comment has been minimized.

Show comment
Hide comment
@bbende

bbende Oct 6, 2017

Contributor

The change in master was made that now allows kite to just bring in all of its own 2.3.1 dependencies, so I merged your commit without the Jackson additions. Thanks.

Contributor

bbende commented Oct 6, 2017

The change in master was made that now allows kite to just bring in all of its own 2.3.1 dependencies, so I merged your commit without the Jackson additions. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment