From 0280f59a173e82df926acc9c6f50ef3b5302c9fa Mon Sep 17 00:00:00 2001 From: Ed Date: Tue, 27 Mar 2018 00:22:12 -0400 Subject: [PATCH] NIFI-4388: Modules Not Honored Modules aren't honored. The bug is not reproducible in Jython (it handles modules with every script reload). But Groovy loads JARs and dirs with classes only on setup. Cannot provide test cases for Groovy, because it requires custom JARs to be provided as part of the package. --- .../nifi/processors/script/InvokeScriptedProcessor.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java b/nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java index 06a042e4a3b2..032be32dfc92 100644 --- a/nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java +++ b/nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java @@ -245,10 +245,7 @@ public void onPropertyModified(final PropertyDescriptor descriptor, final String || ScriptingComponentUtils.MODULES.equals(descriptor) || scriptingComponentHelper.SCRIPT_ENGINE.equals(descriptor)) { scriptNeedsReload.set(true); - // Need to reset scriptEngine if the value has changed - if (scriptingComponentHelper.SCRIPT_ENGINE.equals(descriptor)) { - scriptEngine = null; - } + scriptEngine = null; //reset engine. This happens only when a processor is stopped, so there won't be any performance impact in run-time. } else if (instance != null) { // If the script provides a Processor, call its onPropertyModified() method try {