New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-5047 Fixed a bug in PutMongo that prevented it from working if t… #2609

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@MikeThomsen
Contributor

MikeThomsen commented Apr 6, 2018

…he mode is insert and the query/query key are not set.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

NIFI-5047 Fixed a bug in PutMongo that prevented it from working if t…
…he mode is insert and the query/query key are not set.
@MikeThomsen

This comment has been minimized.

Show comment
Hide comment
@MikeThomsen

MikeThomsen Apr 6, 2018

Contributor

I tested this with a unit test and a flow that exercised all three options for PutMongo separately, so it should be good now.

Contributor

MikeThomsen commented Apr 6, 2018

I tested this with a unit test and a flow that exercised all three options for PutMongo separately, so it should be good now.

@ottobackwards

This comment has been minimized.

Show comment
Hide comment
@ottobackwards

ottobackwards Apr 6, 2018

Contributor

Should there be a test for just the INSERT mode that corresponds to the problem too?

Contributor

ottobackwards commented Apr 6, 2018

Should there be a test for just the INSERT mode that corresponds to the problem too?

@MikeThomsen

This comment has been minimized.

Show comment
Hide comment
@MikeThomsen

MikeThomsen Apr 6, 2018

Contributor

That's what the unit test is supposed to provide.

Contributor

MikeThomsen commented Apr 6, 2018

That's what the unit test is supposed to provide.

@ottobackwards

This comment has been minimized.

Show comment
Hide comment
@ottobackwards

ottobackwards Apr 6, 2018

Contributor

I apologize, I miss read it as a test for one thing, not multiple. I missed the top part. Please excuse me

Contributor

ottobackwards commented Apr 6, 2018

I apologize, I miss read it as a test for one thing, not multiple. I missed the top part. Please excuse me

@MikeThomsen

This comment has been minimized.

Show comment
Hide comment
@MikeThomsen

MikeThomsen Apr 6, 2018

Contributor

NP.

Contributor

MikeThomsen commented Apr 6, 2018

NP.

@ottobackwards

This comment has been minimized.

Show comment
Hide comment
@ottobackwards

ottobackwards Apr 6, 2018

Contributor

mvn install with contrib-check runs fine, tests look good.
+1 ( fwiw)

Contributor

ottobackwards commented Apr 6, 2018

mvn install with contrib-check runs fine, tests look good.
+1 ( fwiw)

@pvillard31

This comment has been minimized.

Show comment
Hide comment
@pvillard31

pvillard31 Apr 6, 2018

Contributor

+1, merging to master, thanks @MikeThomsen

Contributor

pvillard31 commented Apr 6, 2018

+1, merging to master, thanks @MikeThomsen

@asfgit asfgit closed this in 63d4bba Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment