New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-5108 Updated all explicit refs and media nar usage of commons-co… #2651

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@joewitt
Contributor

joewitt commented Apr 23, 2018

…mpress to latest version and updated spring redis client

Signed-off-by: joewitt joewitt@apache.org

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

NIFI-5108 Updated all explicit refs and media nar usage of commons-co…
…mpress to latest version and updated spring redis client

Signed-off-by: joewitt <joewitt@apache.org>
@alopresto

This comment has been minimized.

Show comment
Hide comment
@alopresto

alopresto Apr 23, 2018

Contributor

Reviewing...

Contributor

alopresto commented Apr 23, 2018

Reviewing...

@asfgit asfgit closed this in ac9944c Apr 24, 2018

@alopresto

This comment has been minimized.

Show comment
Hide comment
@alopresto

alopresto Apr 24, 2018

Contributor

Ran contrib-check and all tests pass. Ran a simple flow using UnpackContent against the MiNiFi source zips and everything unpacked correctly.

+1, merging.

Contributor

alopresto commented Apr 24, 2018

Ran contrib-check and all tests pass. Ran a simple flow using UnpackContent against the MiNiFi source zips and everything unpacked correctly.

+1, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment