New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-5124: Upgrading commons-fileupload #2662

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mcgilman
Contributor

mcgilman commented Apr 26, 2018

NIFI-5124:

  • Upgrading to the latest version of commons-fileupload.
NIFI-5124:
- Upgrading to the latest version of commons-fileupload.
@alopresto

This comment has been minimized.

Show comment
Hide comment
@alopresto

alopresto Apr 26, 2018

Contributor

Reviewing...

Contributor

alopresto commented Apr 26, 2018

Reviewing...

@alopresto

This comment has been minimized.

Show comment
Hide comment
@alopresto

alopresto Apr 26, 2018

Contributor

Ran contrib-check and all tests pass. Verified the file upload functionality still works by importing a template. +1, merging.

Contributor

alopresto commented Apr 26, 2018

Ran contrib-check and all tests pass. Verified the file upload functionality still works by importing a template. +1, merging.

@alopresto

This comment has been minimized.

Show comment
Hide comment
@alopresto

alopresto Apr 26, 2018

Contributor

Mistyped the commit message magic words; @mcgilman can you please close this when you get a chance?

Contributor

alopresto commented Apr 26, 2018

Mistyped the commit message magic words; @mcgilman can you please close this when you get a chance?

@mcgilman

This comment has been minimized.

Show comment
Hide comment
@mcgilman

mcgilman Apr 26, 2018

Contributor

Thanks @alopresto!

Contributor

mcgilman commented Apr 26, 2018

Thanks @alopresto!

@mcgilman mcgilman closed this Apr 26, 2018

@mcgilman

This comment has been minimized.

Show comment
Hide comment
@mcgilman

mcgilman May 2, 2018

Contributor

@alopresto I don't see the commit for this PR in master (unless I'm missing it). Can you please double check that it was pushed? Thanks!

Contributor

mcgilman commented May 2, 2018

@alopresto I don't see the commit for this PR in master (unless I'm missing it). Can you please double check that it was pushed? Thanks!

asfgit pushed a commit that referenced this pull request May 2, 2018

NIFI-5124:
- Upgrading to the latest version of commons-fileupload.

This closes #2662.

Signed-off-by: Andy LoPresto <alopresto@apache.org>
@alopresto

This comment has been minimized.

Show comment
Hide comment
@alopresto

alopresto May 2, 2018

Contributor

I must have pushed it to the wrong remote. I couldn't see it either so I rebased and pushed to apache/master. Should be good now. Thanks.

Contributor

alopresto commented May 2, 2018

I must have pushed it to the wrong remote. I couldn't see it either so I rebased and pushed to apache/master. Should be good now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment