New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-5374 - Suppress stacktrace being returned to remote client when using NiFi REST API #2840

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@thenatog
Contributor

thenatog commented Jul 3, 2018

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

NIFI-5374 - Added ExceptionFilter which catches RequestRejectedExcept…
…ion thrown in the nifi-api Jersey code. These exceptions were not caught by the Jetty error-page configuration because they're thrown before the endpoint/Jetty routing is hit.

NIFI-5374 - Added integration test for checking the ExceptionFilter catches malicious string exceptions.
@alopresto

This comment has been minimized.

Contributor

alopresto commented Jul 3, 2018

Reviewing...

@alopresto

This comment has been minimized.

Contributor

alopresto commented Jul 4, 2018

Thanks @thenatog. I reviewed this and it looks good. While initially I tried to run integration tests for the entire project, there is a failing integration test StandardControllerServiceProviderIT.testConcurrencyWithEnablingReferencingServicesGraph:96->testEnableReferencingServicesGraph which I opened a ticket for NIFI-5375. Building normally and then running integration tests on just this module is successful. I made some minor fixes for code style (see commit 8792f90 on branch NIFI-5374-PR-2840).

I verified against a running instance as well, and will merge this PR.

@asfgit asfgit closed this in b77d668 Jul 4, 2018

asfgit pushed a commit that referenced this pull request Jul 12, 2018

NIFI-5374 - Added ExceptionFilter which catches RequestRejectedExcept…
…ion thrown in the nifi-api Jersey code. These exceptions were not caught by the Jetty error-page configuration because they're thrown before the endpoint/Jetty routing is hit.

Added integration test for checking the ExceptionFilter catches malicious string exceptions.
Made minor changes to PR 2840 for code style.

This closes #2840.

Co-authored-by: Andy LoPresto <alopresto@apache.org>

Signed-off-by: Andy LoPresto <alopresto@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment