Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-6097 - Upgraded the fasterxml jackson version to 2.9.8. Ensure t… #3347

Closed
wants to merge 1 commit into from

Conversation

@thenatog
Copy link
Contributor

thenatog commented Mar 4, 2019

…hat the version is consistent across modules using a maven property defined in the root pom.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

…hat the version is consistent across modules using a maven property defined in the root pom.
@MikeThomsen

This comment has been minimized.

Copy link
Contributor

MikeThomsen commented Mar 4, 2019

Reviewing...

Copy link
Contributor

MikeThomsen left a comment

I think you might have missed some, like it appears that nifi-hadoop-libraries-nar still ships 2.7.8.

@szaboferee

This comment has been minimized.

Copy link
Contributor

szaboferee commented Mar 4, 2019

Why don't you use <dependencyManagement>?

With the following command, mvn dependency:list | grep fasterxml.jackson | sort | uniq it can be seen that jackson still has multiple versions as a transitive dependency. Do we want to keep them as they are?

@thenatog

This comment has been minimized.

Copy link
Contributor Author

thenatog commented Mar 4, 2019

Yes, transitive dependencies have been left as they are. Ideally instead of forcing these transitive versions to 2.9.8, we would upgrade these dependent libraries to new versions which use updated versions of jackson-databind.

@MikeThomsen As such, the hadoop-client:3.0.0 dependency in nifi-hadoop-libraries-nar will still be using jackson-databind:2.7.8. The latest version, hadoop-client:3.2.0, uses jackson-databind:2.9.5.

@MikeThomsen

This comment has been minimized.

Copy link
Contributor

MikeThomsen commented Mar 4, 2019

@thenatog ok. I can live with that. I'll be AFK for a little bit, but I'll merge when I get back (~1hr?) unless you want me to hold off.

@asfgit asfgit closed this in 36bbc77 Mar 5, 2019
@alopresto

This comment has been minimized.

Copy link
Contributor

alopresto commented Mar 5, 2019

There are a number of reasons that <dependencyManagement> is not used heavily throughout NiFi. One reason is that it can cause difficulty with the nested NAR loading and dependency declarations for extensions (see Stack Overflow question). There are also issues during new module addition/upgrade due to <dependencyManagement> as addressed in PR 2764 for NIFI-5260.

rwithers added a commit to rwithers/nifi that referenced this pull request May 3, 2019
…hat the version is consistent across modules using a maven property defined in the root pom.

This closes apache#3347

Signed-off-by: Mike Thomsen <mikerthomsen@gmail.com>
szaboferee pushed a commit to szaboferee/nifi that referenced this pull request Aug 15, 2019
…hat the version is consistent across modules using a maven property defined in the root pom.

This closes apache#3347

Signed-off-by: Mike Thomsen <mikerthomsen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.