NIFI-5346 EncryptPGP, DecryptPGP, SignPGP, and VerifyPGP Processors #4032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EncryptPGP, DecryptPGP, SignPGP, and VerifyPGP Processors and PGPKeyMaterialControllerService
Enables PGP encryption, decryption, digital signing and verification functionality; fixes bug NIFI-5346.
Also addresses or resolves NIFI-5335, NIFI-6708.
The code in this change set introduces 4 new PGP processors and a related PGP key material service.
The processors and service classes are no doubt in the wrong place; help naming them + putting them in better places is very much appreciated.
The change set also includes a processor benchmark and reporting class
, but that isn't wired together at the moment.There are unit tests to cover the basic use cases, and of course there will be more added.
Basic docs are included, more pending feedback.
Benchmarks for
EncryptContent
and the newEncryptPGP
andDecryptPGP
processors:In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
master
)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squash
or use--force
when pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean install
at the rootnifi
folder?LICENSE
file, including the mainLICENSE
file undernifi-assembly
?NOTICE
file, including the mainNOTICE
file found undernifi-assembly
?.displayName
in addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.