Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-7385 Modified token cache structure #4271

Closed
wants to merge 4 commits into from

Conversation

alopresto
Copy link
Contributor

@alopresto alopresto commented May 14, 2020

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Modified the token cache structure.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

thenatog and others added 2 commits May 5, 2020
…on tokens as reverse lookups. This allows us to return the same token that was already issued to a user if it has not been used or expired. This eliminates issues with users being able to generate too many tokens.

NIFI-7385 - Added some comments.

NIFI-7385 - Fixed checkstyle error.
@alopresto alopresto changed the title NIFI-7385 Modified token cache structure. NIFI-7385 Modified token cache structure May 14, 2020
@alopresto
Copy link
Contributor Author

alopresto commented May 14, 2020

I put my changes up on a new branch that includes Nathan's original PR (I can't push to his remote): https://github.com/alopresto/nifi/tree/NIFI-7385-from-ngough. The specific commit is here: alopresto@44ed5de. @thenatog please review these changes and if you're ok, I'll merge them in.

@thenatog
Copy link
Contributor

thenatog commented Jun 2, 2020

Reviewing..

@thenatog
Copy link
Contributor

thenatog commented Jun 2, 2020

Tested and it looks good to me. Github actions is having a test failure for JDK8 - not seeing this on my machine..

…ut no other environment. Increased artificial delay to avoid timing issues.
@alopresto
Copy link
Contributor Author

alopresto commented Jun 9, 2020

Resolved the lone failing test on Windows JDK 1.8. Thanks Nathan. Merging.

@asfgit asfgit closed this in 01e42df Jun 9, 2020
phuthientran pushed a commit to FerrelBurn/nifi that referenced this pull request Jan 8, 2021
Cleaned up code style.
Unit test was failing on Windows 1.8 GitHub Actions build but no other environment. Increased artificial delay to avoid timing issues.

Co-authored-by: Andy LoPresto <alopresto@apache.org>

This closes apache#4271.

Signed-off-by: Andy LoPresto <alopresto@apache.org>
driesva pushed a commit to driesva/nifi that referenced this pull request Mar 19, 2021
Cleaned up code style.
Unit test was failing on Windows 1.8 GitHub Actions build but no other environment. Increased artificial delay to avoid timing issues.

Co-authored-by: Andy LoPresto <alopresto@apache.org>

This closes apache#4271.

Signed-off-by: Andy LoPresto <alopresto@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants