NIFI-8957 NiFi Registry - Possibility to set a description when creating a bucket #5271
Conversation
| } | ||
|
|
||
| // /** |
There was a problem hiding this comment.
Should this section be removed? (Was it left as comment accidentally?)
There was a problem hiding this comment.
That should be removed indeed, thanks for pointing it out. I'll update the PR accordingly.
| @@ -462,6 +468,7 @@ NfRegistryManageBucket.prototype = { | |||
| if (!response.status || response.status === 200) { | |||
| self.nfRegistryService.bucket = response; | |||
| self.bucketname = self.nfRegistryService.bucket.name; | |||
| self.description = self.nfRegistryService.bucket.description; | |||
There was a problem hiding this comment.
There are similar code patters to this one at/about lines 530 and 589. Does "self.description" need to be added in these places as well?
|
Built and installed the nifi-registry with this addition. The UI appeared to perform as expect. The Description field of each bucket is editable. I started from an empty Registry, and have not tested if there are any issues when upgrading from an existing Registry. Connected this registry to a running NiFi. The bucket description information is available when hovering over the "?" next to the bucket name when saving or importing a flow. Functionally, this looks good. Would appreciate someone with more JavaScript experience to do another look-over of the code though. |
…ing a bucket Updated PR according to review comments
|
Thanks @markobean for the review. I have updated the PR according to your suggestions. |
| @@ -407,11 +411,12 @@ NfRegistryManageBucket.prototype = { | |||
| * | |||
| * @param username | |||
| */ | |||
There was a problem hiding this comment.
I know this was already here, but would you update the documentation @param ?
…ing a bucket Updated doc comment for updateBucketNameAndDescription() method
|
Merged, thanks @adenes @markobean @mtien-apache |
…ing a bucket Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#5271.
…ing a bucket Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#5271.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.