New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for NUTCH-2046 contributed by jnioche #161

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Projects
None yet
3 participants
@jnioche
Member

jnioche commented Dec 13, 2016

This makes the seed argument optional and is an alternative to the solution proposed in [https://issues.apache.org/jira/browse/NUTCH-2046]. The latter is also acceptable and has the advantage of not breaking compatibility.

@lewismc

This comment has been minimized.

Show comment
Hide comment
@lewismc

lewismc Apr 7, 2017

Contributor

+1 for me @jnioche
@sebastian-nagel you had made a comment over on NUTCH-2046, are you happy with this approach? I've tested in locally and like it.

Contributor

lewismc commented Apr 7, 2017

+1 for me @jnioche
@sebastian-nagel you had made a comment over on NUTCH-2046, are you happy with this approach? I've tested in locally and like it.

@lewismc lewismc self-requested a review Apr 7, 2017

@lewismc

lewismc approved these changes Apr 7, 2017

+1

@sebastian-nagel

This comment has been minimized.

Show comment
Hide comment
@sebastian-nagel

sebastian-nagel Apr 7, 2017

Contributor

+1 from my side, but we could add a note to CHANGES.txt (as part of a section about API-breaking changes). Users need to update scripts calling bin/crawl.

Contributor

sebastian-nagel commented Apr 7, 2017

+1 from my side, but we could add a note to CHANGES.txt (as part of a section about API-breaking changes). Users need to update scripts calling bin/crawl.

@lewismc

This comment has been minimized.

Show comment
Hide comment
Contributor

lewismc commented Apr 15, 2017

@jnioche jnioche merged commit 6219a16 into apache:master Apr 18, 2017

@jnioche jnioche deleted the jnioche:NUTCH-2046 branch Apr 18, 2017

@jnioche

This comment has been minimized.

Show comment
Hide comment
@jnioche

jnioche Apr 18, 2017

Member

thanks for the reviews and the nudge. Will add a comment on CHANGES in a separate commit.

Member

jnioche commented Apr 18, 2017

thanks for the reviews and the nudge. Will add a comment on CHANGES in a separate commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment