NUTCH-2451 protocol-ftp to resolve relative URL when following redirects #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
September 22, 2017 12:07
…mHandlers without being dependent on externally installed protocol handlers.
It is not a full implementation, take it more as a showcase for the plugin system modifications that allow new protocols to be introduced with a minimum installation effort. The skeleton implementation we have so far allows foo://... urls to be injected into crawldb.
…ich is quite confusing.
…tory. Now any amount of instances can be created, reconfigured or destroyed. The only problem might occur when a URL needs to be opened which of the many PluginRepositories should deliver the protocol.
nutch phases can use protocol plugins as well. May not be the best approach.
Empty content seems to make nutch fail later.
we do not need to implement yet another such mechanism. TODO removed, log messages adapted.
|
Hi @HiranChaudhuri, do you mind adding a descriptive title/description to the PR and squashing your commits? |
sebastian-nagel
changed the title
|
Thanks, @HiranChaudhuri! The commit fixing the URL redirection in protocol-ftp is cherry-picked and integrated into master/1.x and 2.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change suggested in Jira seems to help. I no longer observe MalformedURLExceptions after this modification.