Skip to content

ppp: Fix wrong lcp_state handling on peer reconnection #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2024
Merged

ppp: Fix wrong lcp_state handling on peer reconnection #2571

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19dbc42
ppp: Fix wrong lcp_state handling on peer reconnection
lzungri Sep 13, 2024
7d739bd
ppp: Reformat to match nuttx coding style
lzungri Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion netutils/pppd/lcp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,12 @@ void lcp_rx(struct ppp_context_s *ctx, uint8_t * buffer, uint16_t count)
/* In case of new peer connection */

ipcp_init(ctx);
ctx->lcp_state &= ~LCP_RX_UP;

/* Clear LCP state to keep it in negotiation phase. LCP_TX_UP will be
* re-set once a CONF_ACK is received.
*/

ctx->lcp_state &= ~LCP_TX_UP;

DEBUG1(("received [LCP Config Request id %u\n", id));
if (scan_packet
Expand Down