Remove unused header files across multiple source files #2939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up code by removing redundant and unused header file includes that were identified through static analysis. This improves code readability and reduces unnecessary dependencies. Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
|
[Experimental Bot, please feedback here] Yes, this PR appears to meet the NuttX requirements, though it could be more thorough. While it addresses the summary and testing sections, it omits important details. The Impact section, while claiming "no functional change," needs to explicitly answer all the questions with "NO" or a "YES" + description. The Testing section should specify the build host and target details, not just "GitHub CI." While CI is important, local verification is also expected. Providing "before" logs might be unnecessary for a purely cleanup PR like this, but "after" logs demonstrating successful compilation and perhaps basic functionality would strengthen the submission. |
xiaoxiang781216
approved these changes
Jan 10, 2025
jerpelea
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Clean up code by removing redundant and unused header file includes that were identified through static analysis. This improves code readability and reduces unnecessary dependencies.
Impact
No functional change
Testing
GitHub CI