Fix up_interrupt_context() for SMP #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - I found an issue with up_interrupt_context() when testing. - And finally found that up_interrupt_context() is not atomic. - This commit fixes the issue Impact: - Affects SMP only Testing: - Tested with spresense:wifi_smp and sabre-6quad:smp (qemu) Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
Summary: - Apply the same fix for Arm SMP Impact: - Affects SMP only Testing: - Tested with maix-bit:smp (qemu) Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
Summary: - Apply the same fix for Arm SMP Impact: - Affects SMP only Testing: - Tested with esp32-core:smp (qemu) Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
patacongo
reviewed
Sep 29, 2020
|
LGTM |
patacongo
reviewed
Sep 30, 2020
Add a comment discussing the limitation of this solution for the case of the ARMv7-A with the GIC
|
Thanks for adding the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Testing