[imxrt] Fix FlexCAN tx dropping frames #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetervdPerk-NXP
added a commit
to PetervdPerk-NXP/nuttx
that referenced
this pull request
Feb 26, 2021
…n-zeroed registers
PetervdPerk-NXP
added a commit
to PetervdPerk-NXP/nuttx
that referenced
this pull request
Feb 26, 2021
…n-zeroed registers
PetervdPerk-NXP
added a commit
to PetervdPerk-NXP/nuttx
that referenced
this pull request
Feb 26, 2021
…n-zeroed registers
davids5
pushed a commit
that referenced
this pull request
Feb 26, 2021
jlaitine
pushed a commit
to tiiuae/nuttx
that referenced
this pull request
May 25, 2021
…mings to non-zeroed registers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
i.MXRT FlexCAN driver could drop CAN frames under high load, this was mainly caused due that the ESR2 register wasn't fully updated and we didn't clear IFLAGS correctly. This PR fixes that
Furthermore this fixes a bug in the SocketCAN layer, in the devif_poll_can_connections function that caused that CAN frames might end up into a different interface.
Impact
i.MXRT FlexCAN driver, NuttX SocketCAN layer
This bug might be applicable to the Kinetis and S32K1XX FlexCAN drivers as well, have to debug further on those chips.
Testing
Tested on IMXRT1060-EVK, Teensy (@michallenc ), UCANS32K146-01 (only the devif poll bug)