libs/libc/time: mktime normalize struct tm

[pkarashchenko]

Summary

According to https://pubs.opengroup.org/onlinepubs/9699919799/functions/mktime.html the:

Upon successful completion, the values of the tm_wday and tm_yday components of the structure shall
be set appropriately, and the other components shall be set to represent the specified time since
the Epoch, but with their values forced to the ranges indicated in the
[<time.h>](https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/time.h.html) entry; the final value
of tm_mday shall not be set until tm_mon and tm_year are determined.

Impact

Fix operation of mktime in case if CONFIG_LIBC_LOCALTIME is not selected

Testing

Tested few cases with struct tm normalization, but more testing by others are welcomed

[fjpanag]

@pkarashchenko This commit made our internal tests fail.

Specifically, I am running the Lua v5.2 test suite and it gives me the following message:

/mnt/sdcard0/files.lua:572: assertion failed!

This is the offending line:

local t = os.time()
D = os.date("*t", t)

assert(os.time(D) == t)  -- This line here fails!

I can track this down, and get the actual NuttX issue hidden behind the Lua libraries, but unfortunately due to a national holiday, this will have to wait till Monday.

Unless you can troubleshoot this sooner...

[pkarashchenko]

Ok. Let me take a look tomorrow. If I will not be able to narrow down the issue, then we will revert the change until I find a root cause.
Also maybe you can share the time_t value used during the test?

[pkarashchenko]

@fjpanag I found the root cause. It is fixed in #7455