Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samv7: add support for complementary PWM output #8597

Merged
merged 1 commit into from Feb 21, 2023

Conversation

michallenc
Copy link
Contributor

Summary

SAMv7 PWM driver supports complementary PWM output if both pins (H and L) are defined and configured. This commit adds a configuration option to configure the complementary L pin.

The pin definition has to be provided by board level support.

Impact

SAMv7 PWM driver only.

Testing

Tested on same70-xplained evaluation kit and on a custom board.

@acassis
Copy link
Contributor

acassis commented Feb 20, 2023

@xiaoxiang781216 could you please take a look on this issue (arm-04), seems it was introduced by your commit 54e630e

@xiaoxiang781216
Copy link
Contributor

@xiaoxiang781216 could you please take a look on this issue (arm-04), seems it was introduced by your commit 54e630e

The false error come from the new version of gcc, please look this PR: #8598

arch/arm/src/samv7/sam_pwm.c Outdated Show resolved Hide resolved
arch/arm/src/samv7/sam_pwm.c Outdated Show resolved Hide resolved
arch/arm/src/samv7/sam_pwm.c Outdated Show resolved Hide resolved
Copy link
Contributor

@pkarashchenko pkarashchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how this coexist with channel override. Need to check in the manual if complimentary channels can be overridden separately.

@michallenc
Copy link
Contributor Author

@pkarashchenko From my experience with PWM testing the overwrite as configured now does not affect a complementary pin.

@xiaoxiang781216
Copy link
Contributor

the ci broken is fixed by the last master, please rebase your change.

SAMv7 PWM driver supports complementary PWM output if both pins (H and L)
are defined and configured. This commit adds a configuration option to
configure the complementary L pin.

The pin definition has to be provided by board level support.

Signed-off-by: Michal Lenc <michallenc@seznam.cz>
@xiaoxiang781216
Copy link
Contributor

@pkarashchenko do you have more comment?

@pkarashchenko
Copy link
Contributor

Ok. Let's merge it. I will check the SAMv7 manual when I have time

@xiaoxiang781216
Copy link
Contributor

Let's ignore the ci broken which is fixed by #8611 and merge this simple change.

@xiaoxiang781216 xiaoxiang781216 merged commit db69196 into apache:master Feb 21, 2023
13 of 26 checks passed
@michallenc michallenc deleted the sam_compl_pwm branch March 6, 2023 13:56
@jerpelea jerpelea added this to To-Add in Release Notes - 12.1.0 Apr 3, 2023
@jerpelea jerpelea moved this from To-Add to Added in Release Notes - 12.1.0 Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants