New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samv7: add support for complementary PWM output #8597
Conversation
@xiaoxiang781216 could you please take a look on this issue (arm-04), seems it was introduced by your commit 54e630e |
The false error come from the new version of gcc, please look this PR: #8598 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how this coexist with channel override. Need to check in the manual if complimentary channels can be overridden separately.
211485f
to
de11a88
Compare
@pkarashchenko From my experience with PWM testing the overwrite as configured now does not affect a complementary pin. |
the ci broken is fixed by the last master, please rebase your change. |
SAMv7 PWM driver supports complementary PWM output if both pins (H and L) are defined and configured. This commit adds a configuration option to configure the complementary L pin. The pin definition has to be provided by board level support. Signed-off-by: Michal Lenc <michallenc@seznam.cz>
de11a88
to
3b3e23b
Compare
@pkarashchenko do you have more comment? |
Ok. Let's merge it. I will check the SAMv7 manual when I have time |
Let's ignore the ci broken which is fixed by #8611 and merge this simple change. |
Summary
SAMv7 PWM driver supports complementary PWM output if both pins (H and L) are defined and configured. This commit adds a configuration option to configure the complementary L pin.
The pin definition has to be provided by board level support.
Impact
SAMv7 PWM driver only.
Testing
Tested on same70-xplained evaluation kit and on a custom board.