Skip to content
Permalink
Browse files
Fixed: Fix missing else during previous refactoring
(OFBIZ-11253)
When you rendering for with auto-field-entity on edit mode, indicator field has been override by text field.
Fix also two error on source field type set to FieldInfo.SOURCE_AUTO_SERVICE instead of FieldInfo.SOURCE_AUTO_ENTITY

Thanks to Olivier Heintz to inform on the regression.
  • Loading branch information
nmalin committed Dec 6, 2019
1 parent 87d7465 commit 071a74238b4d53fb95ffd214e0e68e55840a28e3
Showing with 3 additions and 3 deletions.
  1. +3 −3 framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormFieldBuilder.java
@@ -586,10 +586,10 @@ public boolean induceFieldInfoFromEntityField(ModelEntity modelEntity, ModelFiel
this.setFieldInfo(textField);
}
} else if ("display".equals(defaultFieldType)) {
ModelFormField.DisplayField displayField = new ModelFormField.DisplayField(FieldInfo.SOURCE_AUTO_SERVICE, null);
ModelFormField.DisplayField displayField = new ModelFormField.DisplayField(FieldInfo.SOURCE_AUTO_ENTITY, null);
this.setFieldInfo(displayField);
} else if ("hidden".equals(defaultFieldType)) {
ModelFormField.HiddenField hiddenField = new ModelFormField.HiddenField(FieldInfo.SOURCE_AUTO_SERVICE, null);
ModelFormField.HiddenField hiddenField = new ModelFormField.HiddenField(FieldInfo.SOURCE_AUTO_ENTITY, null);
this.setFieldInfo(hiddenField);
} else {
if ("indicator".equals(fieldType)) {
@@ -602,7 +602,7 @@ public boolean induceFieldInfoFromEntityField(ModelEntity modelEntity, ModelFiel
} else if ("very-long".equals(fieldType)) {
ModelFormField.TextareaField textareaField = new ModelFormField.TextareaField(FieldInfo.SOURCE_AUTO_ENTITY, null);
this.setFieldInfo(textareaField);
} if (textFieldTypes.contains(fieldType)) {
} else if (textFieldTypes.contains(fieldType)) {
ModelFormField.TextField textField = new ModelFormField.TextField(FieldInfo.SOURCE_AUTO_ENTITY,
textSizeByFieldTypes.get(fieldType), textMaxSizeByFieldTypes.get(fieldType), null);
this.setFieldInfo(textField);

0 comments on commit 071a742

Please sign in to comment.