Return error when the userLogin service encounters an error during login. It is now more logical to handle unsuccessful logins appropriately and not proceed with 'requirePasswordChange' (OFBIZ-12873)

Author: dixitdeepak

framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java

@@ -602,7 +602,7 @@ public static String login(HttpServletRequest request, HttpServletResponse respo
             Map<String, String> messageMap = UtilMisc.toMap("errorMessage", (String) result.get(ModelService.ERROR_MESSAGE));
             String errMsg = UtilProperties.getMessage(resourceWebapp, "loginevents.following_error_occurred_during_login", messageMap, UtilHttp.getLocale(request));
             request.setAttribute("_ERROR_MESSAGE_", errMsg);
-            return requirePasswordChange ? "requirePasswordChange" : "error";
+            return "error";
         }
     }