Improved: Misc trivial changes done while working on others issues

apache · Nov 11, 2020 · 2fe76be · 2fe76be
1 parent 07cb19c
commit 2fe76be
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 9 deletions.
diff --git a/applications/content/servicedef/services_content.xml b/applications/content/servicedef/services_content.xml
@@ -95,7 +95,7 @@
 
     <service name="createContentFromUploadedFile" engine="group" transaction-timeout="300">
         <description>Accepts file upload, creates DataResource and Content records.</description>
-        <!-- uses createContent internally; additonal permission(s) not necessary -->
+        <!-- uses createContent internally; additional permission(s) not necessary -->
         <group>
             <invoke name="createDataResource" parameters="preserve" result-to-context="true"/>
             <invoke name="attachUploadToDataResource" parameters="preserve" result-to-context="true"/>

diff --git a/...cations/content/src/main/java/org/apache/ofbiz/content/content/UploadContentAndImage.java b/...cations/content/src/main/java/org/apache/ofbiz/content/content/UploadContentAndImage.java
@@ -526,8 +526,6 @@ public static String processContentUpload(Map<String, Object> passedParams, Stri
             List<String> errorMsgList = UtilGenerics.cast(request.getAttribute("_EVENT_MESSAGE_LIST_"));
             if (Debug.infoOn()) {
                 Debug.logInfo("[UploadContentStuff]errorMsgList:" + errorMsgList, MODULE);
-            }
-            if (Debug.infoOn()) {
                 Debug.logInfo("[UploadContentStuff]msg:" + msg, MODULE);
             }
             if (errorMsgList == null) {
@@ -579,8 +577,6 @@ public static String processContentUpload(Map<String, Object> passedParams, Stri
                 List<String> errorMsgList = UtilGenerics.cast(request.getAttribute("_EVENT_MESSAGE_LIST_"));
                 if (Debug.infoOn()) {
                     Debug.logInfo("[UploadContentStuff]errorMsgList:" + errorMsgList, MODULE);
-                }
-                if (Debug.infoOn()) {
                     Debug.logInfo("[UploadContentStuff]msg:" + msg, MODULE);
                 }
                 if (errorMsgList == null) {

diff --git a/applications/product/config/ImageProperties.xml b/applications/product/config/ImageProperties.xml
@@ -18,9 +18,9 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-<!-- 
-    # The uploaded image is scaled in each size tye , you can descrease or increase size types ; size type name doesn't have to contain space
-    # Just one configured dimension on two is allowed to restrict just one image dimension, whatever its proportions 
+<!--
+    # The uploaded image is scaled in each size type , you can decrease or increase size types ; size type name doesn't have to contain space
+    # Just one configured dimension on two is allowed to restrict just one image dimension, whatever its proportions
 -->
 <imageSize xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
     <size name="small">

diff --git a/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java b/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
@@ -901,7 +901,7 @@ public static TimeZone getTimeZone(HttpServletRequest request, HttpSession sessi
     /**
      * Return the VisualTheme object from the user session
      * @param request
-     * @return
+     * @return VisualTheme
      */
     public static VisualTheme getVisualTheme(HttpServletRequest request) {
         return (VisualTheme) request.getSession().getAttribute(SESSION_KEY_THEME);