Improved: Remove unnecessary declared exceptions for ‘ContainerExcept…

…ion’ (OFBIZ-10938) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1857913 13f79535-47bb-0310-9956-ffa450edef68
apache · Apr 21, 2019 · 5982be81612cd2b53693c405f4e24cf0c95c3d6d · 5982be8
1 parent 3b67829
commit 5982be81612cd2b53693c405f4e24cf0c95c3d6d
diff --git a/framework/base/src/main/java/org/apache/ofbiz/base/container/ComponentContainer.java b/framework/base/src/main/java/org/apache/ofbiz/base/container/ComponentContainer.java
@@ -83,7 +83,7 @@ public void init(List<StartupCommand> ofbizCommands, String name, String configF
     /**
      * @see org.apache.ofbiz.base.container.Container#start()
      */
-    public boolean start() throws ContainerException {
+    public boolean start() {
         return loaded.get();
     }
 
@@ -92,9 +92,8 @@ public boolean start() throws ContainerException {
      * and set the classloader as the context classloader
      *
      * @param componentsClassPath a list of classpaths for all components
-     * @throws ContainerException
      */
-    private void loadClassPathForAllComponents(List<Classpath> componentsClassPath) throws ContainerException {
+    private void loadClassPathForAllComponents(List<Classpath> componentsClassPath) {
         List<URL> allComponentUrls = new ArrayList<>();
         for(Classpath classPath : componentsClassPath) {
             try {
@@ -365,7 +364,7 @@ private Classpath buildClasspathFromComponentConfig(ComponentConfig config) thro
     /**
      * @see org.apache.ofbiz.base.container.Container#stop()
      */
-    public void stop() throws ContainerException {
+    public void stop() {
     }
 
     public String getName() {

diff --git a/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CatalinaContainer.java b/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CatalinaContainer.java
@@ -147,7 +147,7 @@ public boolean start() throws ContainerException {
         return true;
     }
 
-    public void stop() throws ContainerException {
+    public void stop() {
         try {
             tomcat.stop();
         } catch (LifecycleException e) {

diff --git a/framework/entity/src/main/java/org/apache/ofbiz/entity/DelegatorContainer.java b/framework/entity/src/main/java/org/apache/ofbiz/entity/DelegatorContainer.java
@@ -45,7 +45,7 @@ public void init(List<StartupCommand> ofbizCommands, String name, String configF
     }
 
     @Override
-    public boolean start() throws ContainerException {
+    public boolean start() {
         if (UtilValidate.isEmpty(preloadedDelegatorNames)) {
             return true;
         }
@@ -58,7 +58,7 @@ public boolean start() throws ContainerException {
     }
 
     @Override
-    public void stop() throws ContainerException {
+    public void stop() {
     }
 
     @Override

diff --git a/...work/entityext/src/main/java/org/apache/ofbiz/entityext/data/EntityDataLoadContainer.java b/...work/entityext/src/main/java/org/apache/ofbiz/entityext/data/EntityDataLoadContainer.java
@@ -118,12 +118,12 @@ public void init(List<StartupCommand> ofbizCommands, String name, String configF
     }
 
     @Override
-    public boolean start() throws ContainerException {
+    public boolean start() {
         return true;
     }
 
     @Override
-    public void stop() throws ContainerException {
+    public void stop() {
     }
 
     @Override

diff --git a/framework/service/src/main/java/org/apache/ofbiz/service/ServiceContainer.java b/framework/service/src/main/java/org/apache/ofbiz/service/ServiceContainer.java
@@ -61,12 +61,12 @@ public void init(List<StartupCommand> ofbizCommands, String name, String configF
     }
 
     @Override
-    public boolean start() throws ContainerException {
+    public boolean start() {
         return true;
     }
 
     @Override
-    public void stop() throws ContainerException {
+    public void stop() {
         JobManager.shutDown();
         Set<String> dispatcherNames = getAllDispatcherNames();
         for (String dispatcherName: dispatcherNames) {

diff --git a/framework/service/src/main/java/org/apache/ofbiz/service/mail/JavaMailContainer.java b/framework/service/src/main/java/org/apache/ofbiz/service/mail/JavaMailContainer.java
@@ -75,7 +75,7 @@
     private String name;
 
     @Override
-    public void init(List<StartupCommand> ofbizCommands, String name, String configFile) throws ContainerException {
+    public void init(List<StartupCommand> ofbizCommands, String name, String configFile) {
         this.name = name;
         this.configFile = configFile;
         this.stores = new LinkedHashMap<>();
@@ -126,7 +126,7 @@ public boolean start() throws ContainerException {
     }
 
     @Override
-    public void stop() throws ContainerException {
+    public void stop() {
         // stop the poller
         this.pollTimer.shutdown();
         Debug.logWarning("stop JavaMail poller", module);

diff --git a/framework/service/src/main/java/org/apache/ofbiz/service/rmi/RmiServiceContainer.java b/framework/service/src/main/java/org/apache/ofbiz/service/rmi/RmiServiceContainer.java
@@ -174,7 +174,8 @@ public boolean start() throws ContainerException {
         return true;
     }
 
-    public void stop() throws ContainerException {
+    @Override
+    public void stop() {
         remote.deregister();
     }
 

diff --git a/framework/testtools/src/main/java/org/apache/ofbiz/testtools/TestRunContainer.java b/framework/testtools/src/main/java/org/apache/ofbiz/testtools/TestRunContainer.java
@@ -102,7 +102,7 @@ public boolean start() throws ContainerException {
         return true;
     }
 
-    public void stop() throws ContainerException {
+    public void stop() {
     }
 
     public String getName() {