Skip to content

Commit

Permalink
Improved: Remove unnecessary declared exceptions for ‘ContainerExcept…
Browse files Browse the repository at this point in the history
…ion’

(OFBIZ-10938)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1857913 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
mthl committed Apr 21, 2019
1 parent 3b67829 commit 5982be8
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public void init(List<StartupCommand> ofbizCommands, String name, String configF
/**
* @see org.apache.ofbiz.base.container.Container#start()
*/
public boolean start() throws ContainerException {
public boolean start() {
return loaded.get();
}

Expand All @@ -92,9 +92,8 @@ public boolean start() throws ContainerException {
* and set the classloader as the context classloader
*
* @param componentsClassPath a list of classpaths for all components
* @throws ContainerException
*/
private void loadClassPathForAllComponents(List<Classpath> componentsClassPath) throws ContainerException {
private void loadClassPathForAllComponents(List<Classpath> componentsClassPath) {
List<URL> allComponentUrls = new ArrayList<>();
for(Classpath classPath : componentsClassPath) {
try {
Expand Down Expand Up @@ -365,7 +364,7 @@ private Classpath buildClasspathFromComponentConfig(ComponentConfig config) thro
/**
* @see org.apache.ofbiz.base.container.Container#stop()
*/
public void stop() throws ContainerException {
public void stop() {
}

public String getName() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public boolean start() throws ContainerException {
return true;
}

public void stop() throws ContainerException {
public void stop() {
try {
tomcat.stop();
} catch (LifecycleException e) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public void init(List<StartupCommand> ofbizCommands, String name, String configF
}

@Override
public boolean start() throws ContainerException {
public boolean start() {
if (UtilValidate.isEmpty(preloadedDelegatorNames)) {
return true;
}
Expand All @@ -58,7 +58,7 @@ public boolean start() throws ContainerException {
}

@Override
public void stop() throws ContainerException {
public void stop() {
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,12 @@ public void init(List<StartupCommand> ofbizCommands, String name, String configF
}

@Override
public boolean start() throws ContainerException {
public boolean start() {
return true;
}

@Override
public void stop() throws ContainerException {
public void stop() {
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ public void init(List<StartupCommand> ofbizCommands, String name, String configF
}

@Override
public boolean start() throws ContainerException {
public boolean start() {
return true;
}

@Override
public void stop() throws ContainerException {
public void stop() {
JobManager.shutDown();
Set<String> dispatcherNames = getAllDispatcherNames();
for (String dispatcherName: dispatcherNames) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public class JavaMailContainer implements Container {
private String name;

@Override
public void init(List<StartupCommand> ofbizCommands, String name, String configFile) throws ContainerException {
public void init(List<StartupCommand> ofbizCommands, String name, String configFile) {
this.name = name;
this.configFile = configFile;
this.stores = new LinkedHashMap<>();
Expand Down Expand Up @@ -126,7 +126,7 @@ public boolean start() throws ContainerException {
}

@Override
public void stop() throws ContainerException {
public void stop() {
// stop the poller
this.pollTimer.shutdown();
Debug.logWarning("stop JavaMail poller", module);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ public boolean start() throws ContainerException {
return true;
}

public void stop() throws ContainerException {
@Override
public void stop() {
remote.deregister();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public boolean start() throws ContainerException {
return true;
}

public void stop() throws ContainerException {
public void stop() {
}

public String getName() {
Expand Down

0 comments on commit 5982be8

Please sign in to comment.