Skip to content

/ofbiz-framework

Permalink
Browse files

Reverted: Refactor EntityDataLoadContainer 

(OFBIZ-11070)

There is something wrong with Mathieu's changes, reverting all for now


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1860113 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
@JacquesLeRoux
JacquesLeRoux committed May 27, 2019
1 parent 5ec0248 commit 87fc949af857afd6c90eae1bccbd296ce22b16b5
92 ...work/entityext/src/main/java/org/apache/ofbiz/entityext/data/EntityDataLoadContainer.java
View file
@@ -131,7 +131,7 @@ public String getName() {
return name;
}

private static List<GenericValue> getTenantList(Property delegatorNameProp) throws ContainerException {
private List<GenericValue> getTenantList(Property delegatorNameProp) throws ContainerException {
if (!EntityUtil.isMultiTenantEnabled()) {
throw new ContainerException("Multitenant is disabled, must be enabled in general.properties -> multitenant=Y");
}
@@ -148,7 +148,7 @@ public String getName() {
}
}

private static void loadDataForDelegator(Map<String, String> loadDataProps, Configuration configuration,
private void loadDataForDelegator(Map<String, String> loadDataProps, Configuration configuration,
Property delegatorNameProp, String overrideDelegator) throws ContainerException{

// prepare command line properties passed by user
@@ -191,24 +191,29 @@ private static void loadDataForDelegator(Map<String, String> loadDataProps, Conf
}
}

/**
* Checks if a key is associated with either the string {@code "true"} or {@code null}.
/*
* If the user passed a flag, then make sure to set it to true if it has no
* value or its value is the string "true".
*
* @param props the map associating keys to values
* @param key the key to look for in {@code props}
* @return {@code true} if {@code key} is associated with {@code "true"} or {@code null} in {@code props}.
* key=true -> true
* key -> true
* key=false -> false
* (no-key) -> false
*/
private static boolean isPropertySet(Map<String, String> props, String key) {
private boolean isPropertySet(Map<String, String> props, String key) {
String value = props.get(key);
return props.containsKey(key) && (value == null || "true".equalsIgnoreCase(value));
if (props.containsKey(key) && (value == null || "true".equalsIgnoreCase(value))) {
return true;
} else {
return false;
}
}

/*
* Gets the default entity-group-name defined in the container definition
* unless overridden by the user
*/
private static String getEntityGroupNameFromConfig(Configuration cfg, String overrideGroup)
throws ContainerException {
private String getEntityGroupNameFromConfig(Configuration cfg, String overrideGroup) throws ContainerException {
if (overrideGroup != null) {
return overrideGroup;
} else {
@@ -226,16 +231,15 @@ private static String getEntityGroupNameFromConfig(Configuration cfg, String ove
* overridden by the user. This method will create all the tables, keys and
* indices if missing and hence might take a long time.
*/
private static Delegator getDelegator(Property delegatorNameProp, String overrideDelegator)
throws ContainerException {
private Delegator getDelegator(Property delegatorNameProp, String overrideDelegator) throws ContainerException {
if (overrideDelegator != null) {
return DelegatorFactory.getDelegator(overrideDelegator);
} else {
return getDelegatorFromProp(delegatorNameProp);
}
}

private static Delegator getDelegatorFromProp(Property delegatorNameProp) throws ContainerException {
private Delegator getDelegatorFromProp(Property delegatorNameProp) throws ContainerException {
if (delegatorNameProp != null && UtilValidate.isNotEmpty(delegatorNameProp.value)) {
Delegator delegator = DelegatorFactory.getDelegator(delegatorNameProp.value);
if (delegator != null) {
@@ -248,32 +252,32 @@ private static Delegator getDelegatorFromProp(Property delegatorNameProp) throws
}
}

private static Delegator getBaseDelegator(Delegator delegator) {
private Delegator getBaseDelegator(Delegator delegator) {
if (delegator.getDelegatorTenantId() != null) {
return DelegatorFactory.getDelegator(delegator.getDelegatorBaseName());
} else {
return delegator;
}
}

private static GenericHelperInfo getHelperInfo(Delegator delegator, String entityGroup) throws ContainerException {
private GenericHelperInfo getHelperInfo(Delegator delegator, String entityGroup) throws ContainerException {
GenericHelperInfo helperInfo = delegator.getGroupHelperInfo(entityGroup);
if (helperInfo == null) {
throw new ContainerException("Unable to locate the datasource helper for the group: " + entityGroup);
}
return helperInfo;
}

private static Map<String, ModelEntity> getModelEntities(Delegator delegator, String entityGroup)
throws ContainerException {
private Map<String, ModelEntity> getModelEntities(Delegator delegator,
String entityGroup) throws ContainerException {
try {
return delegator.getModelEntityMapByGroup(entityGroup);
} catch (GenericEntityException e) {
throw new ContainerException(e);
}
}

private static void createOrUpdateComponentEntities(Delegator baseDelegator,
private void createOrUpdateComponentEntities(Delegator baseDelegator,
Collection<ComponentConfig> allComponents) {

for (ComponentConfig config : allComponents) {
@@ -296,7 +300,7 @@ private static void createOrUpdateComponentEntities(Delegator baseDelegator,
}
}

private static void dropDbConstraints(DatabaseUtil dbUtil, Map<String, ModelEntity> modelEntities,
private void dropDbConstraints(DatabaseUtil dbUtil, Map<String, ModelEntity> modelEntities,
TreeSet<String> modelEntityNames) {

List<String> messages = new ArrayList<>();
@@ -328,7 +332,7 @@ private static void dropDbConstraints(DatabaseUtil dbUtil, Map<String, ModelEnti
logMessageList(messages);
}

private static void createDbConstraints(DatabaseUtil dbUtil, Map<String, ModelEntity> modelEntities,
private void createDbConstraints(DatabaseUtil dbUtil, Map<String, ModelEntity> modelEntities,
TreeSet<String> modelEntityNames) {

List<String> messages = new ArrayList<>();
@@ -360,7 +364,7 @@ private static void createDbConstraints(DatabaseUtil dbUtil, Map<String, ModelEn
logMessageList(messages);
}

private static void dropPrimaryKeys(DatabaseUtil dbUtil, Map<String, ModelEntity> modelEntities,
private void dropPrimaryKeys(DatabaseUtil dbUtil, Map<String, ModelEntity> modelEntities,
TreeSet<String> modelEntityNames) {

List<String> messages = new ArrayList<>();
@@ -376,7 +380,7 @@ private static void dropPrimaryKeys(DatabaseUtil dbUtil, Map<String, ModelEntity
logMessageList(messages);
}

private static void createPrimaryKeys(DatabaseUtil dbUtil, Map<String, ModelEntity> modelEntities,
private void createPrimaryKeys(DatabaseUtil dbUtil, Map<String, ModelEntity> modelEntities,
TreeSet<String> modelEntityNames) {

List<String> messages = new ArrayList<>();
@@ -392,7 +396,7 @@ private static void createPrimaryKeys(DatabaseUtil dbUtil, Map<String, ModelEnti
logMessageList(messages);
}

private static void repairDbColumns(DatabaseUtil dbUtil, Map<String, ModelEntity> modelEntities) {
private void repairDbColumns(DatabaseUtil dbUtil, Map<String, ModelEntity> modelEntities) {
List<String> fieldsToRepair = new ArrayList<>();
List<String> messages = new ArrayList<>();
dbUtil.checkDb(modelEntities, fieldsToRepair, messages, false, false, false, false);
@@ -403,14 +407,15 @@ private static void repairDbColumns(DatabaseUtil dbUtil, Map<String, ModelEntity
logMessageList(messages);
}

private static void logMessageList(List<String> messages) {
private void logMessageList(List<String> messages) {
if (Debug.infoOn()) {
messages.forEach(message -> Debug.logInfo(message, module));
}
}

private static void loadData(Delegator delegator, Delegator baseDelegator,
Collection<ComponentConfig> allComponents, GenericHelperInfo helperInfo,
private void loadData(Delegator delegator, Delegator baseDelegator,
Collection<ComponentConfig> allComponents,
GenericHelperInfo helperInfo,
Map<String, String> loadDataProps) throws ContainerException {

// prepare command line properties passed by user
@@ -445,22 +450,22 @@ private static void loadData(Delegator delegator, Delegator baseDelegator,
logDataLoadingResults(infoMessages, errorMessages, totalRowsChanged);
}

private static int getTransactionTimeout(String timeout) {
private int getTransactionTimeout(String timeout) {
try {
return Integer.parseInt(timeout);
} catch (Exception e) {
return -1;
}
}

private static List<URL> prepareDataUrls(Delegator delegator, Delegator baseDelegator,
private List<URL> prepareDataUrls(Delegator delegator, Delegator baseDelegator,
Collection<ComponentConfig> allComponents, GenericHelperInfo helperInfo,
Map<String, String> loadDataProps) throws ContainerException {

List<URL> urlList = new ArrayList<>();

// prepare command line properties passed by user
List<String> files = Arrays.asList(loadDataProps.getOrDefault(DATA_FILE, "").split(","));
List<String> files = getLoadFiles(loadDataProps.get(DATA_FILE));
String directory = loadDataProps.get(DATA_DIR);
String component = loadDataProps.get(DATA_COMPONENT);
String readers = loadDataProps.get(DATA_READERS);
@@ -494,13 +499,24 @@ private static int getTransactionTimeout(String timeout) {
return urlList;
}

private static boolean isDataReadersEnabled(List<String> files, String directory, String readers) {
private List<String> getLoadFiles(String fileProp) {
List<String> fileList = new ArrayList<>();
Optional.ofNullable(fileProp)
.ifPresent(props -> fileList.addAll(StringUtil.split(props, ",")));
return fileList;
}

private boolean isDataReadersEnabled(List<String> files, String directory, String readers) {
/* if files or directories are passed by the user and no readers are
* passed then set readers to "none" */
return readers != null || (files.isEmpty() && directory == null);
if (readers == null && (!files.isEmpty() || directory != null)) {
return false;
} else {
return true;
}
}

private static List<String> prepareTenantLoadComponents(Delegator delegator, Delegator baseDelegator,
private List<String> prepareTenantLoadComponents(Delegator delegator, Delegator baseDelegator,
Collection<ComponentConfig> allComponents, String component) {

List<String> loadComponents = new ArrayList<>();
@@ -530,7 +546,7 @@ private static boolean isDataReadersEnabled(List<String> files, String directory
return loadComponents;
}

private static List<URL> retireveDataUrlsFromFileList(List<String> files) throws ContainerException {
private List<URL> retireveDataUrlsFromFileList(List<String> files) throws ContainerException {
List<URL> fileUrls = new ArrayList<>();
for(String file: files) {
URL url = UtilURL.fromResource(file);
@@ -543,7 +559,7 @@ private static boolean isDataReadersEnabled(List<String> files, String directory
return fileUrls;
}

private static List<URL> retrieveDataUrlsFromDirectory(String directory) {
private List<URL> retrieveDataUrlsFromDirectory(String directory) {
return Optional.ofNullable(directory)
.map(dir -> Arrays.asList(new File(dir).listFiles()).stream()
.filter(file -> file.getName().toLowerCase(Locale.getDefault()).endsWith(".xml"))
@@ -552,7 +568,7 @@ private static boolean isDataReadersEnabled(List<String> files, String directory
.orElse(new ArrayList<URL>());
}

private static void logDataLoadingPlan(List<URL> urlList, String delegatorName) {
private void logDataLoadingPlan(List<URL> urlList, String delegatorName) {
if (UtilValidate.isNotEmpty(urlList)) {
Debug.logImportant("=-=-=-=-=-=-= Doing a data load using delegator '"
+ delegatorName + "' with the following files:", module);
@@ -563,7 +579,7 @@ private static void logDataLoadingPlan(List<URL> urlList, String delegatorName)
}
}

private static String createDataLoadMessage(URL dataUrl, int rowsChanged, int totalRowsChanged) {
private String createDataLoadMessage(URL dataUrl, int rowsChanged, int totalRowsChanged) {
NumberFormat formatter = NumberFormat.getIntegerInstance();
formatter.setMinimumIntegerDigits(5);
formatter.setGroupingUsed(false);
@@ -572,7 +588,7 @@ private static String createDataLoadMessage(URL dataUrl, int rowsChanged, int to
+ " from " + dataUrl.toExternalForm();
}

private static void logDataLoadingResults(List<String> infoMessages,
private void logDataLoadingResults(List<String> infoMessages,
List<Object> errorMessages, int totalRowsChanged) {

if (UtilValidate.isNotEmpty(infoMessages)) {

0 comments on commit 87fc949

Please sign in to comment.
You can’t perform that action at this time.