Improved: Add missing ‘synchronized’ modifier

mthl · mthl · commit 9a8b403bb33a · 2019-05-01T14:36:26.000Z
(OFBIZ-11004) Overriding a synchronized method with a non-synchronized one can introduce potential runtime concurrency bugs. Since ‘ExtendedProperties#loadFromXML’ is overridding ‘Properties#loadFromXML’ which is synchronized, it is safer to mark it as synchonized. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858490 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilProperties.java b/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilProperties.java
@@ -1188,7 +1188,7 @@ public ExtendedProperties(URL url, Locale locale) throws IOException, InvalidPro
             }
         }
         @Override
-        public void loadFromXML(InputStream in) throws IOException, InvalidPropertiesFormatException {
+        public synchronized void loadFromXML(InputStream in) throws IOException, InvalidPropertiesFormatException {
             try {
                 xmlToProperties(in, null, this);
             } finally {

Original file line number	Diff line number	Diff line change
`@@ -1188,7 +1188,7 @@ public ExtendedProperties(URL url, Locale locale) throws IOException, InvalidPro`
`1188`	`1188`	`}`
`1189`	`1189`	`}`
`1190`	`1190`	`@Override`
`1191`		`- public void loadFromXML(InputStream in) throws IOException, InvalidPropertiesFormatException {`
	`1191`	`+ public synchronized void loadFromXML(InputStream in) throws IOException, InvalidPropertiesFormatException {`
`1192`	`1192`	`try {`
`1193`	`1193`	`xmlToProperties(in, null, this);`
`1194`	`1194`	`} finally {`