Improved: fixes a Java doc issue reported by checkstyle

Also removes unused ModelEntity::toXmlElement and ModelEntity::toGroupXmlElement tasks.checkstyleMain.maxErrors from 278 to 277
apache · Feb 5, 2021 · a234f8e · a234f8e
1 parent af9ed4e
commit a234f8e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/build.gradle b/build.gradle
@@ -310,7 +310,7 @@ checkstyle {
     // the sum of errors found last time it was changed after using the
     // ‘checkstyle’ tool present in the framework and in the official
     // plugins.
-    tasks.checkstyleMain.maxErrors = 278
+    tasks.checkstyleMain.maxErrors = 277
     // Currently there are a lot of errors so we need to temporarily
     // hide them to avoid polluting the terminal output.
     showViolations = false

diff --git a/framework/entity/src/main/java/org/apache/ofbiz/entity/model/ModelEntity.java b/framework/entity/src/main/java/org/apache/ofbiz/entity/model/ModelEntity.java
@@ -2165,18 +2165,11 @@ public Element toXmlElement(Document document, String packageName) {
     }
 
     /**
-     * To xml element element.
+     * To Group elements of a document in a package
      * @param document the document
+     * @param packageName the name of the package where to group the elements of the document
      * @return the element
      */
-    public Element toXmlElement(Document document) {
-        return this.toXmlElement(document, this.getPackageName());
-    }
-
-    public Element toGroupXmlElement(Document document) {
-        return this.toGroupXmlElement(document, this.getPackageName());
-    }
-
     public Element toGroupXmlElement(Document document, String packageName) {
         if (UtilValidate.isNotEmpty(this.getPackageName()) && !packageName.equals(this.getPackageName())) {
             Debug.logWarning(