Skip to content
Browse files
Improved: Remove useless ‘StringUtil#join’ overload

‘List’ extends ‘Collection’ so there is no need to overload
‘StringUtil#join(Collection,String)’ with ‘StringUtil#join(List,String)’.

git-svn-id: 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
mthl committed May 25, 2019
1 parent 90e70dd commit ab2fcbcb4a9d3ba819c9fc7396c9efba3727cf7c
Showing with 0 additions and 10 deletions.
  1. +0 −10 framework/base/src/main/java/org/apache/ofbiz/base/util/
@@ -99,16 +99,6 @@ public static String replaceString(String mainString, String oldString, String n
return mainSb.toString();

* Creates a single string from a List of strings seperated by a delimiter.
* @param list a list of strings to join
* @param delim the delimiter character(s) to use. (null value will join with no delimiter)
* @return a String of all values in the list seperated by the delimiter
public static String join(List<?> list, String delim) {
return join ((Collection<?>) list, delim);

* Creates a single string from a Collection of strings seperated by a delimiter.
* @param col a collection of strings to join

0 comments on commit ab2fcbc

Please sign in to comment.