Skip to content

Commit

Permalink
Improved: Define specific ‘maxErrors’ for main/test source sets.
Browse files Browse the repository at this point in the history
(OFBIZ-11262)

Previously a common maximum “checkstyle” error count was provided for
the main/test source sets.  This means that there was no effective
detection of newly introduced coding style errors in tests.  We are
now defining separate error counts to avoid new tests to introduce
such errors.

Thanks: Gil Portenseigne for identifying this limitation.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869010 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
mthl committed Oct 26, 2019
1 parent 43c098c commit af2c4b4
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,8 @@ checkstyle {
// the sum of errors that were present before introducing the
// ‘checkstyle’ tool present in the framework and in the official
// plugins.
maxErrors = 37864
tasks.checkstyleMain.maxErrors = 37858
tasks.checkstyleTest.maxErrors = 176
// Currently there are a lot of errors so we need to temporarily
// hide them to avoid polluting the terminal output.
showViolations = false
Expand Down

0 comments on commit af2c4b4

Please sign in to comment.