Skip to content
Permalink
Browse files

Improved: ‘EntityOperator#getId()’ is not used in the framework

(OFBIZ-10607)

Thanks Mathieu Lirzin for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1850958 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
mbrohl committed Jan 10, 2019
1 parent 8f448f6 commit bcd2a6c5d76ffe6045d2ab9f5bb3d4931ea74c67
@@ -28,7 +28,6 @@
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.concurrent.atomic.AtomicInteger;

import org.apache.ofbiz.base.util.UtilGenerics;
import org.apache.ofbiz.entity.Delegator;
@@ -60,7 +59,6 @@
public static final int ID_NOT_IN = 13;
public static final int ID_NOT_LIKE = 14;

private static final AtomicInteger dynamicId = new AtomicInteger();
private static HashMap<String, EntityOperator<?,?,?>> registry = new HashMap<>();

private static <L,R,T> void registerCase(String name, EntityOperator<L,R,T> operator) {
@@ -94,10 +92,6 @@ public static EntityJoinOperator lookupJoin(String name) {
return UtilGenerics.cast(operator);
}

public static int requestId() {
return dynamicId.get();
}

public static final EntityComparisonOperator<?,?> EQUALS = new ComparableEntityComparisonOperator<Object>(ID_EQUALS, "=") {
@Override
public boolean compare(Comparable<Object> lhs, Object rhs) { return EntityComparisonOperator.compareEqual(lhs, rhs); }

0 comments on commit bcd2a6c

Please sign in to comment.
You can’t perform that action at this time.