Improved: Use try with resources in ‘readXmlDocument’

(OFBIZ-8202) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1862320 13f79535-47bb-0310-9956-ffa450edef68
apache · Jun 29, 2019 · c5ea5d8 · c5ea5d8
1 parent 4d7e598
commit c5ea5d8
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilXml.java b/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilXml.java
@@ -387,10 +387,9 @@ public static Document readXmlDocument(URL url, boolean validate)
             Debug.logWarning("[UtilXml.readXmlDocument] URL was null, doing nothing", module);
             return null;
         }
-        InputStream is = url.openStream();
+        try (InputStream is = url.openStream()) {
-        Document document = readXmlDocument(is, validate, url.toString());
+            return readXmlDocument(is, validate, url.toString());
-        is.close();
+        }
-        return document;
     }
 
     public static Document readXmlDocument(URL url, boolean validate, boolean withPosition)