Skip to content
Branch: trunk
Commits on Jan 3, 2020
  1. Improved: Remove unused ‘ComponentContainer#retrieveComponentConfig’ …

    mthl committed Jan 3, 2020
    No functional change.
  2. Improved: Use ‘forEach’ in ‘RequestHandler’ for conciseness

    mthl committed Jan 2, 2020
    No functional changes.
Commits on Dec 30, 2019
  1. Improved: Remove ‘RequestHandler#ControllerConfig’ wrapper

    mthl committed Dec 29, 2019
    ‘RequestHandler#ControllerConfig’ was a wrapper around
    ‘ConfigXMLReader#ControllerConfig’ used as a convenience to gather
    error handling when accessing configuration properties. Since the
    later is now only throwing exceptions when instantiating the object,
    ‘RequestHandler#ControllerConfig’ is not useful anymore.
  2. Improved: Retrieve the included controller files eagerly

    mthl committed Dec 29, 2019
    The included controller files resolution was previously delayed when
    accessing the configuration properties. The issue is that it imposes
    callers to handle exceptions when accessing those
    properties. Additionally this has the drawback of detecting inclusion
    issues late.
    We are now retrieving the included files when instantiating the
    controller configuration object. This provides more guarantee on the
    integrity of instantiated controllers and relax the error handling
    requirements on configuration properties callers.
Commits on Dec 18, 2019
  1. Reverted: "Improved: Use ‘depends-on’ attribute instead of “component…

    mthl committed Dec 18, 2019
    This reverts commit eeabe69.
Commits on Dec 7, 2019
  1. Improved: Inline ‘StartupControlPanel#createLogDirectoryIfMissing’.

    mthl committed Dec 7, 2019
    Use a lambda instead of an anonymous class to implement a thread.
  2. Improved: Replace getLocation with location in ‘ComponentConfig.Webap…

    mthl committed Dec 7, 2019
    Use Path instead of String + File.
  3. Improved: Lint ‘FreeMarkerWorker’ class

    mthl committed Dec 7, 2019
  4. Improved: Do not add classpath info to the classloader classpath (OFB…

    mthl committed Nov 8, 2019
    Those directories are already added in the classpath by the build
    system. The classpath info defined in “ofbiz-component.xml” files are
    now only used to retrieve label files.
  5. Fixed: Display file name in XML parsing errors

    mthl committed Dec 7, 2019
Commits on Dec 1, 2019
  1. Improved: Move ‘ComponentContainerTest’ data to src/test/resources/ (…

    mthl committed Dec 1, 2019
    Remove unnecessary webapp declaration inside the test component
  2. Fixed: Remove obsolete references to WorkflowActivity (OFBIZ-11303)

    mthl committed Dec 1, 2019
    The workflow component is in attic since 7 years.
  3. Improved: Remove unnecessary ‘ofbizDebug’ task type (OFBIZ-11302)

    mthl committed Nov 30, 2019
    the standard ‘--debug-jvm’ Gradle option already provides the same
Commits on Nov 29, 2019
Commits on Nov 27, 2019
  1. Improved: Remove unnecessary explicit Tomcat dependencies (OFBIZ-11300)

    mthl committed Nov 27, 2019
    Tomcat already provides the Servlet and JSP Java EE related interfaces
    so there is no need to explicitly add the ‘javax...’ dependencies.
    Additionally ‘tomcat-catalina-ha’ depends on ‘tomcat-catalina’ and
    ‘tomcat-tribes’ so we can make those dependencies implicit.
    ‘axis2-kernel’ is now placed after ‘tomcat-qa’ in the dependencies
    block to ensure that we use the Servlet interfaces provided by Tomcat.
  2. Improved: Reference the Servlet javadoc from Apache Tomcat (OFBIZ-11300)

    mthl committed Nov 27, 2019
    Since we are using the servlet API implemented by Apache Tomcat, it is
    better to use its documentation than the one from oracle which is not
    updated anymore because of Java EE community adoption.
Commits on Nov 25, 2019
  1. Improved: Do not exclude files from component ‘config’ directories (O…

    mthl committed Nov 8, 2019
    With the goal of distributing OFBiz as a library in a Jar, we must
    include every configuration resource files in the Jar.
  2. Improved: Use ‘depends-on’ attribute instead of “component-load.xml” …

    mthl committed Nov 25, 2019
    We currently have two ways to define component loading order. Either
    by using ‘depends-on’ attribute in “component-config.xml” or by adding
    a “component-load.xml” file at the root of a component directory.
    “depends-on” is more flexible because it handles partial ordering when
    “component-load.xml” defines a total order which is not necessarily
    meaningful, so it is better to rely only “depends-on”.
    This removes the usage of “component-load.xml” to use ‘depends-on’
    instead. The dependency declarations correspond to the total ordering
    previously defined but will need to be refined in the future to relax
    unnecessary dependency declarations.
    Only “framework/base/config/component-load.xml” which defines the
    top-level directories order (framework, applications, themes and
    plugins) is kept.
Commits on Nov 23, 2019
Commits on Nov 8, 2019
  1. Reverted: "Fixed: Remove dependency management from ‘ComponentContain…

    mthl committed Nov 8, 2019
    This reverts commit 3d3533c.
    ‘./gradlew cleanAll loadAll’ do not work anymore.
  2. Fixed: Fix linting issues

    mthl committed Nov 8, 2019
Commits on Oct 30, 2019
  1. Improved: Update checkstyle max error count

    mthl committed Oct 30, 2019
    git-svn-id: 13f79535-47bb-0310-9956-ffa450edef68
  2. Improved: Turn ‘DependsOnInfo’ into a String

    mthl committed Oct 30, 2019
    `depends-on` XML tag doesn't have any `loader` or `location` attribute so
    DependsOnInfo does not need to extend ResourceInfo.
    When removing the class derivation, DependsOnInfo now becomes a simple box
    containing a String attribute. In order to make the manipulation of dependency
    information simpler, the attribute is now inlined as a simple String value.
    Thanks: Samuel Trégouët for your contribution
    git-svn-id: 13f79535-47bb-0310-9956-ffa450edef68
  3. Improved: Add ‘ComponentConfig#toString’ to ease debugging

    mthl committed Oct 30, 2019
    Thanks: Samuel Trégouët for your contribution
    git-svn-id: 13f79535-47bb-0310-9956-ffa450edef68
  4. Improved: Rewrite ‘ComponentContainer#loadComponentsInDirectory’

    mthl committed Oct 30, 2019
    Use a more declarative style with the stream API.
    git-svn-id: 13f79535-47bb-0310-9956-ffa450edef68
  5. Improved: Delay the construction of component classpaths

    mthl committed Oct 30, 2019
    The list of component classpath elements was constructed iteratively
    while loading components. This list was additionally used to check if
    a component was actually loaded.  This implementation was leading to
    hard to understand code that has been replaced by a more appropriate
    ‘LinkedHashSet’ object.
    git-svn-id: 13f79535-47bb-0310-9956-ffa450edef68
  6. Improved: Remove unnecessary ‘throws’ declarations

    mthl committed Oct 30, 2019
    Some declared and/or documented exceptions that were not actually
    git-svn-id: 13f79535-47bb-0310-9956-ffa450edef68
  7. Improved: Import ‘ComponentDef’ and ‘DependsOnInfo’ inner-classes

    mthl committed Oct 30, 2019
    This allows to use shorter name when using an variable or parameter of
    those types.
    git-svn-id: 13f79535-47bb-0310-9956-ffa450edef68
Commits on Oct 29, 2019
  1. Improved: Upgrade Groovy 2.4.16 → 2.5.8

    mthl committed Oct 29, 2019
    git-svn-id: 13f79535-47bb-0310-9956-ffa450edef68
You can’t perform that action at this time.