Improved: Tax Authority Data for China (OFBIZ-11628) #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(OFBIZ-11628) added party and tax authority data for China
|
Kudos, SonarCloud Quality Gate passed!
|
|
That sound good to me, but I'd prefer to follow the way the data are organised. I mean to separate the blocks (party+PartyGroup+PartyRole) and (TaxAuthority+TaxAuthorityGlAccount) as it's currently done. It's easier when you need to "look" or "use" the data. |
|
As it is in the patch and with various TaxAuthority parties in AccountingDemoData.xml. The inconsistency lies with several such parties and data from yore. |
|
Correcting past data elements for demo purposes is (to be) done via OFBIZ-6976 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(OFBIZ-11628)
added party and tax authority data for China