Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Bug Fix: Added check to avoid NPE if result-to-result is true.

If we set result-to-result true then for some cases actionResult may be empty so it throws an NPE action while executing eca action. Thanks Deepak.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1455407 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information...
commit f6e87647df07316a91393a77779ec5928578b2d7 1 parent e4172b0
authored March 12, 2013
2  framework/service/src/org/ofbiz/service/eca/ServiceEcaAction.java
@@ -191,7 +191,7 @@ public boolean runAction(String selfService, DispatchContext dctx, Map<String, O
191 191
         }
192 192
 
193 193
         // copy/combine error messages on error/failure (!success) or on resultToResult to combine any error info coming out, regardless of success status
194  
-        if (!success || resultToResult) {
  194
+        if ((!success || resultToResult) && UtilValidate.isNotEmpty(actionResult)) {
195 195
             String errorMessage = (String) actionResult.get(ModelService.ERROR_MESSAGE);
196 196
             String failMessage = (String) actionResult.get("failMessage");
197 197
             List<? extends Object> errorMessageList = UtilGenerics.checkList(actionResult.get(ModelService.ERROR_MESSAGE_LIST));

0 notes on commit f6e8764

Please sign in to comment.
Something went wrong with that request. Please try again.