Permalink
Commits on Feb 12, 2017
  1. Improved: Moves plugins and creates the new structure (OFBIZ-9182)

    Deepak Dixit
    Deepak Dixit committed Feb 12, 2017
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782651 13f79535-47bb-0310-9956-ffa450edef68
Commits on Feb 11, 2017
  1. Implemented: new gradle task pullPluginSource using a subversion grad…

    pythys committed Feb 11, 2017
    …le plugin
    
    (OFBIZ-9182)
    
    Added a new gradle task called pullPluginSource that fetches a plugin from
    the (yet to be created) plugins repository. Also updated the README.md file
    to reflect the changes that happened recently on the plugin management tasks
    
    This is the last commit required before restructuring the subversion repository
    as per the discussion thread mentioned in the above JIRA
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782605 13f79535-47bb-0310-9956-ffa450edef68
  2. No functional change, last update with less Vulnerable Dependencies

    JacquesLeRoux committed Feb 11, 2017
    Only higher will be considered, not done yet...
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782603 13f79535-47bb-0310-9956-ffa450edef68
  3. Implemented: Load demo data shows error loading xml files

    JacquesLeRoux committed Feb 11, 2017
    Fixed:
    (OFBIZ-9211)
    
    "gradlew cleanAll loadDefault" generates a data loading error
    
    It's logically due to the removing of plugins/component-load.xml in OFBIZ-9182
    A temporary solution is to put it in again. 
    A definitive solution is to remove data dependencies. 
    We have also this problem with ecommerce data which create dependencies 
    from applications
    
    jleroux: I don't close this issue yet because we need to work together on this.
    I simply remove the regression by putting back plugins/component-load.xml
    
    Thanks: Wai for report
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782577 13f79535-47bb-0310-9956-ffa450edef68
  4. Improved: refactor list related forms in Agreeement widgets

    JacquesLeRoux committed Feb 11, 2017
    (OFBIZ-9186)
    
    Refactoring various list forms into grids
    Refactoring various list form references in screens
    
    Thanks: Pierre Smits
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782562 13f79535-47bb-0310-9956-ffa450edef68
Commits on Feb 10, 2017
  1. Fixed: Reinstate url cache in UtilURL.fromResource

    JacquesLeRoux committed Feb 10, 2017
    (OFBIZ-9208)
    
    Adrian created the following commit to cache URL objects 
    
    
    Revision: 1649979
    Author: adrianc
    Date: 07 January 2015 00:24:28
    Message:
    Some optimizations for URL lookups.
    ----
    Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilProperties.java
    Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java
    
    and was later reverted in this commit
    
    Revision: 1650347
    Author: adrianc
    Date: 08 January 2015 17:53:59
    Message:
    Some small fixups for some of my previous commits.
    ----
    Modified : /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityClassLoader.java
    Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java
    
    We have found in one of our production servers that line 98 in UtilURL.java
    
    url = loader.getResource(resourceName);
    
    has caused locking and looking at the stack trace (from jstack). There are 
    numerous threads waiting on locks from within this method
    
    I propose the cache gets added back (we have done this as a patch on our systems
     with no ill effect)
    
    FYI - The commits are in reference to the EntityClassLoader which is not used 
    and does not work see OFBIZ-6210
    
    Thanks: Gareth Carter for report and suggestion
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782520 13f79535-47bb-0310-9956-ffa450edef68
  2. Fixed: SimpleMethod: FindByAnd never using EntityListIterator

    JacquesLeRoux committed Feb 10, 2017
    (OFBIZ-9152)
    
    Since the introduction of EntityQuery there was no distinction between a simple 
    method tags 
    <find-by-and use-iterator="true"> and <find-by-and use-iterator="false"> 
    (except cache handling).
    There is a condition "if (useIterator)" but with entityQueries did use 
    "[...].queryList()".
    
    Thanks: Mirko Vogelsmeier
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782498 13f79535-47bb-0310-9956-ffa450edef68
Commits on Feb 7, 2017
  1. Fixed: Birt logging unlogical high (OFBIZ-9201)

    nmalin committed Feb 7, 2017
    Currently the class BirtContainer call the birt engine with hard coded log level ALL that generated huge log file.
    We can't implement easily log4j on the birt engine so with this commit I create a quick fix to have matching between the java.util.Logger and org.apache.log4j.Logger level.
    You can select the log level from debug.properties to populate the ReportEngine log file.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782070 13f79535-47bb-0310-9956-ffa450edef68
  2. Fixed: Cancelled OrderItems are still included in orderGrandTotal.

    mbrohl committed Feb 7, 2017
    (OFBIZ-9204)
    
    Thanks: Maurice for reporting and providing the patch, Deepak and Jacques for their suggestions.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781979 13f79535-47bb-0310-9956-ffa450edef68
Commits on Feb 5, 2017
  1. No functional changes

    JacquesLeRoux committed Feb 5, 2017
    Completes r1781731 by putting svn:eol-style=native to *.sh;*.bat file types 
    
    There are also changes in files with have mixed EOLs because this is no sense
    when using native which automatically resolves this issue
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781735 13f79535-47bb-0310-9956-ffa450edef68
  2. No functional changes

    JacquesLeRoux committed Feb 5, 2017
    completes r1781219 by putting svn:eol-style=native to all file types declared 
    in [auto-props] section of the svn config files.css
    
    Actually this is only a 1st pass, it was too complicated to do it for  
    all file types at once only concerned here
    *.java;*.bsh;*.groovy;*.jsp;*.tld;*.ftl;*.js;*.sql;*.c;*.cpp;*.h;*.txt;*.sgml;
    *.properties;*.xml;.classpath;.project;*.sld;*.gml;*.xsl;*.xsd
    *.html;*.htm;*.css;*.md;README;NOTICE;LICENSE;rc.ofbiz.*;*.less;*.dsp;*.dsw
    
    Most files should not be concerned by this change, but it's impossible to do
    it one by one.
    
    There are also changes in files with have mixed EOLs; because this has no sense
    when using native which automatically resolves this issue
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781731 13f79535-47bb-0310-9956-ffa450edef68
Commits on Feb 4, 2017
  1. Fixed: Missing file results in error

    JacquesLeRoux committed Feb 4, 2017
    (OFBIZ-9198)
    
    When accessing a file/image in ecomseo (only seo version) that is physically 
    missing or the dataresource attribute isPublic=="N" the request results 
    in a loop.
    
    jleroux: to break the loop in case or error, I simply decided to return a 
    response of type none. I also added the same for io-error which can be returned
    by the DataEvents class, also in ecommerce controller
    
    Thanks: Ingo Wolfmayr for report
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781662 13f79535-47bb-0310-9956-ffa450edef68
Commits on Feb 2, 2017
  1. No functional change. We no longer need the svn:auto-props at this le…

    JacquesLeRoux committed Feb 2, 2017
    …vel, it's
    
    now set at OFBiz svn repo root level
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781446 13f79535-47bb-0310-9956-ffa450edef68
  2. No functional change, reverts r1781366

    JacquesLeRoux committed Feb 2, 2017
    I did not even notice I committed this bunch of WIP stuff. I guess I clicked 
    somewhere while my machine was too buzy
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781367 13f79535-47bb-0310-9956-ffa450edef68
  3. Implemented:

    JacquesLeRoux committed Feb 2, 2017
    Improved:
    Documented:
    Completed:
    Reverted:
    Fixed:
    (OFBIZ-)
    Explanation
    Thanks:
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781366 13f79535-47bb-0310-9956-ffa450edef68
Commits on Feb 1, 2017
  1. No functional changes

    JacquesLeRoux committed Feb 1, 2017
    At http://markmail.org/message/ffmyw773p65fndey I wrote:
    
    I'd like to follow the suggestion I made in the last message of the linked 
    thread.
    In other words, use
    http://subversion.apache.org/docs/release-notes/1.8.html#repos-dictated-config
    http://blogs.collab.net/subversion/the-road-to-repository-dictated-configuration-day-2-autoprops
    Then this problem would be over. No longer need to check from time to time that
    concerned files, have svn:eol-style=native property set
    This imply that all OFBiz users use svn > 1.7, but we can inform them, et voilà
    
    Then at markmail.org/message/h3q2yvj4db544ro7 I wrote:
    
    Actually, since we get new committers now and then and their are able to create
    new files I have a warning every 6 months which says "Check Java 
    files, have all svn:eol-style=native" (I totally forgot that because I assume
    the machine knows it and warns me ;))
    I could extend that to all files (at least the most prominent types), I'll
    see...
    
    This does what the last sentence said for Groovy, XML and few new Birt 
    Java files.
    
    I'll see if I can implement the svn 1.8 repos-dictated-config ASAP!
    
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781219 13f79535-47bb-0310-9956-ffa450edef68
  2. Fixed: After creating a new Flexible Birt report, before visualising …

    JacquesLeRoux committed Feb 1, 2017
    …it you need
    
     to do other actions
    (OFBIZ-9194)
    
    You need to add the data set fields with the Birt Report Designer 
    and publish the report. This will be documented with OFBIZ-9188
    
    I thought about graying the button but it was a delicate matter because it uses
    a <content element in screen and directly call a view handled from a Groovy 
    event.
    
    It was easier to fix the PrepareBirtCall Groovy event. But to be totally sure
    I also handled the possible NPE in the BirtViewHandler
    
    I also fixed viewLast error in controller 
    
    Because the files were not committed with the svn:eol-style native property
    you will see false changes in this commit. Some files have their svn:eol-style 
    native property set. I'll soon commit missing so in new Birt Java files.
    
    I'll also commit a lot of svn:eol-style native property changes for XML and 
    Groovy files which have been neglected so far. I'm sorry for that because 
    when we do so we loose the annotations history. I will then definitely put in 
    place what I suggested in http://markmail.org/message/ffmyw773p65fndey
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781218 13f79535-47bb-0310-9956-ffa450edef68
  3. No functional changes

    JacquesLeRoux committed Feb 1, 2017
    Adds a missing BirtOverrideFilters label
    Fixes a typo in BirtServices.java and organise imports
    Change a button name in BirtForms.xml
    Uses the BirtOverrideFilters label in BirtScreens.xml
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781215 13f79535-47bb-0310-9956-ffa450edef68
  4. No functional change, removes useless line

    JacquesLeRoux committed Feb 1, 2017
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781209 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jan 31, 2017
  1. Fixed: Navigate Accounts tree does not work

    JacquesLeRoux committed Jan 31, 2017
    (OFBIZ-9191)
    
    This is due to a change in (at least) Tomcat 8.0.39
    
    Here is a simple fix. I tried other ways but none worked and I prefer to keep
    this simple.
    I tried other ways but none worked and I prefer to keep this simple.
    * Using an encoder at this stage (just before calling the macro) is not an 
    option. Or maybe by using the encoder on the linkurl variable alone. 
    But then linkurl  must be transformed in a String and  back to a 
    StringBuilder or more refactoring is needed. It does not worth it IMO.
    * Also using encode="true" for links in AccountingTrees.xml does not work.
    
    This also removes trailing blanks (by hand)
    
    Thanks: Moatasim Al Masri for report
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781125 13f79535-47bb-0310-9956-ffa450edef68
  2. Fixed: reversed the debit and credit entries of the accounting transa…

    jacopoc committed Jan 31, 2017
    …ctions for
    
    fixed asset depreciations.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781109 13f79535-47bb-0310-9956-ffa450edef68
  3. Improved: Implement and demonstrate few services in Birt Report Builder

    JacquesLeRoux committed Jan 31, 2017
    (OFBIZ-9192)
    
    The Birt Report Builder can also use services. for now only the "rotation" 
    report as been provided. We can provide more examples based on François' 
    work. 
    
    Here are trivial changes
      fixes missing Lookup maps and view in controller for the "rotation" report 
      new needed labels
      typos fixed
      
    
    
    Thanks:
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781084 13f79535-47bb-0310-9956-ffa450edef68
  4. No functional change, updates Supported Content Types in example cont…

    JacquesLeRoux committed Jan 31, 2017
    …roller to
    
    be the same than in birt controller
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781037 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jan 29, 2017
  1. Implemented: removed orphaned function no longer used due to previous…

    pythys committed Jan 29, 2017
    … commit
    
    (OFBIZ-9182)
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780832 13f79535-47bb-0310-9956-ffa450edef68
  2. Implemented: removed the plugin activate/deactivate feature

    pythys committed Jan 29, 2017
    (OFBIZ-9182)
    
    In preparation for moving to a new svn, we removed the component-load.xml file
    which was the way in which components were activated / deactivated in
    /plugins. This is made redundant and hence removing unnecessary code.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780828 13f79535-47bb-0310-9956-ffa450edef68
  3. Fixed: no functional change, remove ';' to respect coding groovy conv…

    nmalin committed Jan 29, 2017
    …ention
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780801 13f79535-47bb-0310-9956-ffa450edef68
  4. Fixed: Convert delegator.find to EntityQuery (OFBIZ-9189)

    nmalin committed Jan 29, 2017
    The code came from a project under ofbiz 13.07 and is still using deprecated delegator.find calls, so I converted them to EntityQuery
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780800 13f79535-47bb-0310-9956-ffa450edef68
  5. Improved: fully refactored the component loading logic in Gradle

    pythys committed Jan 29, 2017
    (OFBIZ-9182)
    
    This commit provides the following:
    - Fully refactor common.gradle so that it mirrors the component loading
      logic found in ComponentContainer. This makes the loading very flexible
      and changing the directory structure should have no impact on the build
      scripts.
    - Gradle will now ignore a component if it exists but disabled in
      ofbiz-component.xml (i.e. enabled="false")
    - Removes /plugins/component-load.xml
    - Disables the ebaystore component in ofbiz-component.xml
    
    The above is needed as a first step toward preparing the project for svn
    restructure
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780790 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jan 28, 2017
  1. Fixed: Changed log level always to info in minilang (OFBIZ-6206)

    nmalin committed Jan 28, 2017
    Because the log level always is display as FATAL on log, this raise useless log and generate many noise for production site.
    Generally these logs are present for debugging historical reason
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780691 13f79535-47bb-0310-9956-ffa450edef68
  2. Implemented: Birt Report Builder: an enhancement of the Birt componen…

    nmalin committed Jan 28, 2017
    …t. Easier user possibility of report creation. (OFBIZ-6919)
    
    The concept, you define a report domain related to an entity or a service through a master content (master report) and a master search form.
    When a high level user create a report on a configured domain, OFBiz prepare an instantiation of the master content (flexible report) that permit
    to surcharge the search form (recorded dynamically on the content as ElectronicText) and prepare a rptDesign skeleton.
    The high level user can download the rptDesign to edit it trhough the birt editor, with all fields that ofbiz will be load as dataset and when is finish upload the result on the content instantiation.
    For the end user, he selected the instantiation report, OFBiz display the report search from the content instantiation and the submission call birt with the search parameters and the linked rptDesign.
    
    The rptDesign file is drive by OFBiz to build the data set by two methods :
     * call the performFind if the domain is related to an entity
     * call the a custom service if the domain is related to a service.
    For the last case we need two services, a first who prepare and list available fields for search and display. And a second who realize the search.
    By convention currently the first service as the same name that the second service suffixed by 'PrepareFields'
    
    This commit contains :
     * useful UI to create a new content instance from a master content. List, edit, remove a content instance and a simple drop-down to list all instance published (ready to use by end user)
     * all services (with the work flexibleReport) to manage a flexible report, prepare the rptDesign skeleton, reanalyze the rptDesign uploaded, prepare the search form
     * Services interface to define you own search custom method
     * Two examples, one on the entity Exemple and one with the service flexibleReportTurnOver. Warning ! there are raw example without a beautiful rptDesign so you need to update the rptDesign with the birt editor to display something.
    Thanks: François Wurmser for initialize this improvement, Jacques and Gil for their time to analyze, document and refactor the code
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780683 13f79535-47bb-0310-9956-ffa450edef68
  3. No functional change, only this test is concerned, more a bug fix tho…

    JacquesLeRoux committed Jan 28, 2017
    …ugh.
    
    Despite missing the creation data in svn, I guess this file has been created 
    after I created the portoffset feature or I missed it then (unlikely since I
    changed all 8080 and 8443 ports in Java code). 
    
    Anyway, we now need this to be portoffset aware and this commit just does that
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780659 13f79535-47bb-0310-9956-ffa450edef68