Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Oct 18, 2012
  1. @jacopoc
Commits on Oct 8, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1395460"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1395460 | jleroux | 2012-10-08 09:26:02 +0200 (lun., 08 oct. 2012) | 10 lines
    
    A patch from Leon "very trivial update to fieldlookup.js in case of "null object" failure for weird unknonw reason" https://issues.apache.org/jira/browse/OFBIZ-4911
    
    I cannot find the root cause and it's hard to reproduce, but it does happen sometimes. The web browser reports "null object" exception when it tries to evaluate following codes in fieldlookup.js: 
    {quote}
    var obj_caller = (window.opener? window.opener.lookups[num_id]: null);
    {quote}
    
    window.opener is there but window.opener.lookups is null.
    
    jleroux: better be safe than sorry, even if it hides the original reason this no functional change can't have any side effects.
    ------------------------------------------------------------------------
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1395488 13f79535-47bb-0310-9956-ffa450edef68
Commits on Oct 6, 2012
  1. @JacquesLeRoux

    A patch from Varun Bhansaly "Email configuration - mail.smtp.starttls…

    JacquesLeRoux authored
    ….enable ignored" https://issues.apache.org/jira/browse/OFBIZ-4943
    
    The email configuration setting mail.smtp.starttls.enable is ignored by the system.
    I encountered this while configuring OFBiz an email server which had TLS enabled.
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1395122 13f79535-47bb-0310-9956-ffa450edef68
  2. @JacquesLeRoux

    "Applied fix from trunk for revision: 1394995"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1394995 | jleroux | 2012-10-06 12:59:12 +0200 (sam., 06 oct. 2012) | 9 lines
    
    A modified patch from  Jyoti Sharma https://issues.apache.org/jira/browse/OFBIZ-5043
    
    When i worked with Url Rewrite Filter, i faced the following issue:-
    In case of http protocol in the url, https links on th epage were not being rewritten and when their was https url, http links were not rewritten.
    
    The issue behind this what i found is that in RequestHandler.java encodeUrl() is not called in the above given case.
    So, if we place response.encodeUrl() their the issue is resolved. 
    
    jleroux: This makes sense since we are still in the "if (encode) {" block. I just noticed that response != null was checked above so I placed the same check before encoding
    ------------------------------------------------------------------------
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1395084 13f79535-47bb-0310-9956-ffa450edef68
Commits on Oct 4, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1393948"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1393948 | jleroux | 2012-10-04 10:07:34 +0200 (jeu., 04 oct. 2012) | 17 lines
    
    A patch from Paul Foxworthy "Recalculate Order causes NumberFormatException" https://issues.apache.org/jira/browse/OFBIZ-5046
    
    On demo site, create a new order by using the URL https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry
    
    Enter any Product ID, e.g. GZ-1000
    Enter a Quantity, e.g. 1
    Click on Add To Order
    
    Now click on Recalculate Order on the title bar of the Create Order screenlet
    Check the logs. On the demo site, you can do this with the URL https://demo-trunk.ofbiz.apache.org/webtools/control/LogView
    
    You will see:
    Exception: java.lang.NumberFormatException Message: For input string: "i18n" ---- stack trace --------------------------------------------------------------- java.lang.NumberFormatException: For input string: "i18n" java.lang.NumberFormatException.forInputString(NumberFormatException.java:48) java.lang.Integer.parseInt(Integer.java:449) java.lang.Integer.parseInt(Integer.java:499) org.ofbiz.order.shoppingcart.ShoppingCartHelper.modifyCart(ShoppingCartHelper.java:673)
    
    The problem is the suffix _i18n on the input elements. The code in modifycart assumes the last thing in the parameter names is a sequence number.
    This problem is not as severe as OFBIZ-5045, because the exception is swallowed immediately and the cart is updated properly. Still, these exceptions slow down OFBiz and add noise to the logs.
    
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1393972 13f79535-47bb-0310-9956-ffa450edef68
Commits on Oct 2, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1392773"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1392773 | sascharodekamp | 2012-10-02 09:43:01 +0200 (mar., 02 oct. 2012) | 1 line
    
    Edit Estimated Ship Date or Estimated Delivery Date brings on date format error (https://issues.apache.org/jira/browse/OFBIZ-5045). A patch from Paul Foxworthy: The patch adds an if statement to ignore members of the isdm and iddm maps with keys that have a suffix of _i18n.
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1393192 13f79535-47bb-0310-9956-ffa450edef68
  2. Bug Fix: No Url encoding for get parameters (https://issues.apache.or…

    Sascha Rodekamp authored
    …g/jira/browse/OFBIZ-2628). Thanks Wojciech Szymanowski for the hint. This Patch fixes the problems with parameters from hidden fields sending with POST method and parameters sending during "request-redirect" response type
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1392767 13f79535-47bb-0310-9956-ffa450edef68
Commits on Sep 27, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1390542"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1390542 | sascharodekamp | 2012-09-26 17:03:23 +0200 (mer., 26 sept. 2012) | 1 line
    
    Bug Fix: No Url encoding for get parameters (https://issues.apache.org/jira/browse/OFBIZ-2628). Thanks Wojciech Szymanowski for the hint. The CatalinaContainer.createConnector() method does not initialize Connector.URIEncoding property from ContainerConfig class. 
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1390845 13f79535-47bb-0310-9956-ffa450edef68
Commits on Sep 22, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1388832"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1388832 | jleroux | 2012-09-22 18:24:26 +0200 (sam., 22 sept. 2012) | 4 lines
    
    A patch from Tom Burns "Pagination Fails in Form ListAgreementTerms " https://issues.apache.org/jira/browse/OFBIZ-5013
    
    As mentionned by Tom, ListAgreementRoles pagination also failed: paginate-target FindAgreementRoles does not exist. I replaced by EditAgreementRoles, works
    
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1388836 13f79535-47bb-0310-9956-ffa450edef68
Commits on Sep 20, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1387884"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1387884 | jleroux | 2012-09-20 09:06:17 +0200 (jeu., 20 sept. 2012) | 6 lines
    
    A patch from Daniel Riquelme " Improve Tree Widget to support Multiple PK Entities" https://issues.apache.org/jira/browse/OFBIZ-4971
    
    The PKs are used to keep track of which nodes have been rendered when performing recursion inside Tree Widget rendering code.
    Currently Multiple PKs Entities can't be used as nodes in a Tree Widget because the rendering code does not handle them.
    
    
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1387887 13f79535-47bb-0310-9956-ffa450edef68
Commits on Sep 17, 2012
  1. @JacquesLeRoux

    No functional changes, this is the backporting of r1167132, r1139858,…

    JacquesLeRoux authored
    … r1299985 and a line from r1059352 for "OfBiz 10.04 Does not compile with Oracle JDK 7" https://issues.apache.org/jira/browse/OFBIZ-4749
    
    Thanks to Karl Laird for report and Paul Foxworthy's + Sergey Derevyanko's help R10.04 now compiles and run (faster) under JDK 7 (hence OPENJDK 7)
    
    jleroux: Since the r1059352 patch does not apply completely, I simply changed the needed line by hand in InvoiceServices.java[104]:
    
        invoicesCreated.add(UtilMisc.toMap("commissionInvoiceId",invoiceId, "salesRepresentative ",partyIdBillFrom));
        + invoicesCreated.add(UtilMisc.<String, String>toMap("commissionInvoiceId",invoiceId, "salesRepresentative ",partyIdBillFrom));
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1386469 13f79535-47bb-0310-9956-ffa450edef68
Commits on Sep 15, 2012
  1. Applied bug fix from trunk revision: 1385014

    Ashish Vijaywargiya authored
    Log:
    Applied bug fix from jira issue - OFBIZ-4972 - NumberFormateException while update order items.
    If order item price or quantity is greater then 999 then update order items service throw NumberFormateException.
    Steps to regenerate:
    Create an order(SO/PO).
    Edit order items, set order price 1000 and update order items.
    Again edit order items and try to update price from (1,000 to 1,002).
    System will throw NPE and if same will perform for quantity then it will throw NumberFormatException on console.
    Thanks Deepak for the contribution.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1385017 13f79535-47bb-0310-9956-ffa450edef68
Commits on Aug 26, 2012
  1. @JacquesLeRoux
Commits on Jul 21, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1364052"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1364052 | jleroux | 2012-07-21 11:06:03 +0200 (sam., 21 juil. 2012) | 22 lines
    
    A patch from Sumit Pandit for "Order view page - picking slip is throwing exception." https://issues.apache.org/jira/browse/OFBIZ-2810
    
    At https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10091 , In shipping panel at shipment row when click on "Packing Slip" it is throwing an exception in rendering the PDF.
    
    Vikas: This is related to the demo order data for purchase order which is not set up correctly. For more information please refer to OFBIZ-1782
    Sumit: Found an issue with demo data.
    How to verify -
        Go to order detail page -
        https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10091
    
        Then in shipment information section click on "Packing Slip" -
        https://localhost:8443/facility/control/PackingSlip.pdf?shipmentId=9999&externalLoginKey=EL564429820623
    
        Issue cause -
        Missing created date in Data.
    
        Resolution -
        Find patch in attachment.
    
    jleroux: I crossed this recently and thought that the button should not show until packed. But it was rather coded to show "ERROR: No packages found for this shipment" in the PDF. I think it would be better to not show the button, but it's ok with me.
    
    
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1364055 13f79535-47bb-0310-9956-ffa450edef68
  2. @JacquesLeRoux

    "Applied fix from trunk for revision: 1364046 "

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1364046 | jleroux | 2012-07-21 10:43:19 +0200 (sam., 21 juil. 2012) | 13 lines
    
    A patch from Leon for "IndexOutOfBoundsException thrown by ServerHitBin.countHit" https://issues.apache.org/jira/browse/OFBIZ-4969
    
    This exception thrown out when initiated a "json" request.
    
        229156224 [http-bio-0.0.0.0-443-exec-6138] ERROR org.ofbiz.webapp.control.ControlServlet -
        ---- runtime exception report --------------------------------------------------
        Error in request handler:
        Exception: java.lang.IndexOutOfBoundsException
        Message: index: 0
        ---- stack trace ---------------------------------------------------------------
        java.lang.IndexOutOfBoundsException: index: 0
        javolution.util.FastList.add(FastList.java:228)
        org.ofbiz.webapp.stats.ServerHitBin.countHit(ServerHitBin.java:210)
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1364049 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jul 8, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1358735 "

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1358735 | jleroux | 2012-07-08 15:15:56 +0200 (dim., 08 juil. 2012) | 7 lines
    
    A patch from Daniel Riquelme "Not getting right behavior of use-when when using in multi" https://issues.apache.org/jira/browse/OFBIZ-4932
    
    The problem is that on multi forms the bshInterpreter gets pushed to higher levels on the context stack when iterating the form rows.
    What is intended in the code is to reset the bshInterpreter (this.resetBshInterpreter(context) for each row iteration, this reset translates into a key object being removed from context, this context is stored in a stack data structure. The removal assumes the value will always be at level 0, yet what happens is that the value resides at a higher level.
    The fix is to perform the removal prior to context modification, this way the bshInterpereter object would be at level 0 upon removal.
    
    jleroux: since the BshInterpreter is reseted just after with localContext this should not have any bad side effects
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1358738 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jul 1, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1355859"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1355859 | jleroux | 2012-07-01 10:23:38 +0200 (dim., 01 juil. 2012) | 1 line
    
    Fixes a bug reported by Krishan Babbar on user ML
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1355862 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jun 30, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1355801 " (actually only partia…

    JacquesLeRoux authored
    …lly: only the hidden partyId field has been added to AddRoleType, only bug fixes get into releases branches)
    
    ------------------------------------------------------------------------
    r1355801 | jleroux | 2012-06-30 22:12:19 +0200 (sam., 30 juin 2012) | 14 lines
    
    A patch from Tom Burns for "Defects in Presentation of Role Type" https://issues.apache.org/jira/browse/OFBIZ-4947
    
    Release 10.4 and SVN tunk
    In Party Manager go to Profile > Roles(s)
    1. Create a New Role Type
    2. Click save
    Expected: Screen refresh and return to Roles(s) tab on ProfileTabBar
    Actual: Screen refresh ProfileTabBar missing
    
    In SVN tunk
    In Party Manager go to Profile > Roles(s)
    Expected: Roles listed in screenlet Add To Main Role > Role Type Id drop-down list
    Actual: Screenlet Add To Main Role > Role Type Id drop-down list is empty.
    
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1355806 13f79535-47bb-0310-9956-ffa450edef68
  2. @JacquesLeRoux

    "Applied fix from trunk for revision: 1355660"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1355660 | jleroux | 2012-06-30 10:15:42 +0200 (sam., 30 juin 2012) | 10 lines
    
    "Login out on a cluster handled by DeltaManager causes a NPE" https://issues.apache.org/jira/browse/OFBIZ-4289
    
    Uses a HashMap instead of a FastMap here because else we get this kind of error when OFBiz is shut down:
    
    2012-06-12 10:35:29,921 (OFBiz_Shutdown_Hook) [ StandardSession.java:1567:WARN ] Cannot serialize session attribute LAST_VIEW_PARAMS for session 00C48D0D76821C98403482FAE8B77C24.jvm1
    java.io.NotSerializableException: net.sf.json.JSONObject
    at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1164)
    at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:330)
    at javolution.util.FastMap.writeObject(FastMap.java:1513)
    
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1355663 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jun 23, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1353135 "

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1353135 | jleroux | 2012-06-23 16:57:18 +0200 (sam., 23 juin 2012) | 2 lines
    
    Closes "Login out on a cluster handled by DeltaManager causes a NPE" https://issues.apache.org/jira/browse/OFBIZ-4289
    Removes all changes related to this issue. We will see later if ever it proves to be a real issue.
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1353137 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jun 20, 2012
  1. @jacopoc

    Applied fix from trunk for revision: 1351778

    jacopoc authored
    ===
    
    Setting a default value of DeltaManager was causing a side effect: the method setWebContextObjects was always invoked with the persistSerialized argument set to false; this was causing a series of issues (including one reported recently happening when two users login/logout to the same application from the same browser and visit another application).
     
     The commit when this bug was introduced is:
     
     Author: jleroux
     Date: Mon Jun  6 20:26:35 2011
     New Revision: 1132749
     
     and unfortunately the revision was backported to the release branches; the commit may have introduced other issues but I can't review it now.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1352023 13f79535-47bb-0310-9956-ffa450edef68
  2. @jacopoc

    Applied fix from trunk for revision: 1351999

    jacopoc authored
    ===
    
    When an IOException error happens while communicating with the browser (for example when the user closes the browser window before the page is returned) there is no need to attempt to render the error page; this was causing two error stack traces in the logs every time a connection was aborted; improved logging for this event.
    
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1352021 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jun 14, 2012
  1. Applied bug fix from trunk r1350368.

    Ashish Vijaywargiya authored
    Applied bug fix from jira issue - OFBIZ-4933 - Add/Update order item does not accept the negative quantity.
    When user update the order item and enter the negative item quantity then system should throw an error message.
    Thanks Deepak!
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1350371 13f79535-47bb-0310-9956-ffa450edef68
  2. Applied bug fix from trunk r1350363.

    Ashish Vijaywargiya authored
    Applied bug fix from jira issue - OFBIZ-4918 - Not able to add party rate.
    User does not able to add party rate via Rate screen.
    https://demo-trunk.ofbiz.apache.org/partymgr/control/EditPartyRates?partyId=admin
    Thanks Deepak!
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1350365 13f79535-47bb-0310-9956-ffa450edef68
  3. Applied bug fix from trunk r1350356.

    Ashish Vijaywargiya authored
    Applied bug fix from jira issue - OFBIZ-4907 - Invalid relation name status item for Production Run.
    Could not find relation for relationName: StatusItem for value [GenericEntity:WorkEffort]
    Thanks Deepak for the contribution.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1350360 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jun 11, 2012
  1. Applied fix from trunk r1347442.

    Ashish Vijaywargiya authored
    Set cache flag for findByAnd method calls in PreferenceServices; improved logic to avoid to run the same query twice when user is not passed.
    Note: This is not a bug but not using cache here is really a very serious issue for performance on production server because the queries are executed at every page request. We have applied this changes on production server and then observed the production server activity for about one week and found that now production server is working fine under heavy load.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1348836 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jun 9, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1347762"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1347762 | jleroux | 2012-06-07 21:25:30 +0200 (jeu., 07 juin 2012) | 8 lines
    
    Small improvement:
    * Adds "cross-redirect"
    * Improve doc for 
      ** request-redirect
      ** request-redirect-noparam
      ** url
      
    
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1348333 13f79535-47bb-0310-9956-ffa450edef68
  2. @JacquesLeRoux

    "Applied fix from trunk for revision: 1342567" (conflict handled by h…

    JacquesLeRoux authored
    …and)
    
    ------------------------------------------------------------------------
    r1342567 | jleroux | 2012-05-25 12:47:00 +0200 (ven., 25 mai 2012) | 1 line
    
    Forget to document the value option for redirect-parameter (not a big deal, pretty obvious, so I don't backport)
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1348330 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jun 2, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1345547 "

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1345547 | jleroux | 2012-06-02 20:47:41 +0200 (sam., 02 juin 2012) | 8 lines
    
    A patch from Nandani Aggarwal "Upload file throws java.lang.ClassCastException: java.nio.HeapByteBuffer" https://issues.apache.org/jira/browse/OFBIZ-4919
    
    While creating Promo under catalog in Admin , we create Promo Code so that party or Email can be attached to Promo and also there we can set expiry date for that Promo.While uploading list of Email Ids for which Promo will be applicable,,i encountered with error : java.lang.ClassCasrrException:java.nio.HeapByteBuffer.
    Error can be reproduced by following link :
    https://localhost:8443/catalog/control/createBulkProductPromoCodeEmail?productPromoCodeId="Name of : Product Promo Code Id"
    Or with help of attached screenshot.
    
    
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1345551 13f79535-47bb-0310-9956-ffa450edef68
Commits on May 26, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1342980 " (actually not the poi…

    JacquesLeRoux authored
    …nt 2 which was not there yet)
    
    ------------------------------------------------------------------------
    r1342980 | jleroux | 2012-05-27 00:13:01 +0200 (dim., 27 mai 2012) | 26 lines
    
    Closes 
    1) "Deleted row in FilterOrderList.groovy"  https://issues.apache.org/jira/browse/OFBIZ-3431
    2) "getOrders() in OrderListState does not work" https://issues.apache.org/jira/browse/OFBIZ-4883
    
    As I had some doubt about the origin of the issues and wanted to check if they were real and would not hide something else or have side-effect, I did a complete historical review.
    
    1) Could have been hidden using groovy safe navigation 
    ie 
    facilityId = orderHeader.originFacilityId ?: productStore?.inventoryFacilityId;
    instead of
    facilityId = orderHeader.originFacilityId ?: productStore.inventoryFacilityId;
    
    But anyway it was wrong from the start when I introduced the feature  http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/filterorderlist.bsh?view=markup&pathrev=465376
    (related to https://issues.apache.org/jira/browse/OFBIZ-644)
    The facilityId  was useless. I remember I extracted it from a client specific feature and certainly forgot  to remove this part (useless at least in OFBiz code) when I merged with Leon's code.
    
    2) Was Erwan wrong C/P or typo at http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderListState.java?r1=1305309&r2=1305308&pathrev=1305309
    
    Thanks to Chatree Srichart and Nils Pförtner for reports (actually I found OFBIZ-3431 by chance while working on the issue)
    
    Still, David was against this feature when I introduced it. And I must say that almost 6 years later I tend to agree with him. I have since crossed the same kind of OO patterns written in OFBiz based application by good Java programmers. They breaks the "simple" ways used in OFBiz at the application level (of course not at the framework level where those patterns are useful) and often finish to be problems...
    
    Quoting David:
    <<In general I don't like the pattern used in this patch. It doesn't follow best practices or use the tools and patterns established in OFBiz to make all of our lives easier, during implementation but even more importantly during maintenance and customization. There are very good reasons we recommend using object oriented patterns written in Java on only very rare occasions. This is a good example of something that is not complex enough to justify, and it will be a maintenance problem in the future.>>
    
    Anyway this code is there now, and it's actually not as simple to replace...
    ------------------------------------------------------------------------
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1342983 13f79535-47bb-0310-9956-ffa450edef68
  2. @JacquesLeRoux

    "Applied fix from trunk for revision: 1342875 "

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1342875 | jleroux | 2012-05-26 12:09:03 +0200 (sam., 26 mai 2012) | 3 lines
    
    A completing patch from Pierre Smits "Complete Help screens in Manufacturing in NL language" https://issues.apache.org/jira/browse/OFBIZ-4898
    
    
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1342878 13f79535-47bb-0310-9956-ffa450edef68
Commits on May 23, 2012
  1. Applied bug fix from trunk r1341770.

    Ashish Vijaywargiya authored
    Fixing important bug that we have observed in one of the production system. This error comes when production system generates lot of JobSandbox records. And sometime it happens that purgeOldJobs service tries to remove RuntimeData from the system but runtimeDataId is still referred in JobSandbox records. To fix this bug we have separated out the code for deleting RuntimeData. We have also tested this fix on production system for about two weeks and now things are better over there. Thanks Jacopo for the discussion.
    
    Here I am sharing console log for everyones reference:
    f9cb9ec37f8ed14 Apr 28, 2012 10:47:46 PM org.apache.jk.common.ChannelSocket processConnection
    f9cb9ec37f8f0fc WARNING: processCallbacks status 2
    f9cbcd4388830dc 2012-04-28 23:00:10,947 (default-invoker-Thread-781938) [ GenericDelegator.java:1163:ERROR]
    f9cbcd4388834c4 ---- exception report ----------------------------------------------------------
    f9cbcd4388838ac Failure in removeByCondition operation for entity [RuntimeData]: org.ofbiz.entity.GenericDataSourceException: Generic Entity Exception occured in deleteByCondition (SQL Exception while executing the following:DELETE FROM public.RUNTIME_DATA WHERE (RUNTIME_DATA_ID = '45794') (ERROR: update or delete on table "runtime_data" violates foreign key constraint "job_sndbx_rntmdta" on table "job_sandbox"
    f9cbcd43888d4ec Detail: Key (runtime_data_id)=(45794) is still referenced from table "job_sandbox".)). Rolling back transaction.
    f9cbcd43888e48c Exception: org.ofbiz.entity.GenericDataSourceException
    f9cbcd43888e874 Message: Generic Entity Exception occured in deleteByCondition (SQL Exception while executing the following:DELETE FROM public.RUNTIME_DATA WHERE (RUNTIME_DATA_ID = '45794') (ERROR: update or delete on table "runtime_data" violates foreign key constraint "job_sndbx_rntmdta" on table "job_sandbox"
    f9cbcd43888ffe4 Detail: Key (runtime_data_id)=(45794) is still referenced from table "job_sandbox".))
    f9cbcd4388903cc ---- cause ---------------------------------------------------------------------
    f9cbcd438890b9c Exception: org.ofbiz.entity.GenericDataSourceException
    f9cbcd438890f84 Message: SQL Exception while executing the following:DELETE FROM public.RUNTIME_DATA WHERE (RUNTIME_DATA_ID = '45794') (ERROR: update or delete on table "runtime_data" violates foreign key constraint "job_sndbx_rntmdta" on table "job_sandbox"
    f9cbcd43889136c Detail: Key (runtime_data_id)=(45794) is still referenced from table "job_sandbox".)
    f9cbcd438895da4 ---- cause ---------------------------------------------------------------------
    f9cbcd43889618c Exception: org.postgresql.util.PSQLException
    f9cbcd43889618c Message: ERROR: update or delete on table "runtime_data" violates foreign key constraint "job_sndbx_rntmdta" on table "job_sandbox"
    f9cbcd438896574 Detail: Key (runtime_data_id)=(45794) is still referenced from table "job_sandbox".
    f9cbcd43889712c ---- stack trace ---------------------------------------------------------------
    f9cbcd43889712c org.postgresql.util.PSQLException: ERROR: update or delete on table "runtime_data" violates foreign key constraint "job_sndbx_rntmdta" on table "job_sandbox"
    f9cbcd43889889c Detail: Key (runtime_data_id)=(45794) is still referenced from table "job_sandbox".
    f9cbcd43889889c org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2103)
    f9cbcd438898c84 org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1836)
    f9cbcd438899454 org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:257)
    f9cbcd43889983c org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:512)
    f9cbcd43889983c org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:388)
    f9cbcd438899c24 org.postgresql.jdbc2.AbstractJdbc2Statement.executeUpdate(AbstractJdbc2Statement.java:334)
    f9cbcd43889a3f4 org.apache.commons.dbcp.DelegatingPreparedStatement.executeUpdate(DelegatingPreparedStatement.java:105)
    f9cbcd43889a7dc org.apache.commons.dbcp.DelegatingPreparedStatement.executeUpdate(DelegatingPreparedStatement.java:105)
    f9cbcd43889abc4 org.ofbiz.entity.jdbc.SQLProcessor.executeUpdate(SQLProcessor.java:420)
    f9cbcd43889abc4 org.ofbiz.entity.datasource.GenericDAO.deleteByCondition(GenericDAO.java:1158)
    f9cbcd43889bb64 org.ofbiz.entity.datasource.GenericDAO.deleteByCondition(GenericDAO.java:1132)
    f9cbcd43889bf4c org.ofbiz.entity.datasource.GenericHelperDAO.removeByCondition(GenericHelperDAO.java:160)
    f9cbcd43889c334 org.ofbiz.entity.GenericDelegator.removeByCondition(GenericDelegator.java:1152)
    f9cbcd43889c334 org.ofbiz.entity.GenericDelegator.removeByAnd(GenericDelegator.java:1120)
    f9cbcd43889cb04 org.ofbiz.entity.GenericDelegator.removeByAnd(GenericDelegator.java:1105)
    f9cbcd43889ceec org.ofbiz.entity.GenericDelegator.removeByAnd(GenericDelegator.java:1098)
    f9cbcd43889ceec org.ofbiz.service.ServiceUtil.purgeOldJobs(ServiceUtil.java:476)
    f9cbcd43889d2d4 sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    f9cbcd43889d2d4 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    f9cbcd43889de8c sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    f9cbcd43889de8c java.lang.reflect.Method.invoke(Method.java:597)
    f9cbcd43889e274 org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
    f9cbcd43889e274 org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
    f9cbcd43889f5fc org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:396)
    f9cbcd43889f9e4 org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:224)
    f9cbcd43889f9e4 org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
    f9cbcd43889fdcc org.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:71)
    f9cbcd43889fdcc org.ofbiz.service.job.JobInvoker.run(JobInvoker.java:242)
    f9cbcd4388a3c4c java.lang.Thread.run(Thread.java:662)
    f9cbcd4388a3c4c --------------------------------------------------------------------------------
    f9cbcd4388a4034
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1341773 13f79535-47bb-0310-9956-ffa450edef68
Commits on May 22, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1340273"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1340273 | jleroux | 2012-05-19 00:00:50 +0200 (sam., 19 mai 2012) | 3 lines
    
    A completing patch from Pierre Smits "Help screens in Manufacturing" https://issues.apache.org/jira/browse/OFBIZ-4802
    
    jleroux: I reviewed the English part (and the licenses in NL part) and only fixed a typo in EN/Help_MFG_ProductionRunCosts.xml (was prouction). I also wondered about the new content of Help_MFG_FindInventoryEventPlan, but it's quite correct
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1341494 13f79535-47bb-0310-9956-ffa450edef68
  2. @JacquesLeRoux

    "Applied fix from trunk for revision: 1187933" (Somehow it did not ap…

    JacquesLeRoux authored
    …ply at r1187935, here is a new patch from yashwant dhakad)
    
    ------------------------------------------------------------------------
    r1187933 | jleroux | 2011-10-23 19:05:59 +0200 (dim., 23 oct. 2011) | 10 lines
    
    A patch from Kiran Gawde "Warnings while approving the purchase order" https://issues.apache.org/jira/browse/OFBIZ-4495
    
    Following warnings were noticed in the log while approving the purchase order that was created automatically for drop ship product.
    
    [ OrderServices.java:2389:WARN ] Tried to setOrderStatus with the same statusId [ ORDER_APPROVED ] for order with ID
    [ServiceEcaCondition.java:156:WARN ] From Field (orderTypeId) is not found in context for changeOrderStatus, defaulting to null.
    
    The first warning suggest that there is order status is changed again. Shouldn't have happened. The order header should be updated before updating the order items.
    The second warning happens because some time, changeOrderStatus returns without adding orderTypeId to success result. Since there are secas rules based upon this field, the field should be mandatory and not optional.
    
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1341458 13f79535-47bb-0310-9956-ffa450edef68
  3. @jacopoc

    Applied fix from trunk for revision: 1341314

    jacopoc authored
    ===
    
    Fixed error reported in OFBIZ-4892: in orders with more than one promo codes, only one code was stored in OrderProductPromoCode entity.
    Thanks to Ritu Raj Lakhera for the report and the patch; the one I have committed fixes the bug in a slightly different way.
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1341326 13f79535-47bb-0310-9956-ffa450edef68
Something went wrong with that request. Please try again.