Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Jan 17, 2013
  1. @jacopoc
Commits on Jan 14, 2013
  1. @jacopoc

    Applied fix from trunk for revision: 1432833

    jacopoc authored
    ===
    
    The Image.alt is now escaped to prevent the risk of an XSS attack.
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1432846 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jan 12, 2013
  1. @jacopoc

    Applied fix from trunk for revision: 1432392

    jacopoc authored
    ===
    
    The content of the Screenlet title is now escaped to prevent the risk of an XSS attack.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1432397 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jan 10, 2013
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1431191" (imports conflict hand…

    JacquesLeRoux authored
    …led by hand)
    
    ------------------------------------------------------------------------
    r1431191 | jleroux | 2013-01-10 06:32:48 +0100 (jeu., 10 janv. 2013) | 10 lines
    
    In "Memory leak due to transaction management using DBCP and MySQL" https://issues.apache.org/jira/browse/OFBIZ-5122 Jose Manuel Vivó Arnal reported that I missed to apply the patch from OFBIZ-2599, just handled the DBPC part, and Philippe Mouawad did not notice.
    
    OK, so it was just a matter of replacing 
    PoolableConnectionFactory factory = new PoolableConnectionFactory(xacf, pool, null, null, true, true);
    by
    PoolableManagedConnectionFactory factory = new PoolableManagedConnectionFactory(xacf, pool, null, null, true, true);
    
    The rest are only imports cleaning.
    
    Too bad we did not notice that for 3.5 years. It seems it does not affect servers with plenty of memory, or updated often enough. But I recommend to upgrade of course...
    ------------------------------------------------------------------------
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1431205 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jan 8, 2013
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1068283"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1068283 | jleroux | 2011-02-08 08:47:25 +0100 (mar., 08 févr. 2011) | 8 lines
    
    Fix "Ajax requests prevent externalLoginKey parameters from working correctly" (https://issues.apache.org/jira/browse/OFBIZ-3862) - OFBIZ-3862
    
    Scott reported: To clarify, the problem only occurs if the Ajax call results in a screen being rendered since it is the ScreenRenderer that causes a new key to be generated.
    
    Bilgin suggested: I think a solution would be to skip generating of new external login key for Ajax requests.
    Ajax requests can be identified by presence of 'X-Requested-With': 'XMLHttpRequest', http header. It is set by most of the Javascript libraries we use: prototype, jquery.
    
    I coded it
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1430208 13f79535-47bb-0310-9956-ffa450edef68
  2. @JacquesLeRoux
Commits on Jan 5, 2013
  1. @JacquesLeRoux

    A sightly modified patch from Raghavendra Prakash for "In version 10.…

    JacquesLeRoux authored
    …04 - After clicking on lookup, display login page again" https://issues.apache.org/jira/browse/OFBIZ-4937
    
    Step 1: Login - https://localhost:8443/catalog/control/main; Login with credentials
    Step 2: Now, select Category lookup; Lookup popup appears; Just get rid of the popup
    Step 3: Next, select 'Party' menu item from application tab; You will see the login page again.
    Cause: externalKey becomes stale.
    
    I have fixed the issue with a small work around:
    externalLoginKeysWR - contains the userLogin for externalLoginKey from app-level tabs
    Logic behind: The userlogin could not be found for the external key after the lookup request handled
    by OFBiz. The external key with app level tabs become stale once the lookup request is handled, and userlogin
    was removed for app level tabs' external keys. As a work around, this fastmap still maitains association with that
    external key. When the userlogin could not be found with external key, it would be searched in this fastmap.
    This is accomplished in checkExternalLoginKey and getExternalLoginKey methods
    
    jleroux; After testing, I cleaned Raghavendra's contribution. It's maybe not the best way, but it works.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1429273 13f79535-47bb-0310-9956-ffa450edef68
  2. @JacquesLeRoux

    A patch from Praveen Agrawal "Implementing Try-Catch while Adding UiL…

    JacquesLeRoux authored
    …abel Resources" https://issues.apache.org/jira/browse/OFBIZ-5119
    
    In OrderServices.java in method 'sendOrderNotificationScreen (Line :2427) a try catch block must be there surrounding to Adding UiLabel resources to map. So that if any of the resource is not found then rest of the code does not fail.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1429234 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 27, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1426231"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1426231 | jleroux | 2012-12-27 16:51:10 +0100 (jeu., 27 déc. 2012) | 4 lines
    
    A patch from Deepak Dixit "Editing of product suppliers is not working for the Germany locale" https://issues.apache.org/jira/browse/OFBIZ-4769
    
    Thanks to Christian, Paul, Deepak, Adrian and I :)
    
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1426252 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 24, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1425662 "

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1425662 | jleroux | 2012-12-24 17:09:50 +0100 (lun., 24 déc. 2012) | 1 line
    
    This was wrong since r759871 (reversed test)
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1425669 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 15, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1422207"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1422207 | jleroux | 2012-12-15 10:15:37 +0100 (sam., 15 déc. 2012) | 32 lines
    
    A patch from Naofumi Fukue for "javascript error in hidden form" https://issues.apache.org/jira/browse/OFBIZ-5098
    
    HtmlMenuRenderer generates like bellow form tags. It generates double target="_BLANK" , then cause javascript error.
    
    <li><form method="post" action="/ar/control/invoice.pdf" target="_BLANK" name="InvoiceSubTabBar_pdf_LF_8"><input name="invoiceId" value="8010" type="hidden"/></form><a target="_BLANK" href="javascript:document.InvoiceSubTabBar_pdf_LF_8.submit()">PDF</a></li>
    
    document.InvoiceSubTabBar_pdf_LF_8 is undefined @ javascript:document.InvoiceSubTabBar_pdf_LF_8.submit()
    
    jleroux: to reproduce 
    
    For example, edit applications/accounting/webapp/accounting/WEB-INF/controller.xml like this.
    
    <request-map uri="invoice.pdf">
    <security https="true" auth="true"/>
    <event name="test" type="java" path="org.ofbiz.webapp.event.TestEvent" invoke="test"/> <= add this
    <response name="success" type="view" value="InvoicePDF"/>
    </request-map>
    
    And in invoice screen, click 'PDF' button. Exist or not exist above line, generated html is different.
    
    As is 
    ~event: PDF rendered
    <li><a target="_BLANK" href="/ar/control/invoice.pdf?invoiceId=8010">PDF</a></li>
    event:  PDF not rendered
    <li><form method="post" action="/ar/control/invoice.pdf" target="_BLANK" name="InvoiceSubTabBar_pdf_LF_8"><input name="invoiceId" value="8010" type="hidden"/></form><a target="_BLANK" href="javascript:document.InvoiceSubTabBar_pdf_LF_8.submit()">PDF</a></li>
    
    patched
    ~event: PDF rendered
    <li><a target="_BLANK" href="/ar/control/invoice.pdf?invoiceId=8010">PDF</a></li>
    event: PDF rendered
    <li><form method="post" action="/ar/control/invoice.pdf" target="_BLANK" name="InvoiceSubTabBar_pdf_LF_8"><input name="invoiceId" value="8010" type="hidden"/></form><a href="javascript:document.InvoiceSubTabBar_pdf_LF_8.submit()">PDF</a></li>
    
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1422220 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 14, 2012
  1. @JacquesLeRoux
  2. @JacquesLeRoux

    "Applied fix from trunk for revision: 1421662"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1421662 | jleroux | 2012-12-14 05:13:02 +0100 (ven., 14 déc. 2012) | 1 line
    
    Fixes "XML file containg Byte order mark" reported by Youssef Khaye at https://issues.apache.org/jira/browse/OFBIZ-5099
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1421726 13f79535-47bb-0310-9956-ffa450edef68
Commits on Nov 25, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1413307 "

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1413307 | jleroux | 2012-11-25 10:20:23 +0100 (dim., 25 nov. 2012) | 8 lines
    
    A patch from Sergei Biletnikov "Remote services via XMLRpc ignore the locale which is passed as the service parameter, the default locale is used forever" https://issues.apache.org/jira/browse/OFBIZ-5083
    
    This code replaces the possible locale from parameters by default locale.
    
    // add the locale to the context
    context.put("locale", Locale.getDefault());
    
    The solution is simple: firstly check, if we have the locale as the parameter, if no, use the default locale.
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1413318 13f79535-47bb-0310-9956-ffa450edef68
Commits on Nov 10, 2012
  1. @JacquesLeRoux

    An patch from John McDonald for "Customer's Shipment Address Not Assi…

    JacquesLeRoux authored
    …gned to Dropship Purchase Orders" https://issues.apache.org/jira/browse/OFBIZ-3883
    
    When buying drop ship products from the demo store the customer's shipping address is not saved with the purchase order, so the shipping address cannot be provided to the drop ship supplier. 
    
    Steps to Reproduce:
    * From the DropShip Category add "DropShip from BigSupplier" and "DropShip from DemoSupplier" to your cart. 
    * Login as admin
    * Use the one page checkout to order the products
    
    Resulting Order: 
    https://demo-trunk.ofbiz.apache.org:8443/ordermgr/control/orderview?orderId=WSCO10002
    The purchase orders WS10003 and WS10004 are associated correctly with the order items, but as the shipping groups don't have addresses, the purchase orders don't have either.
    
    Expectation:
    All Shipment groups should have the shipping address assigned.
    
    Actual:
    Only the first shipment group has the shipping address assigned. 
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1407700 13f79535-47bb-0310-9956-ffa450edef68
Commits on Nov 9, 2012
  1. Applied fix from trunk for revision: 1407634

    Anil Patel authored
    ===
    
    [OFBIZ-5063] Stock Move is not working correctly when reservation record has quantity not available value at bulk location. Thanks Albert Mayo and Amardeep for working on fix. 
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1407663 13f79535-47bb-0310-9956-ffa450edef68
  2. @JacquesLeRoux

    Reverts r1407163 which was introduced for https://issues.apache.org/j…

    JacquesLeRoux authored
    …ira/browse/OFBIZ-3883. I will rather commit John's more cautious patch in branches
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1407631 13f79535-47bb-0310-9956-ffa450edef68
Commits on Nov 8, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1407116"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1407116 | jleroux | 2012-11-08 16:15:04 +0100 (jeu., 08 nov. 2012) | 21 lines
    
    An enhanced patch from John McDonald for "Customer's Shipment Address Not Assigned to Dropship Purchase Orders" https://issues.apache.org/jira/browse/OFBIZ-3883
    
    When buying drop ship products from the demo store the customer's shipping address is not saved with the purchase order, so the shipping address cannot be provided to the drop ship supplier. 
    
    Steps to Reproduce:
    * From the DropShip Category add "DropShip from BigSupplier" and "DropShip from DemoSupplier" to your cart. 
    * Login as admin
    * Use the one page checkout to order the products
    
    Resulting Order: 
    https://demo-trunk.ofbiz.apache.org:8443/ordermgr/control/orderview?orderId=WSCO10002
    The purchase orders WS10003 and WS10004 are associated correctly with the order items, but as the shipping groups don't have addresses, the purchase orders don't have either.
    
    Expectation:
    All Shipment groups should have the shipping address assigned.
    
    Actual:
    Only the first shipment group has the shipping address assigned. 
    
    
    jleroux: thanks to Paul Foxworthy's help I rather removed than deprecate the old methods and replaced them where relevant
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1407163 13f79535-47bb-0310-9956-ffa450edef68
Commits on Nov 7, 2012
  1. a bit too quick on previous commit, forgot that jasper-jdt.jar was re…

    Erwan de Ferrieres authored
    …placed with ecj. Correcting the license and classpath files
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1406826 13f79535-47bb-0310-9956-ffa450edef68
  2. Upgrading to tomcat 6.0.36 following CVE-2012-2733

    Erwan de Ferrieres authored
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1406812 13f79535-47bb-0310-9956-ffa450edef68
  3. @JacquesLeRoux

    "Applied fix from trunk for revision: 1406727"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1406727 | jleroux | 2012-11-07 18:36:07 +0100 (mer., 07 nov. 2012) | 5 lines
    
    A patch from Leon for "slight update to ShoppingCartEvents.loadCartFromQuote to avoid NPE exception" https://issues.apache.org/jira/browse/OFBIZ-5068
    
    There's a quote within that one product has been released and no valid price set. If try to create order from this quote, NPE exception raised.
    
    => Check the result return from runSync("loadCartFromQuote")
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1406751 13f79535-47bb-0310-9956-ffa450edef68
Commits on Oct 29, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1403370 "

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1403370 | jleroux | 2012-10-29 16:33:39 +0100 (lun., 29 oct. 2012) | 5 lines
    
    Thanks to Roberto Benítez Monje's report: "Ofbiz uses a reserved word in a Party View definition" https://issues.apache.org/jira/browse/OFBIZ-5062
    
    Inside the component Part, the view-entity 'PartyIdentificationAndParty' uses the reserved word of MAXDB "PI". Without change it the Party component doesn't work properly   
    
    jleroux: I just changed form PI to PIN and PIM where relevant
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1403419 13f79535-47bb-0310-9956-ffa450edef68
Commits on Oct 20, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1400393"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1400393 | jleroux | 2012-10-20 10:59:40 +0200 (sam., 20 oct. 2012) | 17 lines
    
    A patch from Tom Burns "Error is comming in HR's recruitment  Tab  " https://issues.apache.org/jira/browse/OFBIZ-5056
    
    I am getting an error(null Pointer Exception) in HR module when i am testing some functionallities.
    I followed some steps in my testing.
    Step 1:-Cleck on Recruitment tab and also click on "New job Requisition".Fill the data and create the record.
    Steps 2:-click on sub tap "Internal Job Posting" and then click on "New internal Job Posting" Button on find Internal job posting page. Create the record from require data
    Step3:-Again click "Internal Job Posting" sub tab. and find the created Internal Job Posting record.
    You find operastion give the Error Massage
    :ERROR MESSAGE:
    org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen component://common/widget/CommonScreens.xml#FindScreenDecorator: java.lang.NullPointerException (null)
    You also check Job Interview and Approve sub tab
    I have sent this mail to jacopo Le but Issue is not resolve till date
    Please solve this issuse. I Am waiting for ur responce APAS
    Thanks
    Dhiraj Gupta
    
    
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1400402 13f79535-47bb-0310-9956-ffa450edef68
Commits on Oct 18, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1399761 "

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1399761 | jleroux | 2012-10-18 20:15:38 +0200 (jeu., 18 oct. 2012) | 19 lines
    
    A patch from Tom Burns "Find Inventory Event Planned Displays Error Message" https://issues.apache.org/jira/browse/OFBIZ-5054
    
    In the Manufacturing Manager MRP feature MRP Log displays an error when Find is clicked in the Find Inventory Event Planned screenlet.
    
    To reproduce:
    1. Create a Routing table (details beyond the scope of this note)
    2. Navigate to the Manufacturing MRP feature.
    3. Select Run MPR
    4. Enter an MRP Name and Facility
    5. Click Submit
    6. Select MRP Log Tab
    7. When Status is finished click Find in the Find Inventory Event Planned screenlet.
    
    Expected:
    MRP Plan
    Actual:
    Error message before MRP Plan
    Error on line 159, column 17 in component://manufacturing/webapp/manufacturing/mrp/findInventoryEventPlan.ftl null is undefined. It cannot be assigned to initialQohEvent The problematic instruction: ---------- ==> assignment: initialQohEvent=null [on line 159, column 17 in component://manufacturing/webapp/manufacturing/mrp/findInventoryEventPlan.ftl] ---------- Java backtrace for programmers: ----------
    ...
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1399804 13f79535-47bb-0310-9956-ffa450edef68
Commits on Oct 8, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1395460"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1395460 | jleroux | 2012-10-08 09:26:02 +0200 (lun., 08 oct. 2012) | 10 lines
    
    A patch from Leon "very trivial update to fieldlookup.js in case of "null object" failure for weird unknonw reason" https://issues.apache.org/jira/browse/OFBIZ-4911
    
    I cannot find the root cause and it's hard to reproduce, but it does happen sometimes. The web browser reports "null object" exception when it tries to evaluate following codes in fieldlookup.js: 
    {quote}
    var obj_caller = (window.opener? window.opener.lookups[num_id]: null);
    {quote}
    
    window.opener is there but window.opener.lookups is null.
    
    jleroux: better be safe than sorry, even if it hides the original reason this no functional change can't have any side effects.
    ------------------------------------------------------------------------
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1395488 13f79535-47bb-0310-9956-ffa450edef68
Commits on Oct 6, 2012
  1. @JacquesLeRoux

    A patch from Varun Bhansaly "Email configuration - mail.smtp.starttls…

    JacquesLeRoux authored
    ….enable ignored" https://issues.apache.org/jira/browse/OFBIZ-4943
    
    The email configuration setting mail.smtp.starttls.enable is ignored by the system.
    I encountered this while configuring OFBiz an email server which had TLS enabled.
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1395122 13f79535-47bb-0310-9956-ffa450edef68
  2. @JacquesLeRoux

    "Applied fix from trunk for revision: 1394995"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1394995 | jleroux | 2012-10-06 12:59:12 +0200 (sam., 06 oct. 2012) | 9 lines
    
    A modified patch from  Jyoti Sharma https://issues.apache.org/jira/browse/OFBIZ-5043
    
    When i worked with Url Rewrite Filter, i faced the following issue:-
    In case of http protocol in the url, https links on th epage were not being rewritten and when their was https url, http links were not rewritten.
    
    The issue behind this what i found is that in RequestHandler.java encodeUrl() is not called in the above given case.
    So, if we place response.encodeUrl() their the issue is resolved. 
    
    jleroux: This makes sense since we are still in the "if (encode) {" block. I just noticed that response != null was checked above so I placed the same check before encoding
    ------------------------------------------------------------------------
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1395084 13f79535-47bb-0310-9956-ffa450edef68
Commits on Oct 4, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1393948"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1393948 | jleroux | 2012-10-04 10:07:34 +0200 (jeu., 04 oct. 2012) | 17 lines
    
    A patch from Paul Foxworthy "Recalculate Order causes NumberFormatException" https://issues.apache.org/jira/browse/OFBIZ-5046
    
    On demo site, create a new order by using the URL https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry
    
    Enter any Product ID, e.g. GZ-1000
    Enter a Quantity, e.g. 1
    Click on Add To Order
    
    Now click on Recalculate Order on the title bar of the Create Order screenlet
    Check the logs. On the demo site, you can do this with the URL https://demo-trunk.ofbiz.apache.org/webtools/control/LogView
    
    You will see:
    Exception: java.lang.NumberFormatException Message: For input string: "i18n" ---- stack trace --------------------------------------------------------------- java.lang.NumberFormatException: For input string: "i18n" java.lang.NumberFormatException.forInputString(NumberFormatException.java:48) java.lang.Integer.parseInt(Integer.java:449) java.lang.Integer.parseInt(Integer.java:499) org.ofbiz.order.shoppingcart.ShoppingCartHelper.modifyCart(ShoppingCartHelper.java:673)
    
    The problem is the suffix _i18n on the input elements. The code in modifycart assumes the last thing in the parameter names is a sequence number.
    This problem is not as severe as OFBIZ-5045, because the exception is swallowed immediately and the cart is updated properly. Still, these exceptions slow down OFBiz and add noise to the logs.
    
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1393972 13f79535-47bb-0310-9956-ffa450edef68
Commits on Oct 2, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1392773"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1392773 | sascharodekamp | 2012-10-02 09:43:01 +0200 (mar., 02 oct. 2012) | 1 line
    
    Edit Estimated Ship Date or Estimated Delivery Date brings on date format error (https://issues.apache.org/jira/browse/OFBIZ-5045). A patch from Paul Foxworthy: The patch adds an if statement to ignore members of the isdm and iddm maps with keys that have a suffix of _i18n.
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1393192 13f79535-47bb-0310-9956-ffa450edef68
  2. Bug Fix: No Url encoding for get parameters (https://issues.apache.or…

    Sascha Rodekamp authored
    …g/jira/browse/OFBIZ-2628). Thanks Wojciech Szymanowski for the hint. This Patch fixes the problems with parameters from hidden fields sending with POST method and parameters sending during "request-redirect" response type
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1392767 13f79535-47bb-0310-9956-ffa450edef68
Commits on Sep 27, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1390542"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1390542 | sascharodekamp | 2012-09-26 17:03:23 +0200 (mer., 26 sept. 2012) | 1 line
    
    Bug Fix: No Url encoding for get parameters (https://issues.apache.org/jira/browse/OFBIZ-2628). Thanks Wojciech Szymanowski for the hint. The CatalinaContainer.createConnector() method does not initialize Connector.URIEncoding property from ContainerConfig class. 
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1390845 13f79535-47bb-0310-9956-ffa450edef68
Commits on Sep 22, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1388832"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1388832 | jleroux | 2012-09-22 18:24:26 +0200 (sam., 22 sept. 2012) | 4 lines
    
    A patch from Tom Burns "Pagination Fails in Form ListAgreementTerms " https://issues.apache.org/jira/browse/OFBIZ-5013
    
    As mentionned by Tom, ListAgreementRoles pagination also failed: paginate-target FindAgreementRoles does not exist. I replaced by EditAgreementRoles, works
    
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1388836 13f79535-47bb-0310-9956-ffa450edef68
Commits on Sep 20, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1387884"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1387884 | jleroux | 2012-09-20 09:06:17 +0200 (jeu., 20 sept. 2012) | 6 lines
    
    A patch from Daniel Riquelme " Improve Tree Widget to support Multiple PK Entities" https://issues.apache.org/jira/browse/OFBIZ-4971
    
    The PKs are used to keep track of which nodes have been rendered when performing recursion inside Tree Widget rendering code.
    Currently Multiple PKs Entities can't be used as nodes in a Tree Widget because the rendering code does not handle them.
    
    
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1387887 13f79535-47bb-0310-9956-ffa450edef68
Commits on Sep 17, 2012
  1. @JacquesLeRoux

    No functional changes, this is the backporting of r1167132, r1139858,…

    JacquesLeRoux authored
    … r1299985 and a line from r1059352 for "OfBiz 10.04 Does not compile with Oracle JDK 7" https://issues.apache.org/jira/browse/OFBIZ-4749
    
    Thanks to Karl Laird for report and Paul Foxworthy's + Sergey Derevyanko's help R10.04 now compiles and run (faster) under JDK 7 (hence OPENJDK 7)
    
    jleroux: Since the r1059352 patch does not apply completely, I simply changed the needed line by hand in InvoiceServices.java[104]:
    
        invoicesCreated.add(UtilMisc.toMap("commissionInvoiceId",invoiceId, "salesRepresentative ",partyIdBillFrom));
        + invoicesCreated.add(UtilMisc.<String, String>toMap("commissionInvoiceId",invoiceId, "salesRepresentative ",partyIdBillFrom));
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1386469 13f79535-47bb-0310-9956-ffa450edef68
Commits on Sep 15, 2012
  1. Applied bug fix from trunk revision: 1385014

    Ashish Vijaywargiya authored
    Log:
    Applied bug fix from jira issue - OFBIZ-4972 - NumberFormateException while update order items.
    If order item price or quantity is greater then 999 then update order items service throw NumberFormateException.
    Steps to regenerate:
    Create an order(SO/PO).
    Edit order items, set order price 1000 and update order items.
    Again edit order items and try to update price from (1,000 to 1,002).
    System will throw NPE and if same will perform for quantity then it will throw NumberFormatException on console.
    Thanks Deepak for the contribution.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1385017 13f79535-47bb-0310-9956-ffa450edef68
Something went wrong with that request. Please try again.