Permalink
Commits on Jun 7, 2010
  1. "Update Dojo Libary" (https://issues.apache.org/jira/browse/OFBIZ-3809)…

    … - OFBIZ-3809
    
    Replace Dojo by new version 1.4.3. (from http://download.dojotoolkit.org/release-1.4.3/dojo-release-1.4.3.zip)
    IN dojo dir I removed the useless dojo/src directory and the following files: iframe_history.html, README. I kept all the .swf files
    It adds 2 new dirs : dojo/dijit and dojo/dojox (replace src)
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/dojo1.4@952157 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 7, 2010
Commits on Jun 5, 2010
  1. To replace our current Dojo version (I guess 1.2) with 1.4.

    There are number of syntax changes, hence the branch
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/dojo1.4@951708 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 5, 2010
  2. Improves target-parameter documentation

    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@951672 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 5, 2010
Commits on Jun 4, 2010
  1. Fix incorrect order by output in sql generation, which fixes OFBIZ-3789;

    namely, there was incorrect sql generated when doing a product keyword
    search.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@951553 13f79535-47bb-0310-9956-ffa450edef68
    eigood committed Jun 4, 2010
  2. A patch from Sascha Rodekamp "Duplicate Product, didn't duplicate the…

    … content" (https://issues.apache.org/jira/browse/OFBIZ-3804) - OFBIZ-3804
    
    The Product duplicate function didn't really duplicate the product content, just set a reference to the original content.
    When I now change the content from the duplicated product, the content of the original product is changed to.
    
    So here is a patch that dublicate the content, dataresource and electronic text (if exists), too. The result is a true copy of the original product that can be edit without side effects to the original product.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@951381 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 4, 2010
  3. Fix missing prefix for shipTo and billTo phone numbers.

    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@951251 13f79535-47bb-0310-9956-ffa450edef68
    Anil Patel committed Jun 4, 2010
Commits on Jun 3, 2010
  1. A patch from Willem Janssen "Dutch labels patch" (https://issues.apac…

    …he.org/jira/browse/OFBIZ-3800) - OFBIZ-3800
    
    Adds Dutch translations in various UiLabel files, thanks to Vikas Raikwar for reviewing and checking
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@951124 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 3, 2010
  2. CommonNotAssigned was duplicated

    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@951123 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 3, 2010
  3. A patch from Sascha Rodekamp "Set webside Id in context filter" (http…

    …s://issues.apache.org/jira/browse/OFBIZ-3801) - OFBIZ-3801
    
    Very minor: a better way to write the webSiteId in the Session. 
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@951119 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 3, 2010
  4. Fixed bug where eBay itemId was set as order's externaId instead of t…

    …ransactionId; transactionId was also stored in the order but never used.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@951099 13f79535-47bb-0310-9956-ffa450edef68
    jacopoc committed Jun 3, 2010
  5. Fix "Securing URL's issue in editorderitems.ftl and ordercontactinfo.…

    …ftl" (https://issues.apache.org/jira/browse/OFBIZ-2514) - OFBIZ-2514
    
    I did not find any other remaining errors
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@951098 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 3, 2010
  6. Explicitly added the hidden-form link-type instead of relying on link…

    …-type auto. The auto link-type only works with intra-app and not with inter-app target-type.
    
    The other option would be to change the method WidgetWorker.determineAutoLinkType() to allow inter-app target-type so that the method can
    
    determine whether to change the hyperlink to a form or an anchor to avoid secured URL issue.
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@951087 13f79535-47bb-0310-9956-ffa450edef68
    Vikas Mayur committed Jun 3, 2010
  7. Associate to the correct geo; DE=Delaware, in the United States. A full

    clean detected this error, as GeoData_US.xml wasn't imported yet, so I
    got an exception when DE didn't exist.  The patch in OFBIZ-3800 was
    *not* correct, and was not verified.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@951062 13f79535-47bb-0310-9956-ffa450edef68
    eigood committed Jun 3, 2010
  8. A patch from Sascha Rodekamp "Improving the Supplier Product Screen" (h…

    …ttps://issues.apache.org/jira/browse/OFBIZ-3802) - OFBIZ-3802
    
    Move the supplier data detection to the Product Form and changes a few fields for a better overview. Just an improvement in data presentation, notably sorting columns
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@951013 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 3, 2010
  9. A patch from Sascha Rodekamp "Edit Category FTL ProductCategory Type …

    …Select " (https://issues.apache.org/jira/browse/OFBIZ-3794) - OFBIZ-3794
    
    A patch regarding the Category Rollup. This patch affects the edit Category Button Description. Before it was the Category Description if exits now it's a little bit more differentiated. The Category Name should displayed if exists and if not the Category Description
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@951007 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 3, 2010
  10. Oops, looks like I forgot this file in trunk at r950866, R10.04 at r9…

    …50867, R9.04 at r950868 (related to OFBIZ-3782)
    
    Bother :/
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@951005 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 3, 2010
  11. Added payment lookup specific to Account Receivable and Account Payab…

    …le application. This fix a bug with the payment types that was showing up wrong values in the lookup screen used before.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950986 13f79535-47bb-0310-9956-ffa450edef68
    Vikas Mayur committed Jun 3, 2010
  12. Added invoice lookup specific to Account Receivable and Account Payab…

    …le application. This fix a bug with the status and invoice type
    
    that was showing up wrong values in the lookup screen used before.
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950936 13f79535-47bb-0310-9956-ffa450edef68
    Vikas Mayur committed Jun 3, 2010
  13. A patch from Bob Morley "Support for order by nulls first/last " (htt…

    …ps://issues.apache.org/jira/browse/OFBIZ-3740) - OFBIZ-3740
    
    This patch provides the fundamentals to resolve an issue where the sorting of null values were inconsistent (sometimes sorting first and other times sorting last). Specifically, this patch allows one to create an order-by clause via any of the order-by elements of "-myField NULLS LAST" where this text parses out the - (as descending) and the "nulls last".
    
    Since not all databases support the "nulls" argument on an order by clause (it was introduced as part of the OLAP support specification) , our entity-engine.xml file allows each data source to indicate if it has this support. If the support does not exist and nulls first/last is specified, the sql that is generated uses native sql to simulate the nulls first/last intent. At this time, the derby, postgres, and oracle databases are marked to use the nulls first grammar.
    
    Right now, if you do not specify "NULLS XXX" in the field-name for the order-by it makes no change whatsever (naturally this assumption could be changed to have a default).
    
    It should be noted, that my intent here was ultimately to "properly" model the order by into something whose xml representation could look something like ...
    <entity-order-by field-name="fieldName" ascending="true" nulls-first="true" />
    
    Divesh Dutta added a comment - 07/May/10 01:44 AM HI Bob, This patch works as expected for derby, postgres, and oracle databases as you have already mentioned. Cant we have some generic solution which supports all the databases. Or we can have some conditional code, where we can check which datasource is being used, and then generate the sql accordingly. Please let me know your views on this.
    
    Bob Morley added a comment - 07/May/10 08:07 AM
    Hi Divesh,
    I added a more detailed description in the forum thread; but in brief this is a generic solution which supports all databases which generates the sql accordingly. What this patch does not do is apply a standard default order for all databases; it just adds support for one to dictate how they want the nulls sorted.
    For example, when one sets the order-by they can set it to "lastName DESC NULLS FIRST" which should apply to all databases.
    
    
    The thread Bob was referring above ends at http://markmail.org/message/47z7fwtawehuem6b
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950901 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 3, 2010
  14. A patch from Atul Vani for an issue reported by R.S."States of th cou…

    …ntry Germany shows zero results from both webtools and using services." (https://issues.apache.org/jira/browse/OFBIZ-3799) - OFBIZ-3799
    
    Data to associate the country with states isn't present. This issue is with reference to discussion started by R.S. on user-mailing list subjected as "StateList"
    R.S., thanks for reporting the issue.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950893 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 3, 2010
  15. Applied a slightly modified patch provided by Surya Kusumakar on jira…

    … issue OFBIZ-3337 (https://issues.apache.org/jira/browse/OFBIZ-3337)
    
    This fixed a bug with inactive financial account(s) which does show up while creating a new payment or creating a batch of payments.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950892 13f79535-47bb-0310-9956-ffa450edef68
    Vikas Mayur committed Jun 3, 2010
  16. A patch from Eric De Maulde 'Config price context doesn't refer to a …

    …product store id / product store group id' https://issues.apache.org/jira/browse/OFBIZ-3770 - OFBIZ-3770
    
    For AGGREGATED product, the service "calculateProductPrice" doesn't refer to a product store, in order to select the right registered product price between different productStoreGroupId.
    This patch add productStoreId to the price context in order to select the right registered product price
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950870 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 3, 2010
  17. A patch from Sumit Pandit "Issue in rendering Freemarker Template fro…

    …m String." (https://issues.apache.org/jira/browse/OFBIZ-3782) - OFBIZ-3782
    
    With the help of Bob Morley (it was more a cache issue than what Sumit thought)
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950866 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 3, 2010
  18. A patch from Sascha Rodekamp "Edit Category FTL ProductCategory Type …

    …Select " (https://issues.apache.org/jira/browse/OFBIZ-3794) - OFBIZ-3794
    
    In the Drop Down field is always the Key Catalog_Category selected. This Patch change the behavior and select a default product Category Type Id 
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950864 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 3, 2010
  19. A patch from Sascha Rodekamp "Entity ProdCatalogCategoryType Parent R…

    …elation" (https://issues.apache.org/jira/browse/OFBIZ-3793) - OFBIZ-3793
    
    The ProdCatalogCategoryType didn't have a parent Relation. Here is a fix that added a parentTypeId field and the relation definition
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950861 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 3, 2010
  20. Fix a bug introduced at r950481

    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950860 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jun 3, 2010
Commits on Jun 2, 2010
  1. Use the new isEmpty support in conditions to skip

    EntityConditionListBase entries that have no children.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950767 13f79535-47bb-0310-9956-ffa450edef68
    eigood committed Jun 2, 2010
  2. EntityCondition.isEmpty() support.

    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950766 13f79535-47bb-0310-9956-ffa450edef68
    eigood committed Jun 2, 2010
  3. Refactor the 2 arg version of the addSqlValue method, to use the List

    version.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950765 13f79535-47bb-0310-9956-ffa450edef68
    eigood committed Jun 2, 2010
  4. Add a new marker interface, IsEmpty.

    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950764 13f79535-47bb-0310-9956-ffa450edef68
    eigood committed Jun 2, 2010
  5. Adding missing French entityLabels

    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950754 13f79535-47bb-0310-9956-ffa450edef68
    Erwan de Ferrieres committed Jun 2, 2010
  6. Using the right description for the sent field

    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950753 13f79535-47bb-0310-9956-ffa450edef68
    Erwan de Ferrieres committed Jun 2, 2010
  7. Fixed an issue with menu item not coming as selected upon selection. …

    …Also moved redundant declaration of the headerItem variable in independent
    
    screens to just the screen decorator.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950719 13f79535-47bb-0310-9956-ffa450edef68
    Vikas Mayur committed Jun 2, 2010
  8. Replaced

    <if-has-permission permission="WORKEFFORTMGR" action="_VIEW"/>
    with
    <if-service-permission service-name="workEffortManagerPermission" main-action="VIEW"/>
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950692 13f79535-47bb-0310-9956-ffa450edef68
    Vikas Mayur committed Jun 2, 2010