Permalink
Commits on Dec 11, 2010
  1. A patch from Dukian (actually done by hand was easier, got an UTF8 is…

    JacquesLeRoux committed Dec 11, 2010
    …sue)
    
    There are many different i18n file naming approaches for language.country couple. For Traditional Chinese ... OFBiz uses java way: zh_TW, datepicker uses zh-TW, and el-rte needs this patch. It uses actually zh_tw, see the full version line 1108:
    
    Dukian will file this issue to el-rte project too.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/jquery@1044611 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 10, 2010
  1. Make FreeMarkerWorker.getWrappedObject auto-cast to whatever type the

    eigood committed Dec 10, 2010
    caller wants.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044232 13f79535-47bb-0310-9956-ffa450edef68
  2. Deprecate the local getArg/getWrappedObject wrappers in all transforms.

    eigood committed Dec 10, 2010
    Several ftl transforms had local methods, to that wrapped the same named
    method in FreeMarkerWorker.  Near as I can tell, this was to reduce
    local typing, by not having to always type FreeMarkerWorker.  Having
    these local methods increases the permgen memory use(by increasing the
    size of the bytecode).  Also, it makes it more difficult to
    cross-reference; when the getArg method is seen by a developer, is it a
    local method, or a static import?  Using the fully qualified variant
    makes it easier to understand what is going on.
    
    The replacement is to use the fully qualified versions in
    FreeMarkerWorker.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044231 13f79535-47bb-0310-9956-ffa450edef68
  3. Move variable declarations until they are actually used, instead of

    eigood committed Dec 10, 2010
    assigning null, then force-reassigning the real value later.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044230 13f79535-47bb-0310-9956-ffa450edef68
  4. Remove unnecessary cast when fetching the compiled template from the

    eigood committed Dec 10, 2010
    UtilCache cache.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044229 13f79535-47bb-0310-9956-ffa450edef68
  5. Fix some spacing issues, no code changes.

    eigood committed Dec 10, 2010
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044228 13f79535-47bb-0310-9956-ffa450edef68
  6. Remove some trailing whitespace from lines; only doing files that will

    eigood committed Dec 10, 2010
    be modified by soon to be committed changesets.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044227 13f79535-47bb-0310-9956-ffa450edef68
  7. Fix several final newline problems, in files I will be changing in the

    eigood committed Dec 10, 2010
    near future.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044226 13f79535-47bb-0310-9956-ffa450edef68
  8. Set svn:eol-style properly on all java files. This needs to be done o…

    eigood committed Dec 10, 2010
    …n other text files as well, but that would cause undo conflicts in the jquery branch(due to .js being heavily modified there). Also, some files were committed to the repository with DOS line endings; those are fixed as well.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044202 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 9, 2010
  1. Closing OFBIZ-4051 i18n for elrte editor - this will add the included…

    Erwan de Ferrieres
    Erwan de Ferrieres committed Dec 9, 2010
    … translation in the erlte project to be used. Thanks Jacques and Sascha
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/jquery@1044132 13f79535-47bb-0310-9956-ffa450edef68
  2. Fix a typo (double ,)

    JacquesLeRoux committed Dec 9, 2010
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044084 13f79535-47bb-0310-9956-ffa450edef68
  3. Fix a small rendering issue:

    JacquesLeRoux committed Dec 9, 2010
    When you updated personal information of a lead, if this lead was assigned, in the status dropdown you saw LEAD_ASSIGNED. I have changed to show correct information (also possible i18n)
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044082 13f79535-47bb-0310-9956-ffa450edef68
  4. Deactivates temporarily the online help. It's currently not working a…

    JacquesLeRoux committed Dec 9, 2010
    …nd slowing down too much the demo server
    
    I forgot those ones in previous commit (to find all : showHelp in *.ftl,*.xml)
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044062 13f79535-47bb-0310-9956-ffa450edef68
  5. Deactivates temporarily the online help. It's currently not working a…

    JacquesLeRoux committed Dec 9, 2010
    …nd slowing down too much the demo server
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044053 13f79535-47bb-0310-9956-ffa450edef68
  6. Oops. Remove FIXME keywords, which were used by me as a reminder to fix

    eigood committed Dec 9, 2010
    the lines properly, while I was in the process of deprecating other
    delegator methods.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044047 13f79535-47bb-0310-9956-ffa450edef68
  7. Yet another bad bug. The name/value pair was never actually turned into

    eigood committed Dec 9, 2010
    a map.  findByAnd(entityName, field, value, list) was never a valid
    call.  However, this code still compiled, as it ended up using the
    vararg variant of findByAnd.  If this code had ever been run, then it
    would have blown up.
    
    broken since: 984366, initial commit
    date: Wed Aug 11 10:39:10 2010 +0000
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1043999 13f79535-47bb-0310-9956-ffa450edef68
  8. When thte findByAnd->findList change was done, the parameters to the new

    eigood committed Dec 9, 2010
    findList method were added, but the actual method name itself was not
    changed.  However, since there was a vararg version of
    findByAnd(Object...), this meant the code actually compiled anyways, so
    the problem was not detected.
    
    broken since: 654934
    date: Fri May 9 20:57:23 2008 +0000
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1043998 13f79535-47bb-0310-9956-ffa450edef68
  9. Bother; this code was never ever run. The findByAnd variant it ended up

    eigood committed Dec 9, 2010
    using was the Object... version.  In essence, creating a new Object[]
    {map, null, String}, and then trying to convert that whole thing to a
    map(which would have failed).
    
    broken since: 745407, initial checkin
    date: Wed Feb 18 08:04:48 2009 +0000
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1043997 13f79535-47bb-0310-9956-ffa450edef68
  10. In the persistRootCompDoc event, the loop over the results from service

    eigood committed Dec 9, 2010
    persistContentRevisionAndItem was fetching values from the previous
    iteration over the persistContentAndAssoc service.
    
    broken since: http://svn.ofbiz.org/svn/ofbiz/trunk@6770, initial checkin
    date: Fri Feb 17 22:14:40 2006 +0000
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1043996 13f79535-47bb-0310-9956-ffa450edef68
  11. Following Erwan's advice at "i18n for elrte editor" https://issues.ap…

    JacquesLeRoux committed Dec 9, 2010
    …ache.org/jira/browse/OFBIZ-4051 this commit adds the elrte editor i18n files
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/jquery@1043949 13f79535-47bb-0310-9956-ffa450edef68
  12. Improved error handling for the production run declaration screen; th…

    jacopoc committed Dec 9, 2010
    …is fixes a bug where, if matarials were missing, the production run declaration screen was hiding the error message and the header fields in the screen were emptied.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1043899 13f79535-47bb-0310-9956-ffa450edef68
  13. A patch from Sascha Rodekamp "We need to replace all references to wh…

    JacquesLeRoux committed Dec 9, 2010
    …izzywig.js" (https://issues.apache.org/jira/browse/OFBIZ-4030) - OFBIZ-4030
    
    We had still some references to whizzywig in *.ftl, *.java files. We use now only elrte Editor and removed whizzywig.js
    
    Note that this patch fix a bug which is still in trunk, I don't care about trunk since we will merge soon. But I have opened a new issue for R10.04 at https://issues.apache.org/jira/browse/OFBIZ-4050
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/jquery@1043874 13f79535-47bb-0310-9956-ffa450edef68
  14. A patch from Atul Vani "There are issues with search in eCommerce" (h…

    JacquesLeRoux committed Dec 9, 2010
    …ttps://issues.apache.org/jira/browse/OFBIZ-4032) - OFBIZ-4032
    
    This patch was created for OFBIZ-3789 but worked for me as well on this issues
    
    Try gz-1000 or "gift card" and follow Atul's comment below. I guess it's also an issue for R10.04 (I did not try) R9.04 seems OK. Note that I got no problems with Derby, only with Postgres.
    
    Try searching 'gift card' from http://localhost:8080/ecommerce/control/advancedsearch and using some other value for 'Sorted by' instead of 'Keyword Relevancy'.
    
    The first time i observed this issue KeywordSort was not working for search keyword 'gift' (the console log suggested that SELECT got no 'totalRelevancy' column but the GROUPBY has it in the query) although the KeywordSort was working well for 'gift card'. 
    
    All other sorting methods from http://localhost:8080/ecommerce/control/advancedsearch were working for 'gift' but not 'gift card'.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1043861 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 8, 2010
  1. OFBIZ-4046: Adding chapter on Datafiles to docbooks. Contribution by …

    hansbak committed Dec 8, 2010
    …BJ Freeman
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1043266 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 7, 2010
  1. Adding new User Security Group so if needed we can only assign work e…

    Ashish Vijaywargiya
    Ashish Vijaywargiya committed Dec 7, 2010
    …ffort component to any user.
    
    Thanks Amit for the contribution.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1042953 13f79535-47bb-0310-9956-ffa450edef68
  2. Bug fix. The workeffort group WORKEFFORT_USER was not associated with…

    Ashish Vijaywargiya
    Ashish Vijaywargiya committed Dec 7, 2010
    … WORKEFFORTMGR_VIEW so if you assign this group to any user then you can see or login into workeffort application. This is similar pattern that exists in accounting, partymgr & accounting component.
    
    Thanks Amit.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1042950 13f79535-47bb-0310-9956-ffa450edef68
  3. Fixed NPE in tax calculation when no ProducePrice record matches the …

    jonesde committed Dec 7, 2010
    …tax calc constraints
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1042884 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 6, 2010
  1. Small fix so that the new VAT_TAX adjustments are removed when updati…

    jonesde committed Dec 6, 2010
    …ng an order through the ShoppingCart
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1042834 13f79535-47bb-0310-9956-ffa450edef68
  2. implemented option to specific a specific entity should NOT be checke…

    andrewzeneski committed Dec 6, 2010
    …d; no columns are to be updated and ignore any warning about fields, relations, keys, etc. This is useful when an entity is defined based on a database view; the view may not (or probably will not) appear in the table meta data and any attempt to auto-create the entity will (or should) fail.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1042792 13f79535-47bb-0310-9956-ffa450edef68
  3. Implemented alternative way of saving ProductPrices with tax included…

    jonesde committed Dec 6, 2010
    … in the price, and then calculating VAT tax as an exclusive instead of inclusive amount that goes on a new field on OrderAdjustment; also added a method to OrderReadHelper to get tax for display; there are various changes to service descriptions and entity fields to describe these changes
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1042542 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 5, 2010
  1. A patch from Anne Jessel "Wrong product displayed as associated produ…

    JacquesLeRoux committed Dec 5, 2010
    …ct" (https://issues.apache.org/jira/browse/OFBIZ-4023) - OFBIZ-4023
    
    To reproduce:
        * add two associated products to a main product, both with "Complementary or Cross-Sell" association type
        * view the main product in ecommerce
    
    Expected behaviour: the two associated products are listed near the bottom of the page
    Actual behaviour: two products are listed at the bottom of the page, but only one of them is an associated product. The other is the main product.
    The problem is caused by the value of a freemarker variable changing at a point where other freemarker code assumes the variable does not change. The execution path is complicated.
    The patch fixes the problem by saving the value of the key variable into another variable, and restoring it later. However I do wonder if there is a better solution.
    
    JLR: I did not try to find a better solution
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1042411 13f79535-47bb-0310-9956-ffa450edef68
  2. A patch from Anne Jessel "Is Empty for text-find widget broken" (http…

    JacquesLeRoux committed Dec 5, 2010
    …s://issues.apache.org/jira/browse/OFBIZ-4025) - OFBIZ-4025
    
    To reproduce:
        * go to Facility, Inventory Items tab (or any form that uses text-find widget)
        * choose "Is Empty" from drop-down next to Product Id
        * click Find button
    
    Expected behaviour: no matching items listed, as all items have a Product Id.
    Observed behaviour: all items match.
    
    Problem is caused by find code assuming that there is no entity condition to be created if the text field is empty, but of course Is Empty is
    different to the other operators in that the text field is expected to be empty.
    
    The attached patch adds a special check for the Is Empty operator.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1042396 13f79535-47bb-0310-9956-ffa450edef68