Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Nov 14, 2013
  1. @JacquesLeRoux

    As discusses on dev ML, changes Eclipse project names for all release…

    JacquesLeRoux authored
    …s branches following this schema: ofbiz-release13.07
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1541895 13f79535-47bb-0310-9956-ffa450edef68
Commits on Aug 5, 2012
  1. @JacquesLeRoux

    Revert r1057532. It was an automatic merge I did. There was an error …

    JacquesLeRoux authored
    …and I have not enough time to do it properly by hand
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1369592 13f79535-47bb-0310-9956-ffa450edef68
Commits on May 20, 2012
  1. @JacquesLeRoux
Commits on May 19, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1340352 "

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1340352 | jleroux | 2012-05-19 08:39:24 +0200 (sam., 19 mai 2012) | 7 lines
    
    A patch from Leon for "Exception there when trying to update order's "Shipping Destination Address"" https://issues.apache.org/jira/browse/OFBIZ-4865
    
    If click the "update" button of "Shipping Destination Address" in order view page, an exception thrown out as:
        The Following Errors Occurred:
        BeanShell execution caused an error: Sourced file: inline evaluation of: `` shipmentMethod = parameters.get("shipmentMethod"); if(s . . . ''
    
    I searched the log and find the root cause is "java.lang.ArrayIndexOutOfBoundsException" from bsh script. As Paul told, there should be at least two "@" chars in "shipmentmethod" value. So I guess maybe somewhere "@" is missing. I tried to lookup for codes which construct parameters map for calling, and fortunately, I found it.
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1340353 13f79535-47bb-0310-9956-ffa450edef68
Commits on Mar 22, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1303714"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1303714 | jleroux | 2012-03-22 11:25:31 +0100 (jeu., 22 mars 2012) | 1 line
    
    Avoids to show CC payment information in log when in verbose mode
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1303717 13f79535-47bb-0310-9956-ffa450edef68
Commits on Feb 27, 2012
  1. @JacquesLeRoux

    A patch from Chatree Srichart "OrderListState needs to be Serializabl…

    JacquesLeRoux authored
    …e for clustering" https://issues.apache.org/jira/browse/OFBIZ-4660
    
    OrderListState is to be set to session, so it needs to be Serializable for clustering.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1294095 13f79535-47bb-0310-9956-ffa450edef68
Commits on Feb 25, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1293557"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1293557 | jleroux | 2012-02-25 10:30:35 +0100 (sam., 25 févr. 2012) | 3 lines
    
    A patch from Nicolas Malin "Label not loading on entityext components" https://issues.apache.org/jira/browse/OFBIZ-4717
    
    The configuration directory config isn't loaded on the entityext's ofbiz-component.xml file.
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1293560 13f79535-47bb-0310-9956-ffa450edef68
Commits on Feb 21, 2012
  1. @jacopoc

    Extended thru date for demo/test data about fiscal time period to avo…

    jacopoc authored
    …id issues with tests on GL postings.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1291780 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jan 17, 2012
  1. @JacquesLeRoux

    A patch from Kiran Gawde "cardType is not prepopulated on checkout pa…

    JacquesLeRoux authored
    …ge" https://issues.apache.org/jira/browse/OFBIZ-4665
    
    On Checkout page, credit card information is prepopulated based upon earlier order. But the card Type shows always the first type in the list.
    
    jleroux: replaced tabs by 4 spaces, merge done by hand handling conflicts
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1232542 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jan 14, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1231444"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1231444 | jleroux | 2012-01-14 08:31:15 +0100 (sam., 14 janv. 2012) | 11 lines
    
    A patch from Ankit Jain https://issues.apache.org/jira/browse/OFBIZ-OFBIZ-4629 "The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED."
    
    Ankit 1st provided another patch,I asked:
    
    jleroux: It seems to me that this is already done in methods PackingSessionLine.issueItemToShipment, and VerifyPickSessionRow.issueItemToShipment, which makes sense to me, thought I did only a 5 mins review, so I could be wrong, could you please check?
    
    Ankit: Yes I found the method VerifyPickSessionRow.issueItemToShipment which is doing the same thing.
    
    I found a bug too and also the reason for it, actually when you verify an order by passing "PicklistBinId" then it updates the status of picklistitems, but if we verify an order by passing a orderId then the status of the picklistitem never changes to Complete.
    
    The reason is that when we pass orderId the "picklistBinId" is not get set in the verifyPickSession so its not available at the time "issueItemToShipment" is called so its not changing the status to complete.
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1231449 13f79535-47bb-0310-9956-ffa450edef68
Commits on Jan 1, 2012
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1226223" (tree conflict handled…

    JacquesLeRoux authored
    … by hand: no UtilIO.java)
    
    ------------------------------------------------------------------------
    r1226223 | jleroux | 2012-01-01 10:57:50 +0100 (dim., 01 janv. 2012) | 9 lines
    
    A patch from Martin Kreidenweis "Deserialization of arrays with UtilObject.getObject() throws ClassNotFoundException" https://issues.apache.org/jira/browse/OFBIZ-4295
    
    Deserialization of arrays with UtilObject.getObject() throws a ClassNotFoundException. This happened to us when we enabled the distributed cache clear feature and it was sending arrays of EntityExpr objects to other OFBiz instances.
    
    The reason is, that the org.ofbiz.base.util.ObjectInputStream calls classLoader.loadClass(name) directly instead of using Class.forName(name, init, classLoader).
    According to java bug http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6446627 ClassLoader.loadClass() is not intended to being used this way and doesn't support loading arrays.
    
    jleroux: Sun/Oracle is pretty clear about that <<[When you want to reflectively load a class by name initiated using a specific class loader, you should not invoke that loader's public loadClass method directly-- instead, you should always use the static three-argument Class.forName method.  The ClassLoader.loadClass instance method is more intended for delegation from one class loader to another within a class loading operation (although this is a common confusion and not well described in the documentation).  In other words, replace L.loadClass(N) with Class.forName(N,false,L).  The Class.forName invocation may eventually end up invoking loadClass on the specified loader, but only after taking care of some other aspects of the VM's standard symbolic class name resolution process-- the significant bit in this case being the support for loading/creation of array classes.]>> More at the link above
    
    ------------------------------------------------------------------------
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1226228 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 31, 2011
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1226065"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1226065 | jleroux | 2011-12-31 12:37:23 +0100 (sam., 31 déc. 2011) | 3 lines
    
    This completes "Null values are not synchronized in http mode" https://issues.apache.org/jira/browse/OFBIZ-4602
    
    And I better understand Patrick's answer to the issue now...
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1226066 13f79535-47bb-0310-9956-ffa450edef68
  2. @JacquesLeRoux

    "Applied fix from trunk for revision: 1226055 "

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1226055 | jleroux | 2011-12-31 11:13:34 +0100 (sam., 31 déc. 2011) | 9 lines
    
    Should close "Null values are not synchronized in http mode" https://issues.apache.org/jira/browse/OFBIZ-4602
    
    I followed Adrian's advice. I tried to create an order with a dropship1 item (like in Jira 4637) and it worked perfectly. I guess, as we were suspecting, using 
      set(name, "");
    instead of
      element.setAttribute(name, "null");
    had side effects. 
    
    Anyway, as Adrian pointed out, the right returned string should be "[null-field]" and it's now correct/consistent. On the other side (entity sync clients), of course, now "[null-field]" should be handled instead of "" or "null"
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1226057 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 29, 2011
  1. @JacquesLeRoux

    This reverts r1222242 and should fix "Can not create drop shipment or…

    JacquesLeRoux authored
    …der" https://issues.apache.org/jira/browse/OFBIZ-4637 reported by Sergei Biletnikov and confirmed by mz4wheeler
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1225510 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 22, 2011
  1. @JacquesLeRoux

    A modified patch from Patrick Antivackis "Null values are not synchro…

    JacquesLeRoux authored
    …nized in http mode" https://issues.apache.org/jira/browse/OFBIZ-4602
    
    In order to send over http the values to create, store and remove, Ofbiz is Xml serializing the values. GenericValue xml serialization is managed in GenericEntity.makeXmlElement, unfortunately this method just don't serialized null valued fields.
    To solve this issue, I managed null value the same way GenericEntity.setString (which is used for the Xml deserializing). I only managed until case 10, because i'm not sure the setString for the cases 11 to 15 are well managed (not taking care of null value) 
    
    jleroux: After looking at GenericEntity.setString and initial commit (http://svn.ofbiz.org/viewcvs?rev=7779&view=rev) I see no reasons to not handling cases under 10 the same way. So I added these cases as well using fall through.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1222242 13f79535-47bb-0310-9956-ffa450edef68
  2. @JacquesLeRoux

    "Applied fix from trunk for revision: 1222105 "

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1222105 | jleroux | 2011-12-22 10:06:18 +0100 (jeu., 22 déc. 2011) | 7 lines
    
    A slightly modified patch from Patrick Antivackis "Entity synchronization is skipping values to create, store and remove" https://issues.apache.org/jira/browse/OFBIZ-4601
    
    assembleValuesTocreate, assembleValuesToStore and assembleKeysToRemove are called multiple times during a synchronization (depending on the syncSplitMillis and the time period to synchronized). There is in theses methods a check to see if at the next call, the method needs to look for values. This check depends only on entity without values at the current run, which is not enough
    
    Solving issue described and fixing the assembleKeysToRemove that was using nextUpdateTxTime instead of nextRemoveTxTime
    
    jleroux: functional changes from patch, only formatting
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1222109 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 21, 2011
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1221913 "

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1221913 | jleroux | 2011-12-21 23:24:58 +0100 (mer., 21 déc. 2011) | 3 lines
    
    A patch from Leila Mekika "Use-when not working on multi-forms submit button" https://issues.apache.org/jira/browse/OFBIZ-4605
    
    The submit button of a form multi is rendered even if we add a use-when condition
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1221917 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 16, 2011
  1. @jacopoc

    Backported from rev. 1215142: Added missing property needed to succes…

    jacopoc authored
    …sfully run test cases in platforms with locales different from en.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1215151 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 14, 2011
  1. @jacopoc
  2. @jacopoc

    Backported from rev. 1214334: Patch from Dan Dodd (OFBIZ-2564) to fix…

    jacopoc authored
    … Double/BigDecimal issue in receiving of hhfacility
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1214344 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 13, 2011
  1. @jacopoc

    Backported from rev. 1035121 (fix by Hans Bakker): removed hardcoded …

    jacopoc authored
    …reference to "Company" (OFBIZ-4152)
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1213633 13f79535-47bb-0310-9956-ffa450edef68
  2. @jacopoc

    Backported from rev. 955882 (by Scott Gray): Unnamed events in contro…

    jacopoc authored
    …ller processor maps silently override each other (OFBIZ-3961)
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1213627 13f79535-47bb-0310-9956-ffa450edef68
  3. @jacopoc

    Backported from rev. 1213609: Added missing controller entry required…

    jacopoc authored
    … by WorkEffort-->Communications; thanks to Torstein Hegbom for the bug report (OFBIZ-2870)
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1213613 13f79535-47bb-0310-9956-ffa450edef68
  4. @jacopoc

    Backported rev. 917792: patch from OFBIZ-3514 by Ean Schuessler: When…

    jacopoc authored
    … doing a vendor return we should use the fromPartyId instead of the toPartyId as the company in the company header
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1213596 13f79535-47bb-0310-9956-ffa450edef68
  5. @jacopoc

    Backported rev. 917790: patch from OFBIZ-3513 by Ean Schuessler: remo…

    jacopoc authored
    …ved hardcoded "Company" and used general.properties instead
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1213595 13f79535-47bb-0310-9956-ffa450edef68
  6. @jacopoc
  7. @jacopoc

    Backported rev. 836279 to fix pagination and unconstrained searches o…

    jacopoc authored
    …f shipments; this also fixes OFBIZ-3002
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1213578 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 12, 2011
  1. @jacopoc

    Added entry for contact mechs lookups (required by the workeffort->co…

    jacopoc authored
    …mmunications screen) Also backported from rev. 1213369: Added missing entry for "contact list" lookup required by WorkEffort-->Communications (OFBIZ-2869)
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1213373 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 8, 2011
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1212147"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1212147 | jleroux | 2011-12-08 22:56:02 +0100 (jeu., 08 déc. 2011) | 10 lines
    
    A patch from Martin Kreidenweis https://issues.apache.org/jira/browse/OFBIZ-4451
    
    Warning in log when using @renderSubContentCache freemarker macro
    
    When using the @renderSubContentCache freemarker macro, warnings like this appear in the log:
    
    [      GenericEntity.java:314:WARN ] The field name (or key) [caContentAssocTypeId] is not valid for entity [ContentDataResourceView], printing IllegalArgumentException instead of throwing it because Map interface specification does not allow throwing that exception.
    
    Patch: GenericValue.get() will actually not throw an exception but instead log a warning if the field doesn't exist, so now we first check if the field we are trying to access exists.
    Checking one of the fields through the ModelEntity should be enough, as all three of them come from the same entity.
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1212152 13f79535-47bb-0310-9956-ffa450edef68
Commits on Dec 3, 2011
  1. @JacquesLeRoux
  2. @JacquesLeRoux

    "Applied fix from trunk for revision: 1063228"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1063228 | jleroux | 2011-01-25 12:25:23 +0100 (mar., 25 janv. 2011) | 1 line
    
    As discussed on dev ML, by default comment out Beanshell and Groovy containers for security reasons
    ------------------------------------------------------------------------
    This is not a bugfix, but I need it on Apache OFBiz demo server in order to simplify security handling there
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1209921 13f79535-47bb-0310-9956-ffa450edef68
Commits on Nov 26, 2011
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1206507"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1206507 | jleroux | 2011-11-26 18:38:56 +0100 (sam., 26 nov. 2011) | 7 lines
    
    A patch from Paul Foxworthy "loadSalesInvoiceFact should be post-run" https://issues.apache.org/jira/browse/OFBIZ-4582
    
    See thread at http://ofbiz.135035.n4.nabble.com/Should-loadSalesInvoiceFact-be-run-on-return-instead-of-commit-td3896289.html
    
    The loadSalesInvoiceFact service in applications/accounting/servicedef/secas_olap.xml is set to run asynchronously on (that is, before) a commit. The result is that the service may attempt to read an order that has not yet been committed.
    
    In the patch, the timing has been changed to global-commit-post-run to ensure the order has been committed.
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1206510 13f79535-47bb-0310-9956-ffa450edef68
Commits on Nov 17, 2011
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1203350"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1203350 | jleroux | 2011-11-17 21:17:15 +0100 (jeu., 17 nov. 2011) | 3 lines
    
    A patch from Kiran Gawde https://issues.apache.org/jira/browse/OFBIZ-4568 "CommonUpdatingData is missing from CommonUiLabels"
    
    When you try to update the address from eCommerce application (Profile->ManageAddress->Edit). It shows CommonUpdatingData at the top. 
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1203360 13f79535-47bb-0310-9956-ffa450edef68
Commits on Nov 12, 2011
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1201125"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1201125 | jleroux | 2011-11-12 01:42:00 +0100 (sam., 12 nov. 2011) | 3 lines
    
    A patch from  Pierre Smits https://issues.apache.org/jira/browse/OFBIZ-4466 "Chart of accounts isn't sorted properly"
    
    When adding a new GL account it always displayed as the last entry, even if it has a lower ID
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1201128 13f79535-47bb-0310-9956-ffa450edef68
Commits on Oct 25, 2011
  1. @JacquesLeRoux

    "Applied fix from trunk for revision: 1188564"

    JacquesLeRoux authored
    ------------------------------------------------------------------------
    r1188564 | jleroux | 2011-10-25 10:33:24 +0200 (mar., 25 oct. 2011) | 3 lines
    
    A patch from Kiran Gawde "originalFacilityId is not populated in order" https://issues.apache.org/jira/browse/OFBIZ-4499
    
    Order gets the facilityId from shopping cart. But facilityId is never set in shopping cart.
    ------------------------------------------------------------------------
    ?\026
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release09.04@1188572 13f79535-47bb-0310-9956-ffa450edef68
Something went wrong with that request. Please try again.