Permalink
Commits on Jan 27, 2017
  1. No functional change, we no longer need this script

    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780493 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 27, 2017
Commits on Jan 25, 2017
  1. Fixed: Update Apache Solr/Lucene to release 6.2.1

    (OFBIZ-8316)
    
    Change LongPoint and DoublePoint fields to String field to make solr work in trunk version, and I'll change them back when updating to new release of Solr.
    
    Thanks: Jacques Le Roux for reporting the point fields problem.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780133 13f79535-47bb-0310-9956-ffa450edef68
    shijh committed Jan 25, 2017
Commits on Jan 23, 2017
  1. No functional change, I could be wrong but I see no reasons to have a…

    …n empty
    
    action here
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1779934 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 23, 2017
Commits on Jan 21, 2017
  1. Fixed: "View Order" throws exception in getReturnableQuantity

    (OFBIZ-9157)
    
    Steps to Reproduce:
    - Create a sales order
    - Add 1 orderitem with no unitPrice set (unitPrice = null) for the product
    - set the status of the order to completed
    - go to order-management and try to open the order for display like:
    https://localhost:8443/ordermgr/control/orderview?orderId=XXXXX
    
    Expected:
    - the order is displayed with status completed
    
    Actual:
    - A groovy exception is displayed.
    
    Analysis:
    The service "getReturnableQuantity" throws an exception because it returns the 
    returnablePrice = null, because the unitPrice of the orderItem was null.
    The OUT field returnablePrice is mandatory according to the service-definition. 
    The return parameter is set but the value is null, hence the exception.
    
    Solution: adjust the service-definition to allow for "null" value 
    of the returnablePrice OUT parameter.
    
    Thanks: Leonard Lin
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1779724 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 21, 2017
  2. Implemented: Birt Report Builder: an enhancement of the Birt component.

    Easier user possibility of report creation.
    (OFBIZ-6919)
    
    Fixes a small issue: the REPORT contentId is now named FLEXIBLE_REPORT
    
    Note: the BIRT_REPORT_BUILDER_USAGE_POLICY still need to be completed. Hence 
    it's for now bypassed in ContentWorker.renderContentAsText(), based on the 
    FLEXIBLE_REPORT contentId
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1779701 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 21, 2017
Commits on Jan 20, 2017
  1. No functional changes, trivial formatting issues

    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1779677 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 20, 2017
  2. Fixed: In entitymodel.xsd entity-alias for condition-expr must be req…

    …uired
    
    (OFBIZ-9184)
    
    Currently in the entitymodel.xsd the line
    
    <xs:attribute name="entity-alias" type="xs:string"/>
    
    is wrong, should be
    
    <xs:attribute name="entity-alias" type="xs:string"  use="required"/>
    
    Else in line
    
    this.entityAlias = entityAlias;
    
    in ModelViewEntity.ViewConditionExpr() 
    
    this.entityAlias 
    
    receives null.
    
    All supported branches are concerned
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1779625 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 20, 2017
  3. Fixed: JobPoller does not run and hence scheduled/async jobs are neve…

    …r run
    
    (OFBIZ-9155)
    
    Symptom:
    * services that are invoked with "dispatcher.runAsync" stay "pending" in the 
    job-list and never get executed
    * scheduled jobs don't get executed
    
    Steps to Reproduce
    * Login to /webtools
    * Schedule a Job to run in 5 mins, (for example service "clearAllEntityCaches")
    * Wait 7mins
    
    Expected:
    * the scheduled service "clearAllEntityCaches" is not "pending" anymore but 
    should have status "finished"
    
    Actual:
    * scheduled service "clearAllEntityCaches" is still "pending"
    
    Analysis:
    The problem can be reproduced with the OFBiz 16.11 branxh as well as 
    with the OFBiz 16.11.01 zip file version and the trunk
    
    JobPoller does get started on OFBiz start but does get stuck on line:
    org.apache.ofbiz.service.job.JobPoller.java: 213-215 
    
    The reason is that the "Start.ServerState" never reaches "RUNNING"
    
    Doing a full-text scan through the whole source code shows, that there is no 
    code at all that sets the ServerState to "RUNNING"
    
    Comparing it to the 15.11-branch. There used to be a line:
    serverState.compareAndSet(ServerState.STARTING, ServerState.RUNNING)
    
    no such line exists in 16.11 anymore.
    
    jleroux:  I confirm the behaviour in R16 branch as well as in trunk.
    
    Leonard's "patch" is a good solution and works for the R16 branch which is less 
    changed than the trunk when compared to R15. 
    
    The same applies to the trunk with the relative block of code which contains
    if (serverState.get() == ServerState.STOPPING) {
    
    The line Leonard propose to add was obviously missed during the recent 
    refactoring.
    
    Thanks: Leonard Lin
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1779596 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 20, 2017
Commits on Jan 19, 2017
  1. Improved: Remove the cleanGradle and cleanAnt Gradles Task

    (OFBIZ-9183)
    
    We decided to remove the cleanGradle because since we upgraded to Gradle  3 
    it causes an issue on Windows.
    
    We also decided to remove the cleanAnt Gradles Task  because it's now in 
    the R16.11.01 and R11.1 branch which should be enough for users moving from Ant
    to Gradle
    
    BTW in case of need there is this wiki reference page 
    https://cwiki.apache.org/confluence/display/OFBIZ/From+Ant+to+Gradle
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1779439 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 19, 2017
Commits on Jan 18, 2017
  1. Improved: Readability of README.md by adding some line breaks.

    There was a need of huge horizontal scroll in the Security block.
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1779311 13f79535-47bb-0310-9956-ffa450edef68
    Pranay Pandey committed Jan 18, 2017
Commits on Jan 15, 2017
  1. Fixed: add item to order cause exception

    (OFBIZ-9167)
    
    -go to https://localhost:8443/ordermgr/control/orderentry
    -create order for DemoCustomer
    -add an item
    
    console output...
    java.lang.NullPointerException
            at org.apache.ofbiz.content.content.ContentWorker.
    renderContentAsText(ContentWorker.java:368) ~[ofbiz.jar:?]
    [...]
    
    While at it I also found issues with cartLine.getName() in ftl files. It was
    also missing the dispatcher. 
    
    This was broken by OFBIZ-9164
    
    Thanks: Wai
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778889 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 15, 2017
  2. No functional change, adds a new tools/demo-backup/README.md.html fil…

    …e and
    
    related helpful pandoc.bat
    
    The README.md.html is to be used at 
    https://cwiki.apache.org/confluence/display/OFBIZ/
    The+official+demos+and+how+to+maintain+them
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778883 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 15, 2017
  3. No functional change, renames the

    tools/demo-backup/README file to
    tools/demo-backup/README.MD
    With some edition
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778882 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 15, 2017
  4. Improved: Minor spelling mistakes

    (OFBIZ-9173)
    
    Depreciation is mis-spelled as depreciatiion
    Also, an additional space before brace would improve readability
    
    Assigned is mis-spelled as assinged
    Grammar of sentence could be updated for readability.
    
    
    Thanks: David McNeill
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778881 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 15, 2017
  5. Improved: Add Geo id support for New Zealand

    (OFBIZ-9172)
    
    Currently no support for New Zealand regions in 
    framework/common/data/GeoData_*
    
    Thanks: David McNeill
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778879 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 15, 2017
Commits on Jan 14, 2017
  1. No functional changes, it's time to update this file!

    I think I'll make it a README.MD and use the same pandoc mechanism than for 
    Gradle migration page, to create a dynamic page in wiki based on this file.
    
    I'll also update the releasing page in wiki to add all files which need an 
    update when releasing. 
    
    So far, if it misses, the doap_OFBiz.rdf in website and this one
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778759 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 14, 2017
Commits on Jan 13, 2017
  1. Fixed: Clean the tools directory

    (OFBIZ-7795)
    
    In rc scripts, the calls to gradlew should be prefixed with ./
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778576 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 13, 2017
Commits on Jan 12, 2017
  1. Fixed: Refactor ContentWorkerInterface methods signatures

    (OFBIZ-9164)
    
    Fixes an issue in the ShowCartItems.ftl file reported by Deepak 
    
    Actually I was overzealous with this.
    Reverting a simple change were I changed a parameter in the signature 
    of the protected ShoppingCartItem() method from 
    ShoppingCart.ShoppingCartItemGroup to ShoppingCartItemGroup 
    should be enough
    
    Thanks: Deepak for report
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778421 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 12, 2017
  2. No functional change, just documentation in README.MD

    Adds a note for % progress indicator 
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778415 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 12, 2017
  3. No functional change, just documentation in README.MD

    Adds a note for JDBC drivers
    Move the Security section below the Quick start section
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778413 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 12, 2017
Commits on Jan 11, 2017
  1. Implemented: renamed the directory specialpurpose to plugins

    (OFBIZ-7972)
    
    In another step towards completing the plugin system for OFBiz, we renamed
    the /specialpurpose directory to /plugins and changed all occurences of the
    word "specialpurpose" to "plugins" in all files found in the system
    
    Reference discussion: http://markmail.org/message/hpyuxkmftiyn44w2
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778271 13f79535-47bb-0310-9956-ffa450edef68
    pythys committed Jan 11, 2017
Commits on Jan 9, 2017
  1. Improved: Make xssi prefix configurable

    (OFBIZ-9169)
    
    In OFBIZ-5409 a prefix was added for GET ajax requests.  
    It would be beneficial if the prefix could be configured instead of hard coded
    
    Pierre Smits suggested to make the feature multi-tenant aware. I made signature 
    and calls changes based on Chris Howe's patch.
    
    Thanks: Chris Howe and Pierre Smits 
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777942 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 9, 2017
Commits on Jan 6, 2017
  1. Implemented: New implementation of Birt. Easier user possibility of

    report creation
    (OFBIZ-6919)
    
    This are a non functional changes not yet used OOTB. 
    They are only intended to ease the sync between the svn trunk repo and 
    the github branch (using a fork)
    
    So still a WIP...
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777586 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 6, 2017
Commits on Jan 5, 2017
  1. Implemented: Create and use an OWASP PolicyFactory for content saniti…

    …zation
    
    in ContentWorker for Birt Report Builder
    (OFBIZ-9166)
    
    This is still an incomplete feature because I did not find yet a way to complete
    the BIRT_REPORT_BUILDER_USAGE_POLICY and had to bypass the sanitization for this
    case, WIP...
    
    This commit has no effect on OFBiz yet.
    
    I need to commit this now to continue to work on the main task: OFBIZ-6919
    "New implementation of Birt. Easier user possibility of report creation". 
    
    
    
    
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777451 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 5, 2017
  2. Reverts previous commit which contained unexpected changes which were…

    … not yet
    
    ready to be committed. 
    
    Only remains a not functional change, only formatting and imports  cleaning of 
    FormRenderer.java 
    
    Sorry for the trouble
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777448 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 5, 2017
Commits on Jan 4, 2017
  1. No functional change, simplifies method signature

    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777311 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 4, 2017
  2. No functional change, fixes a Javadoc issue

    I can't check here (Win7) because of:
    
    C:\projectsASF\ofbiz\framework\common\src\main\java\org\apache\ofbiz\common\
    UrlServletHelper.java:251: error: unmappable character for encoding Cp1252
            str = str.replace("´╝?", "-");
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777310 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 4, 2017
  3. Improved: Refactor ContentWorkerInterface methods signatures

    (OFBIZ-9164)
    
    While working on OFBIZ-6919 which was built on R13.07 I stumbled upon an issue 
    due to r1652852 where Adrian improved the cacheKey in 
    FormFactory.getFormFromLocation() by adding a delegator reference (Tenants). 
    
    Actually I'm not even sure it was done at r1652852 because Adrian did not 
    maintain the FormFactory svn history.
    
    Anyway, to make a long story short I had to introduce a DispatchContext 
    parameter when calling FormFactory.readFormDocument() when the code from 
    R13.07 only passed a null.
    
    This had an impact in the hierarchy tree because FormFactory.readFormDocument() 
    was called in DataResourceWorker class, where the new code was called 
    from renderDataResourceAsText(). 
    
    So I instead of only passing a Delegator I decided to pass only a 
    LocalDispatcher parameter in renderDataResourceAsText(), since we can get the 
    Delegator  from the LocalDispatcher. Doing so it had an impact on the 
    renderDataResourceAsText hierarchy tree ending in DataResourceWorkerInterface 
    and all related.
    
    I finally decided to apply the same "Change Method Signature" refactoring 
    pattern (http://refactoring.com/catalog/addParameter.html) to all cases 
    related to ContentWorkerInterface. No need to pass a delegator when you have 
    LocalDispatcher!
    
    Since last commit and revert I fixed 5 test failures and improved the code more,
     mostly formatting, comments, etc.
    
    There are very ugly method signatures out there which still need refactoring,
    but it's so much work...
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777297 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 4, 2017
  4. No functional changes, fixes methods "JavaDoc"

    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777273 13f79535-47bb-0310-9956-ffa450edef68
    JacquesLeRoux committed Jan 4, 2017