refactor(core)!: Return Arc<AccessInfo> for metadata
#4883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metadata Signed-off-by: Lzzzt <liuzitao0123@gmail.com>
|
One question: using |
|
Replied at #4845 (comment) |
Lzzzzzt
force-pushed
the
operator-info
branch
2 times, most recently
from
d6ce514
to
e45455f
Compare
Xuanwo
reviewed
Jul 12, 2024
| @@ -380,13 +380,14 @@ impl<A: Access> LayeredAccess for CompleteAccessor<A> { | |||
| &self.inner | |||
| } | |||
|
|
|||
| fn metadata(&self) -> AccessorInfo { | |||
| let mut meta = self.meta.clone(); | |||
| // Todo: May move the logic to the implement of Layer::layer of CompleteAccessor<A> | |||
There was a problem hiding this comment.
Nice idea, we can create an issue for this.
There was a problem hiding this comment.
I think the issue can be create after this refactor is done, because this may be related to the #4845 (comment)
Xuanwo
changed the title
Operator add a field to store OperatorInfoArc<AccessInfo> for metadata
Lzzzzzt
force-pushed
the
operator-info
branch
4 times, most recently
from
b4c9cfa
to
e39efee
Compare
Signed-off-by: Lzzzt <liuzitao0123@gmail.com> refactor: change the signature of `Access::info` and `AccessDyn::info` Signed-off-by: Lzzzt <liuzitao0123@gmail.com> refactor: change the signature of `Access::info` and `AccessDyn::info` Signed-off-by: Lzzzt <liuzitao0123@gmail.com> revert: revert Signed-off-by: Lzzzt <liuzitao0123@gmail.com> revert: revert Signed-off-by: Lzzzt <liuzitao0123@gmail.com> Update store.rs refactor: change the signature of `Access::info` and `AccessDyn::info` Signed-off-by: Lzzzt <liuzitao0123@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just add a field inside the
Operatorstruct and wrap theOperatorInfowithOnceCell<Arc<T>>for lazy initialize and avoid other memory allocation.#4845