From 4068d5ccb29f65d9a09daebcd232b7c8c1a2ed5a Mon Sep 17 00:00:00 2001
From: Mark Struberg <struberg@apache.org>
Date: Sat, 5 Nov 2016 11:50:59 +0000
Subject: [PATCH] OPENJPA-2674 properly closing JarFile

txs to Kaloyan Spiridonov for the catch!


git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1768201 13f79535-47bb-0310-9956-ffa450edef68
---
 .../org/apache/openjpa/enhance/InstrumentationFactory.java  | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/openjpa-kernel/src/main/java/org/apache/openjpa/enhance/InstrumentationFactory.java b/openjpa-kernel/src/main/java/org/apache/openjpa/enhance/InstrumentationFactory.java
index d13b74f02d..abd875ea24 100644
--- a/openjpa-kernel/src/main/java/org/apache/openjpa/enhance/InstrumentationFactory.java
+++ b/openjpa-kernel/src/main/java/org/apache/openjpa/enhance/InstrumentationFactory.java
@@ -369,10 +369,8 @@ private static Class<?> loadVMClass(File toolsJar, Log log, JavaVendors vendor)
      * @return True if the provided agentClassName is defined as the Agent-Class
      *         in the manifest from the provided agentJarFile. False otherwise.
      */
-    private static boolean validateAgentJarManifest(File agentJarFile, Log log,
-        String agentClassName) {
-        try {
-            JarFile jar = new JarFile(agentJarFile);
+    private static boolean validateAgentJarManifest(File agentJarFile, Log log, String agentClassName) {
+        try (JarFile jar = new JarFile(agentJarFile)) {
             Manifest manifest = jar.getManifest();
             if (manifest == null) {
                 return false;